1use rustc_ast as ast;
5use rustc_ast::{Pat, PatKind, Path};
6use rustc_hir as hir;
7use rustc_hir::def::Res;
8use rustc_hir::def_id::DefId;
9use rustc_hir::{Expr, ExprKind, HirId, find_attr};
10use rustc_middle::ty::{self, GenericArgsRef, PredicatePolarity};
11use rustc_session::{declare_lint_pass, declare_tool_lint};
12use rustc_span::hygiene::{ExpnKind, MacroKind};
13use rustc_span::{Span, sym};
14
15use crate::lints::{
16 AttributeKindInFindAttr, BadOptAccessDiag, DefaultHashTypesDiag,
17 ImplicitSysrootCrateImportDiag, LintPassByHand, NonGlobImportTypeIrInherent, QueryInstability,
18 QueryUntracked, RustcMustMatchExhaustivelyNotExhaustive, SpanUseEqCtxtDiag,
19 SymbolInternStringLiteralDiag, TyQualified, TykindDiag, TykindKind, TypeIrDirectUse,
20 TypeIrInherentUsage, TypeIrTraitUsage,
21};
22use crate::{EarlyContext, EarlyLintPass, LateContext, LateLintPass, LintContext};
23
24#[doc =
r" The `default_hash_type` lint detects use of [`std::collections::HashMap`] and"]
#[doc =
r" [`std::collections::HashSet`], suggesting the use of `FxHashMap`/`FxHashSet`."]
#[doc = r""]
#[doc =
r" This can help as `FxHasher` can perform better than the default hasher. DOS protection is"]
#[doc = r" not required as input is assumed to be trusted."]
pub static DEFAULT_HASH_TYPES: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::DEFAULT_HASH_TYPES",
default_level: ::rustc_lint_defs::Allow,
desc: "forbid HashMap and HashSet and suggest the FxHash* variants",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
25 pub rustc::DEFAULT_HASH_TYPES,
31 Allow,
32 "forbid HashMap and HashSet and suggest the FxHash* variants",
33 report_in_external_macro: true
34}
35
36pub struct DefaultHashTypes;
#[automatically_derived]
impl ::core::marker::Copy for DefaultHashTypes { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for DefaultHashTypes { }
#[automatically_derived]
impl ::core::clone::Clone for DefaultHashTypes {
#[inline]
fn clone(&self) -> DefaultHashTypes { *self }
}
impl ::rustc_lint_defs::LintPass for DefaultHashTypes {
fn name(&self) -> &'static str { "DefaultHashTypes" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[DEFAULT_HASH_TYPES]))
}
}
impl DefaultHashTypes {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[DEFAULT_HASH_TYPES]))
}
}declare_lint_pass!(DefaultHashTypes => [DEFAULT_HASH_TYPES]);
37
38impl LateLintPass<'_> for DefaultHashTypes {
39 fn check_path(&mut self, cx: &LateContext<'_>, path: &hir::Path<'_>, hir_id: HirId) {
40 let Res::Def(rustc_hir::def::DefKind::Struct, def_id) = path.res else { return };
41 if #[allow(non_exhaustive_omitted_patterns)] match cx.tcx.hir_node(hir_id) {
hir::Node::Item(hir::Item { kind: hir::ItemKind::Use(..), .. }) => true,
_ => false,
}matches!(
42 cx.tcx.hir_node(hir_id),
43 hir::Node::Item(hir::Item { kind: hir::ItemKind::Use(..), .. })
44 ) {
45 return;
47 }
48 let preferred = match cx.tcx.get_diagnostic_name(def_id) {
49 Some(sym::HashMap) => "FxHashMap",
50 Some(sym::HashSet) => "FxHashSet",
51 _ => return,
52 };
53 cx.emit_span_lint(
54 DEFAULT_HASH_TYPES,
55 path.span,
56 DefaultHashTypesDiag { preferred, used: cx.tcx.item_name(def_id) },
57 );
58 }
59}
60
61#[doc =
r" The `potential_query_instability` lint detects use of methods which can lead to"]
#[doc = r" potential query instability, such as iterating over a `HashMap`."]
#[doc = r""]
#[doc =
r" Due to the [incremental compilation](https://rustc-dev-guide.rust-lang.org/queries/incremental-compilation.html) model,"]
#[doc =
r" queries must return deterministic, stable results. `HashMap` iteration order can change"]
#[doc =
r" between compilations, and will introduce instability if query results expose the order."]
pub static POTENTIAL_QUERY_INSTABILITY: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::POTENTIAL_QUERY_INSTABILITY",
default_level: ::rustc_lint_defs::Allow,
desc: "require explicit opt-in when using potentially unstable methods or functions",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
62 pub rustc::POTENTIAL_QUERY_INSTABILITY,
69 Allow,
70 "require explicit opt-in when using potentially unstable methods or functions",
71 report_in_external_macro: true
72}
73
74#[doc =
r" The `untracked_query_information` lint detects use of methods which leak information not"]
#[doc =
r" tracked by the query system, such as whether a `Steal<T>` value has already been stolen. In"]
#[doc =
r" order not to break incremental compilation, such methods must be used very carefully or not"]
#[doc = r" at all."]
pub static UNTRACKED_QUERY_INFORMATION: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::UNTRACKED_QUERY_INFORMATION",
default_level: ::rustc_lint_defs::Allow,
desc: "require explicit opt-in when accessing information not tracked by the query system",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
75 pub rustc::UNTRACKED_QUERY_INFORMATION,
80 Allow,
81 "require explicit opt-in when accessing information not tracked by the query system",
82 report_in_external_macro: true
83}
84
85pub struct QueryStability;
#[automatically_derived]
impl ::core::marker::Copy for QueryStability { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for QueryStability { }
#[automatically_derived]
impl ::core::clone::Clone for QueryStability {
#[inline]
fn clone(&self) -> QueryStability { *self }
}
impl ::rustc_lint_defs::LintPass for QueryStability {
fn name(&self) -> &'static str { "QueryStability" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[POTENTIAL_QUERY_INSTABILITY, UNTRACKED_QUERY_INFORMATION]))
}
}
impl QueryStability {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[POTENTIAL_QUERY_INSTABILITY, UNTRACKED_QUERY_INFORMATION]))
}
}declare_lint_pass!(QueryStability => [POTENTIAL_QUERY_INSTABILITY, UNTRACKED_QUERY_INFORMATION]);
86
87impl<'tcx> LateLintPass<'tcx> for QueryStability {
88 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) {
89 if let Some((callee_def_id, span, generic_args, _recv, _args)) =
90 get_callee_span_generic_args_and_args(cx, expr)
91 && let Ok(Some(instance)) =
92 ty::Instance::try_resolve(cx.tcx, cx.typing_env(), callee_def_id, generic_args)
93 {
94 let def_id = instance.def_id();
95 if {
{
'done:
{
for i in
::rustc_hir::attrs::HasAttrs::get_attrs(def_id, &cx.tcx) {
#[allow(unused_imports)]
use rustc_hir::attrs::AttributeKind::*;
let i: &rustc_hir::Attribute = i;
match i {
rustc_hir::Attribute::Parsed(RustcLintQueryInstability) => {
break 'done Some(());
}
rustc_hir::Attribute::Unparsed(..) =>
{}
#[deny(unreachable_patterns)]
_ => {}
}
}
None
}
}
}.is_some()find_attr!(cx.tcx, def_id, RustcLintQueryInstability) {
96 cx.emit_span_lint(
97 POTENTIAL_QUERY_INSTABILITY,
98 span,
99 QueryInstability { query: cx.tcx.item_name(def_id) },
100 );
101 } else if has_unstable_into_iter_predicate(cx, callee_def_id, generic_args) {
102 let call_span = span.with_hi(expr.span.hi());
103 cx.emit_span_lint(
104 POTENTIAL_QUERY_INSTABILITY,
105 call_span,
106 QueryInstability { query: sym::into_iter },
107 );
108 }
109
110 if {
{
'done:
{
for i in
::rustc_hir::attrs::HasAttrs::get_attrs(def_id, &cx.tcx) {
#[allow(unused_imports)]
use rustc_hir::attrs::AttributeKind::*;
let i: &rustc_hir::Attribute = i;
match i {
rustc_hir::Attribute::Parsed(RustcLintUntrackedQueryInformation)
=> {
break 'done Some(());
}
rustc_hir::Attribute::Unparsed(..) =>
{}
#[deny(unreachable_patterns)]
_ => {}
}
}
None
}
}
}.is_some()find_attr!(cx.tcx, def_id, RustcLintUntrackedQueryInformation) {
111 cx.emit_span_lint(
112 UNTRACKED_QUERY_INFORMATION,
113 span,
114 QueryUntracked { method: cx.tcx.item_name(def_id) },
115 );
116 }
117 }
118 }
119}
120
121fn has_unstable_into_iter_predicate<'tcx>(
122 cx: &LateContext<'tcx>,
123 callee_def_id: DefId,
124 generic_args: GenericArgsRef<'tcx>,
125) -> bool {
126 let Some(into_iterator_def_id) = cx.tcx.get_diagnostic_item(sym::IntoIterator) else {
127 return false;
128 };
129 let Some(into_iter_fn_def_id) = cx.tcx.lang_items().into_iter_fn() else {
130 return false;
131 };
132 let predicates = cx.tcx.predicates_of(callee_def_id).instantiate(cx.tcx, generic_args);
133 for (predicate, _) in predicates {
134 let Some(trait_pred) = predicate.as_trait_clause() else {
135 continue;
136 };
137 if trait_pred.def_id() != into_iterator_def_id
138 || trait_pred.polarity() != PredicatePolarity::Positive
139 {
140 continue;
141 }
142 let into_iter_fn_args =
144 cx.tcx.instantiate_bound_regions_with_erased(trait_pred.skip_norm_wip()).trait_ref.args;
145 let Ok(Some(instance)) = ty::Instance::try_resolve(
146 cx.tcx,
147 cx.typing_env(),
148 into_iter_fn_def_id,
149 into_iter_fn_args,
150 ) else {
151 continue;
152 };
153 if {
{
'done:
{
for i in
::rustc_hir::attrs::HasAttrs::get_attrs(instance.def_id(),
&cx.tcx) {
#[allow(unused_imports)]
use rustc_hir::attrs::AttributeKind::*;
let i: &rustc_hir::Attribute = i;
match i {
rustc_hir::Attribute::Parsed(RustcLintQueryInstability) => {
break 'done Some(());
}
rustc_hir::Attribute::Unparsed(..) =>
{}
#[deny(unreachable_patterns)]
_ => {}
}
}
None
}
}
}.is_some()find_attr!(cx.tcx, instance.def_id(), RustcLintQueryInstability) {
156 return true;
157 }
158 }
159 false
160}
161
162fn get_callee_span_generic_args_and_args<'tcx>(
166 cx: &LateContext<'tcx>,
167 expr: &'tcx Expr<'tcx>,
168) -> Option<(DefId, Span, GenericArgsRef<'tcx>, Option<&'tcx Expr<'tcx>>, &'tcx [Expr<'tcx>])> {
169 if let ExprKind::Call(callee, args) = expr.kind
170 && let callee_ty = cx.typeck_results().expr_ty(callee)
171 && let ty::FnDef(callee_def_id, generic_args) = callee_ty.kind()
172 {
173 return Some((*callee_def_id, callee.span, generic_args, None, args));
174 }
175 if let ExprKind::MethodCall(segment, recv, args, _) = expr.kind
176 && let Some(method_def_id) = cx.typeck_results().type_dependent_def_id(expr.hir_id)
177 {
178 let generic_args = cx.typeck_results().node_args(expr.hir_id);
179 return Some((method_def_id, segment.ident.span, generic_args, Some(recv), args));
180 }
181 None
182}
183
184#[doc =
r" The `usage_of_ty_tykind` lint detects usages of `ty::TyKind::<kind>`,"]
#[doc = r" where `ty::<kind>` would suffice."]
pub static USAGE_OF_TY_TYKIND: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::USAGE_OF_TY_TYKIND",
default_level: ::rustc_lint_defs::Allow,
desc: "usage of `ty::TyKind` outside of the `ty::sty` module",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
185 pub rustc::USAGE_OF_TY_TYKIND,
188 Allow,
189 "usage of `ty::TyKind` outside of the `ty::sty` module",
190 report_in_external_macro: true
191}
192
193#[doc = r" The `usage_of_qualified_ty` lint detects usages of `ty::TyKind`,"]
#[doc = r" where `Ty` should be used instead."]
pub static USAGE_OF_QUALIFIED_TY: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::USAGE_OF_QUALIFIED_TY",
default_level: ::rustc_lint_defs::Allow,
desc: "using `ty::{Ty,TyCtxt}` instead of importing it",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
194 pub rustc::USAGE_OF_QUALIFIED_TY,
197 Allow,
198 "using `ty::{Ty,TyCtxt}` instead of importing it",
199 report_in_external_macro: true
200}
201
202pub struct TyTyKind;
#[automatically_derived]
impl ::core::marker::Copy for TyTyKind { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for TyTyKind { }
#[automatically_derived]
impl ::core::clone::Clone for TyTyKind {
#[inline]
fn clone(&self) -> TyTyKind { *self }
}
impl ::rustc_lint_defs::LintPass for TyTyKind {
fn name(&self) -> &'static str { "TyTyKind" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[USAGE_OF_TY_TYKIND, USAGE_OF_QUALIFIED_TY]))
}
}
impl TyTyKind {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[USAGE_OF_TY_TYKIND, USAGE_OF_QUALIFIED_TY]))
}
}declare_lint_pass!(TyTyKind => [
203 USAGE_OF_TY_TYKIND,
204 USAGE_OF_QUALIFIED_TY,
205]);
206
207impl<'tcx> LateLintPass<'tcx> for TyTyKind {
208 fn check_path(
209 &mut self,
210 cx: &LateContext<'tcx>,
211 path: &rustc_hir::Path<'tcx>,
212 _: rustc_hir::HirId,
213 ) {
214 if let Some(segment) = path.segments.iter().nth_back(1)
215 && lint_ty_kind_usage(cx, &segment.res)
216 {
217 let span =
218 path.span.with_hi(segment.args.map_or(segment.ident.span, |a| a.span_ext).hi());
219 cx.emit_span_lint(USAGE_OF_TY_TYKIND, path.span, TykindKind { suggestion: span });
220 }
221 }
222
223 fn check_ty(&mut self, cx: &LateContext<'_>, ty: &'tcx hir::Ty<'tcx, hir::AmbigArg>) {
224 match &ty.kind {
225 hir::TyKind::Path(hir::QPath::Resolved(_, path)) => {
226 if lint_ty_kind_usage(cx, &path.res) {
227 let span = match cx.tcx.parent_hir_node(ty.hir_id) {
228 hir::Node::PatExpr(hir::PatExpr {
229 kind: hir::PatExprKind::Path(qpath),
230 ..
231 })
232 | hir::Node::Pat(hir::Pat {
233 kind:
234 hir::PatKind::TupleStruct(qpath, ..) | hir::PatKind::Struct(qpath, ..),
235 ..
236 })
237 | hir::Node::Expr(
238 hir::Expr { kind: hir::ExprKind::Path(qpath), .. }
239 | &hir::Expr { kind: hir::ExprKind::Struct(qpath, ..), .. },
240 ) => {
241 if let hir::QPath::TypeRelative(qpath_ty, ..) = qpath
242 && qpath_ty.hir_id == ty.hir_id
243 {
244 Some(path.span)
245 } else {
246 None
247 }
248 }
249 _ => None,
250 };
251
252 match span {
253 Some(span) => {
254 cx.emit_span_lint(
255 USAGE_OF_TY_TYKIND,
256 path.span,
257 TykindKind { suggestion: span },
258 );
259 }
260 None => cx.emit_span_lint(USAGE_OF_TY_TYKIND, path.span, TykindDiag),
261 }
262 } else if !ty.span.from_expansion()
263 && path.segments.len() > 1
264 && let Some(ty) = is_ty_or_ty_ctxt(cx, path)
265 {
266 cx.emit_span_lint(
267 USAGE_OF_QUALIFIED_TY,
268 path.span,
269 TyQualified { ty, suggestion: path.span },
270 );
271 }
272 }
273 _ => {}
274 }
275 }
276}
277
278fn lint_ty_kind_usage(cx: &LateContext<'_>, res: &Res) -> bool {
279 if let Some(did) = res.opt_def_id() {
280 cx.tcx.is_diagnostic_item(sym::TyKind, did) || cx.tcx.is_diagnostic_item(sym::IrTyKind, did)
281 } else {
282 false
283 }
284}
285
286fn is_ty_or_ty_ctxt(cx: &LateContext<'_>, path: &hir::Path<'_>) -> Option<String> {
287 match path.res {
288 Res::Def(_, def_id) => {
289 if let Some(name @ (sym::Ty | sym::TyCtxt)) = cx.tcx.get_diagnostic_name(def_id) {
290 return Some(::alloc::__export::must_use({
::alloc::fmt::format(format_args!("{0}{1}", name,
gen_args(path.segments.last().unwrap())))
})format!("{}{}", name, gen_args(path.segments.last().unwrap())));
291 }
292 }
293 Res::SelfTyAlias { alias_to: did, is_trait_impl: false, .. } => {
295 if let ty::Adt(adt, args) =
296 cx.tcx.type_of(did).instantiate_identity().skip_norm_wip().kind()
297 && let Some(name @ (sym::Ty | sym::TyCtxt)) = cx.tcx.get_diagnostic_name(adt.did())
298 {
299 return Some(::alloc::__export::must_use({
::alloc::fmt::format(format_args!("{0}<{1}>", name, args[0]))
})format!("{}<{}>", name, args[0]));
300 }
301 }
302 _ => (),
303 }
304
305 None
306}
307
308fn gen_args(segment: &hir::PathSegment<'_>) -> String {
309 if let Some(args) = &segment.args {
310 let lifetimes = args
311 .args
312 .iter()
313 .filter_map(|arg| {
314 if let hir::GenericArg::Lifetime(lt) = arg {
315 Some(lt.ident.to_string())
316 } else {
317 None
318 }
319 })
320 .collect::<Vec<_>>();
321
322 if !lifetimes.is_empty() {
323 return ::alloc::__export::must_use({
::alloc::fmt::format(format_args!("<{0}>", lifetimes.join(", ")))
})format!("<{}>", lifetimes.join(", "));
324 }
325 }
326
327 String::new()
328}
329
330#[doc = r" The `non_glob_import_of_type_ir_inherent_item` lint detects"]
#[doc = r" non-glob imports of module `rustc_type_ir::inherent`."]
pub static NON_GLOB_IMPORT_OF_TYPE_IR_INHERENT: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::NON_GLOB_IMPORT_OF_TYPE_IR_INHERENT",
default_level: ::rustc_lint_defs::Allow,
desc: "non-glob import of `rustc_type_ir::inherent`",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
331 pub rustc::NON_GLOB_IMPORT_OF_TYPE_IR_INHERENT,
334 Allow,
335 "non-glob import of `rustc_type_ir::inherent`",
336 report_in_external_macro: true
337}
338
339#[doc =
r" The `usage_of_type_ir_inherent` lint detects usage of `rustc_type_ir::inherent`."]
#[doc = r""]
#[doc = r" This module should only be used within the trait solver."]
pub static USAGE_OF_TYPE_IR_INHERENT: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::USAGE_OF_TYPE_IR_INHERENT",
default_level: ::rustc_lint_defs::Allow,
desc: "usage `rustc_type_ir::inherent` outside of trait system",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
340 pub rustc::USAGE_OF_TYPE_IR_INHERENT,
344 Allow,
345 "usage `rustc_type_ir::inherent` outside of trait system",
346 report_in_external_macro: true
347}
348
349#[doc =
r" The `usage_of_type_ir_traits` lint detects usage of `rustc_type_ir::Interner`,"]
#[doc = r" or `rustc_infer::InferCtxtLike`."]
#[doc = r""]
#[doc =
r" Methods of this trait should only be used within the type system abstraction layer,"]
#[doc =
r" and in the generic next trait solver implementation. Look for an analogously named"]
#[doc = r" method on `TyCtxt` or `InferCtxt` (respectively)."]
pub static USAGE_OF_TYPE_IR_TRAITS: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::USAGE_OF_TYPE_IR_TRAITS",
default_level: ::rustc_lint_defs::Allow,
desc: "usage `rustc_type_ir`-specific abstraction traits outside of trait system",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
350 pub rustc::USAGE_OF_TYPE_IR_TRAITS,
357 Allow,
358 "usage `rustc_type_ir`-specific abstraction traits outside of trait system",
359 report_in_external_macro: true
360}
361#[doc =
r" The `direct_use_of_rustc_type_ir` lint detects usage of `rustc_type_ir`."]
#[doc = r""]
#[doc =
r" This module should only be used within the trait solver and some desirable"]
#[doc = r" crates like rustc_middle."]
pub static DIRECT_USE_OF_RUSTC_TYPE_IR: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::DIRECT_USE_OF_RUSTC_TYPE_IR",
default_level: ::rustc_lint_defs::Allow,
desc: "usage `rustc_type_ir` abstraction outside of trait system",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
362 pub rustc::DIRECT_USE_OF_RUSTC_TYPE_IR,
367 Allow,
368 "usage `rustc_type_ir` abstraction outside of trait system",
369 report_in_external_macro: true
370}
371
372pub struct TypeIr;
#[automatically_derived]
impl ::core::marker::Copy for TypeIr { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for TypeIr { }
#[automatically_derived]
impl ::core::clone::Clone for TypeIr {
#[inline]
fn clone(&self) -> TypeIr { *self }
}
impl ::rustc_lint_defs::LintPass for TypeIr {
fn name(&self) -> &'static str { "TypeIr" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[DIRECT_USE_OF_RUSTC_TYPE_IR,
NON_GLOB_IMPORT_OF_TYPE_IR_INHERENT,
USAGE_OF_TYPE_IR_INHERENT, USAGE_OF_TYPE_IR_TRAITS]))
}
}
impl TypeIr {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[DIRECT_USE_OF_RUSTC_TYPE_IR,
NON_GLOB_IMPORT_OF_TYPE_IR_INHERENT,
USAGE_OF_TYPE_IR_INHERENT, USAGE_OF_TYPE_IR_TRAITS]))
}
}declare_lint_pass!(TypeIr => [
373 DIRECT_USE_OF_RUSTC_TYPE_IR,
374 NON_GLOB_IMPORT_OF_TYPE_IR_INHERENT,
375 USAGE_OF_TYPE_IR_INHERENT,
376 USAGE_OF_TYPE_IR_TRAITS
377]);
378
379impl<'tcx> LateLintPass<'tcx> for TypeIr {
380 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx hir::Expr<'tcx>) {
381 let res_def_id = match expr.kind {
382 hir::ExprKind::Path(hir::QPath::Resolved(_, path)) => path.res.opt_def_id(),
383 hir::ExprKind::Path(hir::QPath::TypeRelative(..)) | hir::ExprKind::MethodCall(..) => {
384 cx.typeck_results().type_dependent_def_id(expr.hir_id)
385 }
386 _ => return,
387 };
388 let Some(res_def_id) = res_def_id else {
389 return;
390 };
391 if let Some(assoc_item) = cx.tcx.opt_associated_item(res_def_id)
392 && let Some(trait_def_id) = assoc_item.trait_container(cx.tcx)
393 && (cx.tcx.is_diagnostic_item(sym::type_ir_interner, trait_def_id)
394 | cx.tcx.is_diagnostic_item(sym::type_ir_infer_ctxt_like, trait_def_id))
395 {
396 cx.emit_span_lint(USAGE_OF_TYPE_IR_TRAITS, expr.span, TypeIrTraitUsage);
397 }
398 }
399
400 fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::Item<'tcx>) {
401 let rustc_hir::ItemKind::Use(path, kind) = item.kind else { return };
402
403 let is_mod_inherent = |res: Res| {
404 res.opt_def_id()
405 .is_some_and(|def_id| cx.tcx.is_diagnostic_item(sym::type_ir_inherent, def_id))
406 };
407
408 if let Some(seg) = path.segments.iter().find(|seg| is_mod_inherent(seg.res)) {
410 cx.emit_span_lint(USAGE_OF_TYPE_IR_INHERENT, seg.ident.span, TypeIrInherentUsage);
411 }
412 else if let Some(type_ns) = path.res.type_ns
414 && is_mod_inherent(type_ns)
415 {
416 cx.emit_span_lint(
417 USAGE_OF_TYPE_IR_INHERENT,
418 path.segments.last().unwrap().ident.span,
419 TypeIrInherentUsage,
420 );
421 }
422
423 let (lo, hi, snippet) = match path.segments {
424 [.., penultimate, segment] if is_mod_inherent(penultimate.res) => {
425 (segment.ident.span, item.kind.ident().unwrap().span, "*")
426 }
427 [.., segment]
428 if let Some(type_ns) = path.res.type_ns
429 && is_mod_inherent(type_ns)
430 && let rustc_hir::UseKind::Single(ident) = kind =>
431 {
432 let (lo, snippet) =
433 match cx.tcx.sess.source_map().span_to_snippet(path.span).as_deref() {
434 Ok("self") => (path.span, "*"),
435 _ => (segment.ident.span.shrink_to_hi(), "::*"),
436 };
437 (lo, if segment.ident == ident { lo } else { ident.span }, snippet)
438 }
439 _ => return,
440 };
441 cx.emit_span_lint(
442 NON_GLOB_IMPORT_OF_TYPE_IR_INHERENT,
443 path.span,
444 NonGlobImportTypeIrInherent { suggestion: lo.eq_ctxt(hi).then(|| lo.to(hi)), snippet },
445 );
446 }
447
448 fn check_path(
449 &mut self,
450 cx: &LateContext<'tcx>,
451 path: &rustc_hir::Path<'tcx>,
452 _: rustc_hir::HirId,
453 ) {
454 if let Some(seg) = path.segments.iter().find(|seg| {
455 seg.res
456 .opt_def_id()
457 .is_some_and(|def_id| cx.tcx.is_diagnostic_item(sym::type_ir, def_id))
458 }) {
459 cx.emit_span_lint(DIRECT_USE_OF_RUSTC_TYPE_IR, seg.ident.span, TypeIrDirectUse);
460 }
461 }
462}
463
464#[doc =
r" The `lint_pass_impl_without_macro` detects manual implementations of a lint"]
#[doc = r" pass, without using [`declare_lint_pass`] or [`impl_lint_pass`]."]
pub static LINT_PASS_IMPL_WITHOUT_MACRO: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::LINT_PASS_IMPL_WITHOUT_MACRO",
default_level: ::rustc_lint_defs::Allow,
desc: "`impl LintPass` without the `declare_lint_pass!` or `impl_lint_pass!` macros",
edition_lint_opts: None,
report_in_external_macro: false,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
465 pub rustc::LINT_PASS_IMPL_WITHOUT_MACRO,
468 Allow,
469 "`impl LintPass` without the `declare_lint_pass!` or `impl_lint_pass!` macros"
470}
471
472pub struct LintPassImpl;
#[automatically_derived]
impl ::core::marker::Copy for LintPassImpl { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for LintPassImpl { }
#[automatically_derived]
impl ::core::clone::Clone for LintPassImpl {
#[inline]
fn clone(&self) -> LintPassImpl { *self }
}
impl ::rustc_lint_defs::LintPass for LintPassImpl {
fn name(&self) -> &'static str { "LintPassImpl" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[LINT_PASS_IMPL_WITHOUT_MACRO]))
}
}
impl LintPassImpl {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[LINT_PASS_IMPL_WITHOUT_MACRO]))
}
}declare_lint_pass!(LintPassImpl => [LINT_PASS_IMPL_WITHOUT_MACRO]);
473
474impl EarlyLintPass for LintPassImpl {
475 fn check_item(&mut self, cx: &EarlyContext<'_>, item: &ast::Item) {
476 if let ast::ItemKind::Impl(ast::Impl { of_trait: Some(of_trait), .. }) = &item.kind
477 && let Some(last) = of_trait.trait_ref.path.segments.last()
478 && last.ident.name == sym::LintPass
479 {
480 let expn_data = of_trait.trait_ref.path.span.ctxt().outer_expn_data();
481 let call_site = expn_data.call_site;
482 if expn_data.kind != ExpnKind::Macro(MacroKind::Bang, sym::impl_lint_pass)
483 && call_site.ctxt().outer_expn_data().kind
484 != ExpnKind::Macro(MacroKind::Bang, sym::declare_lint_pass)
485 {
486 cx.emit_span_lint(
487 LINT_PASS_IMPL_WITHOUT_MACRO,
488 of_trait.trait_ref.path.span,
489 LintPassByHand,
490 );
491 }
492 }
493 }
494}
495
496#[doc =
r" The `bad_opt_access` lint detects accessing options by field instead of"]
#[doc = r" the wrapper function."]
pub static BAD_OPT_ACCESS: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::BAD_OPT_ACCESS",
default_level: ::rustc_lint_defs::Deny,
desc: "prevent using options by field access when there is a wrapper function",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
497 pub rustc::BAD_OPT_ACCESS,
500 Deny,
501 "prevent using options by field access when there is a wrapper function",
502 report_in_external_macro: true
503}
504
505pub struct BadOptAccess;
#[automatically_derived]
impl ::core::marker::Copy for BadOptAccess { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for BadOptAccess { }
#[automatically_derived]
impl ::core::clone::Clone for BadOptAccess {
#[inline]
fn clone(&self) -> BadOptAccess { *self }
}
impl ::rustc_lint_defs::LintPass for BadOptAccess {
fn name(&self) -> &'static str { "BadOptAccess" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[BAD_OPT_ACCESS]))
}
}
impl BadOptAccess {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[BAD_OPT_ACCESS]))
}
}declare_lint_pass!(BadOptAccess => [BAD_OPT_ACCESS]);
506
507impl LateLintPass<'_> for BadOptAccess {
508 fn check_expr(&mut self, cx: &LateContext<'_>, expr: &hir::Expr<'_>) {
509 let hir::ExprKind::Field(base, target) = expr.kind else { return };
510 let Some(adt_def) = cx.typeck_results().expr_ty(base).ty_adt_def() else { return };
511 if !{
{
'done:
{
for i in
::rustc_hir::attrs::HasAttrs::get_attrs(adt_def.did(),
&cx.tcx) {
#[allow(unused_imports)]
use rustc_hir::attrs::AttributeKind::*;
let i: &rustc_hir::Attribute = i;
match i {
rustc_hir::Attribute::Parsed(RustcLintOptTy) => {
break 'done Some(());
}
rustc_hir::Attribute::Unparsed(..) =>
{}
#[deny(unreachable_patterns)]
_ => {}
}
}
None
}
}
}.is_some()find_attr!(cx.tcx, adt_def.did(), RustcLintOptTy) {
514 return;
515 }
516
517 for field in adt_def.all_fields() {
518 if field.name == target.name
519 && let Some(lint_message) = {
{
'done:
{
for i in
::rustc_hir::attrs::HasAttrs::get_attrs(field.did, &cx.tcx) {
#[allow(unused_imports)]
use rustc_hir::attrs::AttributeKind::*;
let i: &rustc_hir::Attribute = i;
match i {
rustc_hir::Attribute::Parsed(RustcLintOptDenyFieldAccess {
lint_message }) => {
break 'done Some(lint_message);
}
rustc_hir::Attribute::Unparsed(..) =>
{}
#[deny(unreachable_patterns)]
_ => {}
}
}
None
}
}
}find_attr!(cx.tcx, field.did, RustcLintOptDenyFieldAccess { lint_message, } => lint_message)
520 {
521 cx.emit_span_lint(
522 BAD_OPT_ACCESS,
523 expr.span,
524 BadOptAccessDiag { msg: lint_message.as_str() },
525 );
526 }
527 }
528 }
529}
530
531pub static SPAN_USE_EQ_CTXT: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::SPAN_USE_EQ_CTXT",
default_level: ::rustc_lint_defs::Allow,
desc: "forbid uses of `==` with `Span::ctxt`, suggest `Span::eq_ctxt` instead",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
532 pub rustc::SPAN_USE_EQ_CTXT,
533 Allow,
534 "forbid uses of `==` with `Span::ctxt`, suggest `Span::eq_ctxt` instead",
535 report_in_external_macro: true
536}
537
538pub struct SpanUseEqCtxt;
#[automatically_derived]
impl ::core::marker::Copy for SpanUseEqCtxt { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for SpanUseEqCtxt { }
#[automatically_derived]
impl ::core::clone::Clone for SpanUseEqCtxt {
#[inline]
fn clone(&self) -> SpanUseEqCtxt { *self }
}
impl ::rustc_lint_defs::LintPass for SpanUseEqCtxt {
fn name(&self) -> &'static str { "SpanUseEqCtxt" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[SPAN_USE_EQ_CTXT]))
}
}
impl SpanUseEqCtxt {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[SPAN_USE_EQ_CTXT]))
}
}declare_lint_pass!(SpanUseEqCtxt => [SPAN_USE_EQ_CTXT]);
539
540impl<'tcx> LateLintPass<'tcx> for SpanUseEqCtxt {
541 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &hir::Expr<'_>) {
542 if let hir::ExprKind::Binary(
543 hir::BinOp { node: hir::BinOpKind::Eq | hir::BinOpKind::Ne, .. },
544 lhs,
545 rhs,
546 ) = expr.kind
547 {
548 if is_span_ctxt_call(cx, lhs) && is_span_ctxt_call(cx, rhs) {
549 cx.emit_span_lint(SPAN_USE_EQ_CTXT, expr.span, SpanUseEqCtxtDiag);
550 }
551 }
552 }
553}
554
555fn is_span_ctxt_call(cx: &LateContext<'_>, expr: &hir::Expr<'_>) -> bool {
556 match &expr.kind {
557 hir::ExprKind::MethodCall(..) => cx
558 .typeck_results()
559 .type_dependent_def_id(expr.hir_id)
560 .is_some_and(|call_did| cx.tcx.is_diagnostic_item(sym::SpanCtxt, call_did)),
561
562 _ => false,
563 }
564}
565
566#[doc =
r" The `symbol_intern_string_literal` detects `Symbol::intern` being called on a string literal"]
pub static SYMBOL_INTERN_STRING_LITERAL: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::SYMBOL_INTERN_STRING_LITERAL",
default_level: ::rustc_lint_defs::Allow,
desc: "Forbid uses of string literals in `Symbol::intern`, suggesting preinterning instead",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
567 pub rustc::SYMBOL_INTERN_STRING_LITERAL,
569 Allow,
570 "Forbid uses of string literals in `Symbol::intern`, suggesting preinterning instead",
571 report_in_external_macro: true
572}
573
574pub struct SymbolInternStringLiteral;
#[automatically_derived]
impl ::core::marker::Copy for SymbolInternStringLiteral { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for SymbolInternStringLiteral { }
#[automatically_derived]
impl ::core::clone::Clone for SymbolInternStringLiteral {
#[inline]
fn clone(&self) -> SymbolInternStringLiteral { *self }
}
impl ::rustc_lint_defs::LintPass for SymbolInternStringLiteral {
fn name(&self) -> &'static str { "SymbolInternStringLiteral" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[SYMBOL_INTERN_STRING_LITERAL]))
}
}
impl SymbolInternStringLiteral {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[SYMBOL_INTERN_STRING_LITERAL]))
}
}declare_lint_pass!(SymbolInternStringLiteral => [SYMBOL_INTERN_STRING_LITERAL]);
575
576impl<'tcx> LateLintPass<'tcx> for SymbolInternStringLiteral {
577 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx rustc_hir::Expr<'tcx>) {
578 if let hir::ExprKind::Call(path, [arg]) = expr.kind
579 && let hir::ExprKind::Path(ref qpath) = path.kind
580 && let Some(def_id) = cx.qpath_res(qpath, path.hir_id).opt_def_id()
581 && cx.tcx.is_diagnostic_item(sym::SymbolIntern, def_id)
582 && let hir::ExprKind::Lit(kind) = arg.kind
583 && let rustc_ast::LitKind::Str(_, _) = kind.node
584 {
585 cx.emit_span_lint(
586 SYMBOL_INTERN_STRING_LITERAL,
587 kind.span,
588 SymbolInternStringLiteralDiag,
589 );
590 }
591 }
592}
593
594#[doc =
r" The `implicit_sysroot_crate_import` detects use of `extern crate` to import non-sysroot crates"]
#[doc =
r" (e.g. crates.io deps) from the sysroot, which is dangerous because these crates are not guaranteed"]
#[doc =
r" to exist exactly once, and so may be missing entirely or appear multiple times resulting in ambiguity."]
pub static IMPLICIT_SYSROOT_CRATE_IMPORT: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::IMPLICIT_SYSROOT_CRATE_IMPORT",
default_level: ::rustc_lint_defs::Allow,
desc: "Forbid uses of non-sysroot crates in `extern crate`",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
595 pub rustc::IMPLICIT_SYSROOT_CRATE_IMPORT,
599 Allow,
600 "Forbid uses of non-sysroot crates in `extern crate`",
601 report_in_external_macro: true
602}
603
604pub struct ImplicitSysrootCrateImport;
#[automatically_derived]
impl ::core::marker::Copy for ImplicitSysrootCrateImport { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for ImplicitSysrootCrateImport { }
#[automatically_derived]
impl ::core::clone::Clone for ImplicitSysrootCrateImport {
#[inline]
fn clone(&self) -> ImplicitSysrootCrateImport { *self }
}
impl ::rustc_lint_defs::LintPass for ImplicitSysrootCrateImport {
fn name(&self) -> &'static str { "ImplicitSysrootCrateImport" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[IMPLICIT_SYSROOT_CRATE_IMPORT]))
}
}
impl ImplicitSysrootCrateImport {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[IMPLICIT_SYSROOT_CRATE_IMPORT]))
}
}declare_lint_pass!(ImplicitSysrootCrateImport => [IMPLICIT_SYSROOT_CRATE_IMPORT]);
605
606impl EarlyLintPass for ImplicitSysrootCrateImport {
607 fn check_item(&mut self, cx: &EarlyContext<'_>, item: &ast::Item) {
608 fn is_whitelisted(crate_name: &str) -> bool {
609 crate_name.starts_with("rustc_")
611 || #[allow(non_exhaustive_omitted_patterns)] match crate_name {
"test" | "self" | "core" | "alloc" | "std" | "proc_macro" |
"tikv_jemalloc_sys" => true,
_ => false,
}matches!(
612 crate_name,
613 "test" | "self" | "core" | "alloc" | "std" | "proc_macro" | "tikv_jemalloc_sys"
614 )
615 }
616
617 if let ast::ItemKind::ExternCrate(original_name, imported_name) = &item.kind {
618 let name = original_name.as_ref().unwrap_or(&imported_name.name).as_str();
619 let externs = &cx.builder.sess().opts.externs;
620 if externs.get(name).is_none() && !is_whitelisted(name) {
621 cx.emit_span_lint(
622 IMPLICIT_SYSROOT_CRATE_IMPORT,
623 item.span,
624 ImplicitSysrootCrateImportDiag { name },
625 );
626 }
627 }
628 }
629}
630
631pub static BAD_USE_OF_FIND_ATTR: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::BAD_USE_OF_FIND_ATTR",
default_level: ::rustc_lint_defs::Allow,
desc: "Forbid `AttributeKind::` as a prefix in `find_attr!` macros.",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
632 pub rustc::BAD_USE_OF_FIND_ATTR,
633 Allow,
634 "Forbid `AttributeKind::` as a prefix in `find_attr!` macros.",
635 report_in_external_macro: true
636}
637pub struct BadUseOfFindAttr;
#[automatically_derived]
impl ::core::marker::Copy for BadUseOfFindAttr { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for BadUseOfFindAttr { }
#[automatically_derived]
impl ::core::clone::Clone for BadUseOfFindAttr {
#[inline]
fn clone(&self) -> BadUseOfFindAttr { *self }
}
impl ::rustc_lint_defs::LintPass for BadUseOfFindAttr {
fn name(&self) -> &'static str { "BadUseOfFindAttr" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[BAD_USE_OF_FIND_ATTR]))
}
}
impl BadUseOfFindAttr {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[BAD_USE_OF_FIND_ATTR]))
}
}declare_lint_pass!(BadUseOfFindAttr => [BAD_USE_OF_FIND_ATTR]);
638
639impl EarlyLintPass for BadUseOfFindAttr {
640 fn check_arm(&mut self, cx: &EarlyContext<'_>, arm: &rustc_ast::Arm) {
641 fn path_contains_attribute_kind(cx: &EarlyContext<'_>, path: &Path) {
642 for segment in &path.segments {
643 if segment.ident.as_str() == "AttributeKind" {
644 cx.emit_span_lint(
645 BAD_USE_OF_FIND_ATTR,
646 segment.span(),
647 AttributeKindInFindAttr,
648 );
649 }
650 }
651 }
652
653 fn find_attr_kind_in_pat(cx: &EarlyContext<'_>, pat: &Pat) {
654 match &pat.kind {
655 PatKind::Struct(_, path, fields, _) => {
656 path_contains_attribute_kind(cx, path);
657 for field in fields {
658 find_attr_kind_in_pat(cx, &field.pat);
659 }
660 }
661 PatKind::TupleStruct(_, path, fields) => {
662 path_contains_attribute_kind(cx, path);
663 for field in fields {
664 find_attr_kind_in_pat(cx, &field);
665 }
666 }
667 PatKind::Or(options) => {
668 for pat in options {
669 find_attr_kind_in_pat(cx, pat);
670 }
671 }
672 PatKind::Path(_, path) => {
673 path_contains_attribute_kind(cx, path);
674 }
675 PatKind::Tuple(elems) => {
676 for pat in elems {
677 find_attr_kind_in_pat(cx, pat);
678 }
679 }
680 PatKind::Box(pat) => {
681 find_attr_kind_in_pat(cx, pat);
682 }
683 PatKind::Deref(pat) => {
684 find_attr_kind_in_pat(cx, pat);
685 }
686 PatKind::Ref(..) => {
687 find_attr_kind_in_pat(cx, pat);
688 }
689 PatKind::Slice(elems) => {
690 for pat in elems {
691 find_attr_kind_in_pat(cx, pat);
692 }
693 }
694
695 PatKind::Guard(pat, ..) => {
696 find_attr_kind_in_pat(cx, pat);
697 }
698 PatKind::Paren(pat) => {
699 find_attr_kind_in_pat(cx, pat);
700 }
701 PatKind::Expr(..)
702 | PatKind::Range(..)
703 | PatKind::MacCall(..)
704 | PatKind::Rest
705 | PatKind::Missing
706 | PatKind::Err(..)
707 | PatKind::Ident(..)
708 | PatKind::Never
709 | PatKind::Wild => {}
710 }
711 }
712
713 if let Some(expn_data) = arm.span.source_callee()
714 && let ExpnKind::Macro(_, name) = expn_data.kind
715 && name.as_str() == "find_attr"
716 {
717 find_attr_kind_in_pat(cx, &arm.pat);
718 }
719 }
720}
721
722pub static RUSTC_MUST_MATCH_EXHAUSTIVELY: &::rustc_lint_defs::Lint =
&::rustc_lint_defs::Lint {
name: &"rustc::RUSTC_MUST_MATCH_EXHAUSTIVELY",
default_level: ::rustc_lint_defs::Allow,
desc: "Forbids matches with wildcards, or if-let matching on enums marked with `#[rustc_must_match_exhaustively]`",
edition_lint_opts: None,
report_in_external_macro: true,
future_incompatible: None,
is_externally_loaded: true,
crate_level_only: false,
..::rustc_lint_defs::Lint::default_fields_for_macro()
};declare_tool_lint! {
723 pub rustc::RUSTC_MUST_MATCH_EXHAUSTIVELY,
724 Allow,
725 "Forbids matches with wildcards, or if-let matching on enums marked with `#[rustc_must_match_exhaustively]`",
726 report_in_external_macro: true
727}
728pub struct RustcMustMatchExhaustively;
#[automatically_derived]
impl ::core::marker::Copy for RustcMustMatchExhaustively { }
#[automatically_derived]
#[doc(hidden)]
unsafe impl ::core::clone::TrivialClone for RustcMustMatchExhaustively { }
#[automatically_derived]
impl ::core::clone::Clone for RustcMustMatchExhaustively {
#[inline]
fn clone(&self) -> RustcMustMatchExhaustively { *self }
}
impl ::rustc_lint_defs::LintPass for RustcMustMatchExhaustively {
fn name(&self) -> &'static str { "RustcMustMatchExhaustively" }
fn get_lints(&self) -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[RUSTC_MUST_MATCH_EXHAUSTIVELY]))
}
}
impl RustcMustMatchExhaustively {
#[allow(unused)]
pub fn lint_vec() -> ::rustc_lint_defs::LintVec {
::alloc::boxed::box_assume_init_into_vec_unsafe(::alloc::intrinsics::write_box_via_move(::alloc::boxed::Box::new_uninit(),
[RUSTC_MUST_MATCH_EXHAUSTIVELY]))
}
}declare_lint_pass!(RustcMustMatchExhaustively => [RUSTC_MUST_MATCH_EXHAUSTIVELY]);
729
730fn is_rustc_must_match_exhaustively(cx: &LateContext<'_>, id: HirId) -> Option<Span> {
731 let res = cx.typeck_results();
732
733 let ty = res.node_type(id);
734
735 let ty = if let ty::Ref(_, ty, _) = ty.kind() { *ty } else { ty };
736
737 if let Some(adt_def) = ty.ty_adt_def()
738 && adt_def.is_enum()
739 {
740 {
{
'done:
{
for i in
::rustc_hir::attrs::HasAttrs::get_attrs(adt_def.did(),
&cx.tcx) {
#[allow(unused_imports)]
use rustc_hir::attrs::AttributeKind::*;
let i: &rustc_hir::Attribute = i;
match i {
rustc_hir::Attribute::Parsed(RustcMustMatchExhaustively(span))
=> {
break 'done Some(*span);
}
rustc_hir::Attribute::Unparsed(..) =>
{}
#[deny(unreachable_patterns)]
_ => {}
}
}
None
}
}
}find_attr!(cx.tcx, adt_def.did(), RustcMustMatchExhaustively(span) => *span)
741 } else {
742 None
743 }
744}
745
746fn pat_is_not_exhaustive_heuristic(pat: &hir::Pat<'_>) -> Option<(Span, &'static str)> {
747 match pat.kind {
748 hir::PatKind::Missing => None,
749 hir::PatKind::Wild => Some((pat.span, "because of this wildcard pattern")),
750 hir::PatKind::Binding(_, _, _, Some(pat)) => pat_is_not_exhaustive_heuristic(pat),
751 hir::PatKind::Binding(..) => Some((pat.span, "because of this variable binding")),
752 hir::PatKind::Struct(..) => None,
753 hir::PatKind::TupleStruct(..) => None,
754 hir::PatKind::Or(..) => None,
755 hir::PatKind::Never => None,
756 hir::PatKind::Tuple(..) => None,
757 hir::PatKind::Box(pat) => pat_is_not_exhaustive_heuristic(&*pat),
758 hir::PatKind::Deref(pat) => pat_is_not_exhaustive_heuristic(&*pat),
759 hir::PatKind::Ref(pat, _, _) => pat_is_not_exhaustive_heuristic(&*pat),
760 hir::PatKind::Expr(..) => None,
761 hir::PatKind::Guard(..) => None,
762 hir::PatKind::Range(..) => None,
763 hir::PatKind::Slice(..) => None,
764 hir::PatKind::Err(..) => None,
765 }
766}
767
768impl<'tcx> LateLintPass<'tcx> for RustcMustMatchExhaustively {
769 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &hir::Expr<'_>) {
770 match expr.kind {
771 hir::ExprKind::Match(expr, arms, _) => {
774 if let Some(attr_span) = is_rustc_must_match_exhaustively(cx, expr.hir_id) {
775 for arm in arms {
776 if let Some((span, message)) = pat_is_not_exhaustive_heuristic(arm.pat) {
777 cx.emit_span_lint(
778 RUSTC_MUST_MATCH_EXHAUSTIVELY,
779 expr.span,
780 RustcMustMatchExhaustivelyNotExhaustive {
781 attr_span,
782 pat_span: span,
783 message,
784 },
785 );
786 }
787 }
788 }
789 }
790 hir::ExprKind::Let(expr, ..) => {
791 if let Some(attr_span) = is_rustc_must_match_exhaustively(cx, expr.init.hir_id) {
792 cx.emit_span_lint(
793 RUSTC_MUST_MATCH_EXHAUSTIVELY,
794 expr.span,
795 RustcMustMatchExhaustivelyNotExhaustive {
796 attr_span,
797 pat_span: expr.span,
798 message: "using `if let` only matches on one variant (try using `match`)",
799 },
800 );
801 }
802 }
803 _ => {}
804 }
805 }
806
807 fn check_stmt(&mut self, cx: &LateContext<'tcx>, stmt: &'tcx rustc_hir::Stmt<'tcx>) {
808 match stmt.kind {
809 rustc_hir::StmtKind::Let(let_stmt) => {
810 if let_stmt.els.is_some()
811 && let Some(attr_span) =
812 is_rustc_must_match_exhaustively(cx, let_stmt.pat.hir_id)
813 {
814 cx.emit_span_lint(
815 RUSTC_MUST_MATCH_EXHAUSTIVELY,
816 let_stmt.span,
817 RustcMustMatchExhaustivelyNotExhaustive {
818 attr_span,
819 pat_span: let_stmt.pat.span,
820 message: "using `let else` only matches on one variant (try using `match`)",
821 },
822 );
823 }
824 }
825 _ => {}
826 }
827 }
828}