cargo/core/compiler/job_queue/
mod.rs

1//! Management of the interaction between the main `cargo` and all spawned jobs.
2//!
3//! ## Overview
4//!
5//! This module implements a job queue. A job here represents a unit of work,
6//! which is roughly a rustc invocation, a build script run, or just a no-op.
7//! The job queue primarily handles the following things:
8//!
9//! * Spawns concurrent jobs. Depending on its [`Freshness`], a job could be
10//!     either executed on a spawned thread or ran on the same thread to avoid
11//!     the threading overhead.
12//! * Controls the number of concurrency. It allocates and manages [`jobserver`]
13//!     tokens to each spawned off rustc and build scripts.
14//! * Manages the communication between the main `cargo` process and its
15//!     spawned jobs. Those [`Message`]s are sent over a [`Queue`] shared
16//!     across threads.
17//! * Schedules the execution order of each [`Job`]. Priorities are determined
18//!     when calling [`JobQueue::enqueue`] to enqueue a job. The scheduling is
19//!     relatively rudimentary and could likely be improved.
20//!
21//! A rough outline of building a queue and executing jobs is:
22//!
23//! 1. [`JobQueue::new`] to simply create one queue.
24//! 2. [`JobQueue::enqueue`] to add new jobs onto the queue.
25//! 3. Consumes the queue and executes all jobs via [`JobQueue::execute`].
26//!
27//! The primary loop happens insides [`JobQueue::execute`], which is effectively
28//! [`DrainState::drain_the_queue`]. [`DrainState`] is, as its name tells,
29//! the running state of the job queue getting drained.
30//!
31//! ## Jobserver
32//!
33//! As of Feb. 2023, Cargo and rustc have a relatively simple jobserver
34//! relationship with each other. They share a single jobserver amongst what
35//! is potentially hundreds of threads of work on many-cored systems.
36//! The jobserver could come from either the environment (e.g., from a `make`
37//! invocation), or from Cargo creating its own jobserver server if there is no
38//! jobserver to inherit from.
39//!
40//! Cargo wants to complete the build as quickly as possible, fully saturating
41//! all cores (as constrained by the `-j=N`) parameter. Cargo also must not spawn
42//! more than N threads of work: the total amount of tokens we have floating
43//! around must always be limited to N.
44//!
45//! It is not really possible to optimally choose which crate should build
46//! first or last; nor is it possible to decide whether to give an additional
47//! token to rustc first or rather spawn a new crate of work. The algorithm in
48//! Cargo prioritizes spawning as many crates (i.e., rustc processes) as
49//! possible. In short, the jobserver relationship among Cargo and rustc
50//! processes is **1 `cargo` to N `rustc`**. Cargo knows nothing beyond rustc
51//! processes in terms of parallelism[^parallel-rustc].
52//!
53//! We integrate with the [jobserver] crate, originating from GNU make
54//! [POSIX jobserver], to make sure that build scripts which use make to
55//! build C code can cooperate with us on the number of used tokens and
56//! avoid overfilling the system we're on.
57//!
58//! ## Scheduling
59//!
60//! The current scheduling algorithm is not really polished. It is simply based
61//! on a dependency graph [`DependencyQueue`]. We continue adding nodes onto
62//! the graph until we finalize it. When the graph gets finalized, it finds the
63//! sum of the cost of each dependencies of each node, including transitively.
64//! The sum of dependency cost turns out to be the cost of each given node.
65//!
66//! At the time being, the cost is just passed as a fixed placeholder in
67//! [`JobQueue::enqueue`]. In the future, we could explore more possibilities
68//! around it. For instance, we start persisting timing information for each
69//! build somewhere. For a subsequent build, we can look into the historical
70//! data and perform a PGO-like optimization to prioritize jobs, making a build
71//! fully pipelined.
72//!
73//! ## Message queue
74//!
75//! Each spawned thread running a process uses the message queue [`Queue`] to
76//! send messages back to the main thread (the one running `cargo`).
77//! The main thread coordinates everything, and handles printing output.
78//!
79//! It is important to be careful which messages use [`push`] vs [`push_bounded`].
80//! `push` is for priority messages (like tokens, or "finished") where the
81//! sender shouldn't block. We want to handle those so real work can proceed
82//! ASAP.
83//!
84//! `push_bounded` is only for messages being printed to stdout/stderr. Being
85//! bounded prevents a flood of messages causing a large amount of memory
86//! being used.
87//!
88//! `push` also avoids blocking which helps avoid deadlocks. For example, when
89//! the diagnostic server thread is dropped, it waits for the thread to exit.
90//! But if the thread is blocked on a full queue, and there is a critical
91//! error, the drop will deadlock. This should be fixed at some point in the
92//! future. The jobserver thread has a similar problem, though it will time
93//! out after 1 second.
94//!
95//! To access the message queue, each running `Job` is given its own [`JobState`],
96//! containing everything it needs to communicate with the main thread.
97//!
98//! See [`Message`] for all available message kinds.
99//!
100//! [^parallel-rustc]: In fact, `jobserver` that Cargo uses also manages the
101//!     allocation of tokens to rustc beyond the implicit token each rustc owns
102//!     (i.e., the ones used for parallel LLVM work and parallel rustc threads).
103//!     See also ["Rust Compiler Development Guide: Parallel Compilation"]
104//!     and [this comment][rustc-codegen] in rust-lang/rust.
105//!
106//! ["Rust Compiler Development Guide: Parallel Compilation"]: https://rustc-dev-guide.rust-lang.org/parallel-rustc.html
107//! [rustc-codegen]: https://github.com/rust-lang/rust/blob/5423745db8b434fcde54888b35f518f00cce00e4/compiler/rustc_codegen_ssa/src/back/write.rs#L1204-L1217
108//! [jobserver]: https://docs.rs/jobserver
109//! [POSIX jobserver]: https://www.gnu.org/software/make/manual/html_node/POSIX-Jobserver.html
110//! [`push`]: Queue::push
111//! [`push_bounded`]: Queue::push_bounded
112
113mod job;
114mod job_state;
115
116use std::cell::RefCell;
117use std::collections::{HashMap, HashSet};
118use std::fmt::Write as _;
119use std::io;
120use std::path::{Path, PathBuf};
121use std::sync::Arc;
122use std::thread::{self, Scope};
123use std::time::Duration;
124
125use anyhow::{Context as _, format_err};
126use jobserver::{Acquired, HelperThread};
127use semver::Version;
128use tracing::{debug, trace};
129
130pub use self::job::Freshness::{self, Dirty, Fresh};
131pub use self::job::{Job, Work};
132pub use self::job_state::JobState;
133use super::custom_build::Severity;
134use super::timings::{SectionTiming, Timings};
135use super::{BuildContext, BuildRunner, CompileMode, Unit};
136use crate::core::compiler::descriptive_pkg_name;
137use crate::core::compiler::future_incompat::{
138    self, FutureBreakageItem, FutureIncompatReportPackage,
139};
140use crate::core::resolver::ResolveBehavior;
141use crate::core::{PackageId, Shell, TargetKind};
142use crate::util::CargoResult;
143use crate::util::context::WarningHandling;
144use crate::util::diagnostic_server::{self, DiagnosticPrinter};
145use crate::util::errors::AlreadyPrintedError;
146use crate::util::machine_message::{self, Message as _};
147use crate::util::{self, internal};
148use crate::util::{DependencyQueue, GlobalContext, Progress, ProgressStyle, Queue};
149
150/// This structure is backed by the `DependencyQueue` type and manages the
151/// queueing of compilation steps for each package. Packages enqueue units of
152/// work and then later on the entire graph is converted to `DrainState` and
153/// executed.
154pub struct JobQueue<'gctx> {
155    queue: DependencyQueue<Unit, Artifact, Job>,
156    counts: HashMap<PackageId, usize>,
157    timings: Timings<'gctx>,
158}
159
160/// This structure is backed by the `DependencyQueue` type and manages the
161/// actual compilation step of each package. Packages enqueue units of work and
162/// then later on the entire graph is processed and compiled.
163///
164/// It is created from `JobQueue` when we have fully assembled the crate graph
165/// (i.e., all package dependencies are known).
166struct DrainState<'gctx> {
167    // This is the length of the DependencyQueue when starting out
168    total_units: usize,
169
170    queue: DependencyQueue<Unit, Artifact, Job>,
171    messages: Arc<Queue<Message>>,
172    /// Diagnostic deduplication support.
173    diag_dedupe: DiagDedupe<'gctx>,
174    /// Count of warnings, used to print a summary after the job succeeds
175    warning_count: HashMap<JobId, WarningCount>,
176    active: HashMap<JobId, Unit>,
177    compiled: HashSet<PackageId>,
178    documented: HashSet<PackageId>,
179    scraped: HashSet<PackageId>,
180    counts: HashMap<PackageId, usize>,
181    progress: Progress<'gctx>,
182    next_id: u32,
183    timings: Timings<'gctx>,
184
185    /// Tokens that are currently owned by this Cargo, and may be "associated"
186    /// with a rustc process. They may also be unused, though if so will be
187    /// dropped on the next loop iteration.
188    ///
189    /// Note that the length of this may be zero, but we will still spawn work,
190    /// as we share the implicit token given to this Cargo process with a
191    /// single rustc process.
192    tokens: Vec<Acquired>,
193
194    /// The list of jobs that we have not yet started executing, but have
195    /// retrieved from the `queue`. We eagerly pull jobs off the main queue to
196    /// allow us to request jobserver tokens pretty early.
197    pending_queue: Vec<(Unit, Job, usize)>,
198    print: DiagnosticPrinter<'gctx>,
199
200    /// How many jobs we've finished
201    finished: usize,
202    per_package_future_incompat_reports: Vec<FutureIncompatReportPackage>,
203}
204
205/// Count of warnings, used to print a summary after the job succeeds
206#[derive(Default)]
207pub struct WarningCount {
208    /// total number of warnings
209    pub total: usize,
210    /// number of lint warnings
211    pub lints: usize,
212    /// number of warnings that were suppressed because they
213    /// were duplicates of a previous warning
214    pub duplicates: usize,
215    /// number of fixable warnings set to `NotAllowed`
216    /// if any errors have been seen for the current
217    /// target
218    pub fixable: FixableWarnings,
219}
220
221impl WarningCount {
222    /// If an error is seen this should be called
223    /// to set `fixable` to `NotAllowed`
224    fn disallow_fixable(&mut self) {
225        self.fixable = FixableWarnings::NotAllowed;
226    }
227
228    /// Checks fixable if warnings are allowed
229    /// fixable warnings are allowed if no
230    /// errors have been seen for the current
231    /// target. If an error was seen `fixable`
232    /// will be `NotAllowed`.
233    fn fixable_allowed(&self) -> bool {
234        match &self.fixable {
235            FixableWarnings::NotAllowed => false,
236            _ => true,
237        }
238    }
239}
240
241/// Used to keep track of how many fixable warnings there are
242/// and if fixable warnings are allowed
243#[derive(Default)]
244pub enum FixableWarnings {
245    NotAllowed,
246    #[default]
247    Zero,
248    Positive(usize),
249}
250
251pub struct ErrorsDuringDrain {
252    pub count: usize,
253}
254
255struct ErrorToHandle {
256    error: anyhow::Error,
257
258    /// This field is true for "interesting" errors and false for "mundane"
259    /// errors. If false, we print the above error only if it's the first one
260    /// encountered so far while draining the job queue.
261    ///
262    /// At most places that an error is propagated, we set this to false to
263    /// avoid scenarios where Cargo might end up spewing tons of redundant error
264    /// messages. For example if an i/o stream got closed somewhere, we don't
265    /// care about individually reporting every thread that it broke; just the
266    /// first is enough.
267    ///
268    /// The exception where `print_always` is true is that we do report every
269    /// instance of a rustc invocation that failed with diagnostics. This
270    /// corresponds to errors from `Message::Finish`.
271    print_always: bool,
272}
273
274impl<E> From<E> for ErrorToHandle
275where
276    anyhow::Error: From<E>,
277{
278    fn from(error: E) -> Self {
279        ErrorToHandle {
280            error: anyhow::Error::from(error),
281            print_always: false,
282        }
283    }
284}
285
286#[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, PartialOrd, Ord)]
287pub struct JobId(pub u32);
288
289impl std::fmt::Display for JobId {
290    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
291        write!(f, "{}", self.0)
292    }
293}
294
295/// Handler for deduplicating diagnostics.
296struct DiagDedupe<'gctx> {
297    seen: RefCell<HashSet<u64>>,
298    gctx: &'gctx GlobalContext,
299}
300
301impl<'gctx> DiagDedupe<'gctx> {
302    fn new(gctx: &'gctx GlobalContext) -> Self {
303        DiagDedupe {
304            seen: RefCell::new(HashSet::new()),
305            gctx,
306        }
307    }
308
309    /// Emits a diagnostic message.
310    ///
311    /// Returns `true` if the message was emitted, or `false` if it was
312    /// suppressed for being a duplicate.
313    fn emit_diag(&self, diag: &str) -> CargoResult<bool> {
314        let h = util::hash_u64(diag);
315        if !self.seen.borrow_mut().insert(h) {
316            return Ok(false);
317        }
318        let mut shell = self.gctx.shell();
319        shell.print_ansi_stderr(diag.as_bytes())?;
320        shell.err().write_all(b"\n")?;
321        Ok(true)
322    }
323}
324
325/// Possible artifacts that can be produced by compilations, used as edge values
326/// in the dependency graph.
327///
328/// As edge values we can have multiple kinds of edges depending on one node,
329/// for example some units may only depend on the metadata for an rlib while
330/// others depend on the full rlib. This `Artifact` enum is used to distinguish
331/// this case and track the progress of compilations as they proceed.
332#[derive(Copy, Clone, Eq, PartialEq, Hash, Debug)]
333enum Artifact {
334    /// A generic placeholder for "depends on everything run by a step" and
335    /// means that we can't start the next compilation until the previous has
336    /// finished entirely.
337    All,
338
339    /// A node indicating that we only depend on the metadata of a compilation,
340    /// but the compilation is typically also producing an rlib. We can start
341    /// our step, however, before the full rlib is available.
342    Metadata,
343}
344
345enum Message {
346    Run(JobId, String),
347    Stdout(String),
348    Stderr(String),
349
350    // This is for general stderr output from subprocesses
351    Diagnostic {
352        id: JobId,
353        level: String,
354        diag: String,
355        lint: bool,
356        fixable: bool,
357    },
358    // This handles duplicate output that is suppressed, for showing
359    // only a count of duplicate messages instead
360    WarningCount {
361        id: JobId,
362        lint: bool,
363        emitted: bool,
364        fixable: bool,
365    },
366    // This is for warnings generated by Cargo's interpretation of the
367    // subprocess output, e.g. scrape-examples prints a warning if a
368    // unit fails to be scraped
369    Warning {
370        id: JobId,
371        warning: String,
372    },
373
374    FixDiagnostic(diagnostic_server::Message),
375    Token(io::Result<Acquired>),
376    Finish(JobId, Artifact, CargoResult<()>),
377    FutureIncompatReport(JobId, Vec<FutureBreakageItem>),
378    SectionTiming(JobId, SectionTiming),
379}
380
381impl<'gctx> JobQueue<'gctx> {
382    pub fn new(bcx: &BuildContext<'_, 'gctx>) -> JobQueue<'gctx> {
383        JobQueue {
384            queue: DependencyQueue::new(),
385            counts: HashMap::new(),
386            timings: Timings::new(bcx, &bcx.roots),
387        }
388    }
389
390    pub fn enqueue(
391        &mut self,
392        build_runner: &BuildRunner<'_, 'gctx>,
393        unit: &Unit,
394        job: Job,
395    ) -> CargoResult<()> {
396        let dependencies = build_runner.unit_deps(unit);
397        let mut queue_deps = dependencies
398            .iter()
399            .filter(|dep| {
400                // Binaries aren't actually needed to *compile* tests, just to run
401                // them, so we don't include this dependency edge in the job graph.
402                // But we shouldn't filter out dependencies being scraped for Rustdoc.
403                (!dep.unit.target.is_test() && !dep.unit.target.is_bin())
404                    || dep.unit.artifact.is_true()
405                    || dep.unit.mode.is_doc_scrape()
406            })
407            .map(|dep| {
408                // Handle the case here where our `unit -> dep` dependency may
409                // only require the metadata, not the full compilation to
410                // finish. Use the tables in `build_runner` to figure out what
411                // kind of artifact is associated with this dependency.
412                let artifact = if build_runner.only_requires_rmeta(unit, &dep.unit) {
413                    Artifact::Metadata
414                } else {
415                    Artifact::All
416                };
417                (dep.unit.clone(), artifact)
418            })
419            .collect::<HashMap<_, _>>();
420
421        // This is somewhat tricky, but we may need to synthesize some
422        // dependencies for this target if it requires full upstream
423        // compilations to have completed. Because of pipelining, some
424        // dependency edges may be `Metadata` due to the above clause (as
425        // opposed to everything being `All`). For example consider:
426        //
427        //    a (binary)
428        //    └ b (lib)
429        //        └ c (lib)
430        //
431        // Here the dependency edge from B to C will be `Metadata`, and the
432        // dependency edge from A to B will be `All`. For A to be compiled,
433        // however, it currently actually needs the full rlib of C. This means
434        // that we need to synthesize a dependency edge for the dependency graph
435        // from A to C. That's done here.
436        //
437        // This will walk all dependencies of the current target, and if any of
438        // *their* dependencies are `Metadata` then we depend on the `All` of
439        // the target as well. This should ensure that edges changed to
440        // `Metadata` propagate upwards `All` dependencies to anything that
441        // transitively contains the `Metadata` edge.
442        if unit.requires_upstream_objects() {
443            for dep in dependencies {
444                depend_on_deps_of_deps(build_runner, &mut queue_deps, dep.unit.clone());
445            }
446
447            fn depend_on_deps_of_deps(
448                build_runner: &BuildRunner<'_, '_>,
449                deps: &mut HashMap<Unit, Artifact>,
450                unit: Unit,
451            ) {
452                for dep in build_runner.unit_deps(&unit) {
453                    if deps.insert(dep.unit.clone(), Artifact::All).is_none() {
454                        depend_on_deps_of_deps(build_runner, deps, dep.unit.clone());
455                    }
456                }
457            }
458        }
459
460        // For now we use a fixed placeholder value for the cost of each unit, but
461        // in the future this could be used to allow users to provide hints about
462        // relative expected costs of units, or this could be automatically set in
463        // a smarter way using timing data from a previous compilation.
464        self.queue.queue(unit.clone(), job, queue_deps, 100);
465        *self.counts.entry(unit.pkg.package_id()).or_insert(0) += 1;
466        Ok(())
467    }
468
469    /// Executes all jobs necessary to build the dependency graph.
470    ///
471    /// This function will spawn off `config.jobs()` workers to build all of the
472    /// necessary dependencies, in order. Freshness is propagated as far as
473    /// possible along each dependency chain.
474    #[tracing::instrument(skip_all)]
475    pub fn execute(mut self, build_runner: &mut BuildRunner<'_, '_>) -> CargoResult<()> {
476        self.queue.queue_finished();
477
478        let progress =
479            Progress::with_style("Building", ProgressStyle::Ratio, build_runner.bcx.gctx);
480        let state = DrainState {
481            total_units: self.queue.len(),
482            queue: self.queue,
483            // 100 here is somewhat arbitrary. It is a few screenfulls of
484            // output, and hopefully at most a few megabytes of memory for
485            // typical messages. If you change this, please update the test
486            // caching_large_output, too.
487            messages: Arc::new(Queue::new(100)),
488            diag_dedupe: DiagDedupe::new(build_runner.bcx.gctx),
489            warning_count: HashMap::new(),
490            active: HashMap::new(),
491            compiled: HashSet::new(),
492            documented: HashSet::new(),
493            scraped: HashSet::new(),
494            counts: self.counts,
495            progress,
496            next_id: 0,
497            timings: self.timings,
498            tokens: Vec::new(),
499            pending_queue: Vec::new(),
500            print: DiagnosticPrinter::new(
501                build_runner.bcx.gctx,
502                &build_runner.bcx.rustc().workspace_wrapper,
503            ),
504            finished: 0,
505            per_package_future_incompat_reports: Vec::new(),
506        };
507
508        // Create a helper thread for acquiring jobserver tokens
509        let messages = state.messages.clone();
510        let helper = build_runner
511            .jobserver
512            .clone()
513            .into_helper_thread(move |token| {
514                messages.push(Message::Token(token));
515            })
516            .context("failed to create helper thread for jobserver management")?;
517
518        // Create a helper thread to manage the diagnostics for rustfix if
519        // necessary.
520        let messages = state.messages.clone();
521        // It is important that this uses `push` instead of `push_bounded` for
522        // now. If someone wants to fix this to be bounded, the `drop`
523        // implementation needs to be changed to avoid possible deadlocks.
524        let _diagnostic_server = build_runner
525            .bcx
526            .build_config
527            .rustfix_diagnostic_server
528            .borrow_mut()
529            .take()
530            .map(move |srv| srv.start(move |msg| messages.push(Message::FixDiagnostic(msg))));
531
532        thread::scope(
533            move |scope| match state.drain_the_queue(build_runner, scope, &helper) {
534                Some(err) => Err(err),
535                None => Ok(()),
536            },
537        )
538    }
539}
540
541impl<'gctx> DrainState<'gctx> {
542    fn spawn_work_if_possible<'s>(
543        &mut self,
544        build_runner: &mut BuildRunner<'_, '_>,
545        jobserver_helper: &HelperThread,
546        scope: &'s Scope<'s, '_>,
547    ) -> CargoResult<()> {
548        // Dequeue as much work as we can, learning about everything
549        // possible that can run. Note that this is also the point where we
550        // start requesting job tokens. Each job after the first needs to
551        // request a token.
552        while let Some((unit, job, priority)) = self.queue.dequeue() {
553            // We want to keep the pieces of work in the `pending_queue` sorted
554            // by their priorities, and insert the current job at its correctly
555            // sorted position: following the lower priority jobs, and the ones
556            // with the same priority (since they were dequeued before the
557            // current one, we also keep that relation).
558            let idx = self
559                .pending_queue
560                .partition_point(|&(_, _, p)| p <= priority);
561            self.pending_queue.insert(idx, (unit, job, priority));
562            if self.active.len() + self.pending_queue.len() > 1 {
563                jobserver_helper.request_token();
564            }
565        }
566
567        // Now that we've learned of all possible work that we can execute
568        // try to spawn it so long as we've got a jobserver token which says
569        // we're able to perform some parallel work.
570        // The `pending_queue` is sorted in ascending priority order, and we
571        // remove items from its end to schedule the highest priority items
572        // sooner.
573        while self.has_extra_tokens() && !self.pending_queue.is_empty() {
574            let (unit, job, _) = self.pending_queue.pop().unwrap();
575            *self.counts.get_mut(&unit.pkg.package_id()).unwrap() -= 1;
576            // Print out some nice progress information.
577            // NOTE: An error here will drop the job without starting it.
578            // That should be OK, since we want to exit as soon as
579            // possible during an error.
580            self.note_working_on(
581                build_runner.bcx.gctx,
582                build_runner.bcx.ws.root(),
583                &unit,
584                job.freshness(),
585            )?;
586            self.run(&unit, job, build_runner, scope);
587        }
588
589        Ok(())
590    }
591
592    fn has_extra_tokens(&self) -> bool {
593        self.active.len() < self.tokens.len() + 1
594    }
595
596    fn handle_event(
597        &mut self,
598        build_runner: &mut BuildRunner<'_, '_>,
599        event: Message,
600    ) -> Result<(), ErrorToHandle> {
601        let warning_handling = build_runner.bcx.gctx.warning_handling()?;
602        match event {
603            Message::Run(id, cmd) => {
604                build_runner
605                    .bcx
606                    .gctx
607                    .shell()
608                    .verbose(|c| c.status("Running", &cmd))?;
609                self.timings.unit_start(id, self.active[&id].clone());
610            }
611            Message::Stdout(out) => {
612                writeln!(build_runner.bcx.gctx.shell().out(), "{}", out)?;
613            }
614            Message::Stderr(err) => {
615                let mut shell = build_runner.bcx.gctx.shell();
616                shell.print_ansi_stderr(err.as_bytes())?;
617                shell.err().write_all(b"\n")?;
618            }
619            Message::Diagnostic {
620                id,
621                level,
622                diag,
623                lint,
624                fixable,
625            } => {
626                let emitted = self.diag_dedupe.emit_diag(&diag)?;
627                if level == "warning" {
628                    self.bump_warning_count(id, lint, emitted, fixable);
629                }
630                if level == "error" {
631                    let cnts = self.warning_count.entry(id).or_default();
632                    // If there is an error, the `cargo fix` message should not show
633                    cnts.disallow_fixable();
634                }
635            }
636            Message::Warning { id, warning } => {
637                if warning_handling != WarningHandling::Allow {
638                    build_runner.bcx.gctx.shell().warn(warning)?;
639                }
640                let lint = false;
641                let emitted = true;
642                let fixable = false;
643                self.bump_warning_count(id, lint, emitted, fixable);
644            }
645            Message::WarningCount {
646                id,
647                lint,
648                emitted,
649                fixable,
650            } => {
651                self.bump_warning_count(id, lint, emitted, fixable);
652            }
653            Message::FixDiagnostic(msg) => {
654                self.print.print(&msg)?;
655            }
656            Message::Finish(id, artifact, result) => {
657                let unit = match artifact {
658                    // If `id` has completely finished we remove it
659                    // from the `active` map ...
660                    Artifact::All => {
661                        trace!("end: {:?}", id);
662                        self.finished += 1;
663                        self.report_warning_count(
664                            build_runner,
665                            id,
666                            &build_runner.bcx.rustc().workspace_wrapper,
667                        );
668                        self.active.remove(&id).unwrap()
669                    }
670                    // ... otherwise if it hasn't finished we leave it
671                    // in there as we'll get another `Finish` later on.
672                    Artifact::Metadata => {
673                        trace!("end (meta): {:?}", id);
674                        self.active[&id].clone()
675                    }
676                };
677                debug!("end ({:?}): {:?}", unit, result);
678                match result {
679                    Ok(()) => self.finish(id, &unit, artifact, build_runner)?,
680                    Err(_) if build_runner.bcx.unit_can_fail_for_docscraping(&unit) => {
681                        build_runner
682                            .failed_scrape_units
683                            .lock()
684                            .unwrap()
685                            .insert(build_runner.files().metadata(&unit).unit_id());
686                        self.queue.finish(&unit, &artifact);
687                    }
688                    Err(error) => {
689                        let show_warnings = true;
690                        self.emit_log_messages(&unit, build_runner, show_warnings)?;
691                        self.back_compat_notice(build_runner, &unit)?;
692                        return Err(ErrorToHandle {
693                            error,
694                            print_always: true,
695                        });
696                    }
697                }
698            }
699            Message::FutureIncompatReport(id, items) => {
700                let unit = &self.active[&id];
701                let package_id = unit.pkg.package_id();
702                let is_local = unit.is_local();
703                self.per_package_future_incompat_reports
704                    .push(FutureIncompatReportPackage {
705                        package_id,
706                        is_local,
707                        items,
708                    });
709            }
710            Message::Token(acquired_token) => {
711                let token = acquired_token.context("failed to acquire jobserver token")?;
712                self.tokens.push(token);
713            }
714            Message::SectionTiming(id, section) => {
715                self.timings.unit_section_timing(id, &section);
716            }
717        }
718
719        Ok(())
720    }
721
722    // This will also tick the progress bar as appropriate
723    fn wait_for_events(&mut self) -> Vec<Message> {
724        // Drain all events at once to avoid displaying the progress bar
725        // unnecessarily. If there's no events we actually block waiting for
726        // an event, but we keep a "heartbeat" going to allow `record_cpu`
727        // to run above to calculate CPU usage over time. To do this we
728        // listen for a message with a timeout, and on timeout we run the
729        // previous parts of the loop again.
730        let mut events = self.messages.try_pop_all();
731        if events.is_empty() {
732            loop {
733                self.tick_progress();
734                self.tokens.truncate(self.active.len() - 1);
735                match self.messages.pop(Duration::from_millis(500)) {
736                    Some(message) => {
737                        events.push(message);
738                        break;
739                    }
740                    None => continue,
741                }
742            }
743        }
744        events
745    }
746
747    /// This is the "main" loop, where Cargo does all work to run the
748    /// compiler.
749    ///
750    /// This returns an Option to prevent the use of `?` on `Result` types
751    /// because it is important for the loop to carefully handle errors.
752    fn drain_the_queue<'s>(
753        mut self,
754        build_runner: &mut BuildRunner<'_, '_>,
755        scope: &'s Scope<'s, '_>,
756        jobserver_helper: &HelperThread,
757    ) -> Option<anyhow::Error> {
758        trace!("queue: {:#?}", self.queue);
759
760        // Iteratively execute the entire dependency graph. Each turn of the
761        // loop starts out by scheduling as much work as possible (up to the
762        // maximum number of parallel jobs we have tokens for). A local queue
763        // is maintained separately from the main dependency queue as one
764        // dequeue may actually dequeue quite a bit of work (e.g., 10 binaries
765        // in one package).
766        //
767        // After a job has finished we update our internal state if it was
768        // successful and otherwise wait for pending work to finish if it failed
769        // and then immediately return (or keep going, if requested by the build
770        // config).
771        let mut errors = ErrorsDuringDrain { count: 0 };
772        // CAUTION! Do not use `?` or break out of the loop early. Every error
773        // must be handled in such a way that the loop is still allowed to
774        // drain event messages.
775        loop {
776            if errors.count == 0 || build_runner.bcx.build_config.keep_going {
777                if let Err(e) = self.spawn_work_if_possible(build_runner, jobserver_helper, scope) {
778                    self.handle_error(&mut build_runner.bcx.gctx.shell(), &mut errors, e);
779                }
780            }
781
782            // If after all that we're not actually running anything then we're
783            // done!
784            if self.active.is_empty() {
785                break;
786            }
787
788            // And finally, before we block waiting for the next event, drop any
789            // excess tokens we may have accidentally acquired. Due to how our
790            // jobserver interface is architected we may acquire a token that we
791            // don't actually use, and if this happens just relinquish it back
792            // to the jobserver itself.
793            for event in self.wait_for_events() {
794                if let Err(event_err) = self.handle_event(build_runner, event) {
795                    self.handle_error(&mut build_runner.bcx.gctx.shell(), &mut errors, event_err);
796                }
797            }
798        }
799        self.progress.clear();
800
801        let profile_name = build_runner.bcx.build_config.requested_profile;
802        // NOTE: this may be a bit inaccurate, since this may not display the
803        // profile for what was actually built. Profile overrides can change
804        // these settings, and in some cases different targets are built with
805        // different profiles. To be accurate, it would need to collect a
806        // list of Units built, and maybe display a list of the different
807        // profiles used. However, to keep it simple and compatible with old
808        // behavior, we just display what the base profile is.
809        let profile = build_runner.bcx.profiles.base_profile();
810        let mut opt_type = String::from(if profile.opt_level.as_str() == "0" {
811            "unoptimized"
812        } else {
813            "optimized"
814        });
815        if profile.debuginfo.is_turned_on() {
816            opt_type += " + debuginfo";
817        }
818
819        let time_elapsed = util::elapsed(build_runner.bcx.gctx.creation_time().elapsed());
820        if let Err(e) = self.timings.finished(build_runner, &errors.to_error()) {
821            self.handle_error(&mut build_runner.bcx.gctx.shell(), &mut errors, e);
822        }
823        if build_runner.bcx.build_config.emit_json() {
824            let mut shell = build_runner.bcx.gctx.shell();
825            let msg = machine_message::BuildFinished {
826                success: errors.count == 0,
827            }
828            .to_json_string();
829            if let Err(e) = writeln!(shell.out(), "{}", msg) {
830                self.handle_error(&mut shell, &mut errors, e);
831            }
832        }
833
834        if let Some(error) = errors.to_error() {
835            // Any errors up to this point have already been printed via the
836            // `display_error` inside `handle_error`.
837            Some(anyhow::Error::new(AlreadyPrintedError::new(error)))
838        } else if self.queue.is_empty() && self.pending_queue.is_empty() {
839            let profile_link = build_runner.bcx.gctx.shell().err_hyperlink(
840                "https://doc.rust-lang.org/cargo/reference/profiles.html#default-profiles",
841            );
842            let message = format!(
843                "{profile_link}`{profile_name}` profile [{opt_type}]{profile_link:#} target(s) in {time_elapsed}",
844            );
845            // It doesn't really matter if this fails.
846            let _ = build_runner.bcx.gctx.shell().status("Finished", message);
847            future_incompat::save_and_display_report(
848                build_runner.bcx,
849                &self.per_package_future_incompat_reports,
850            );
851
852            None
853        } else {
854            debug!("queue: {:#?}", self.queue);
855            Some(internal("finished with jobs still left in the queue"))
856        }
857    }
858
859    fn handle_error(
860        &mut self,
861        shell: &mut Shell,
862        err_state: &mut ErrorsDuringDrain,
863        new_err: impl Into<ErrorToHandle>,
864    ) {
865        let new_err = new_err.into();
866        if new_err.print_always || err_state.count == 0 {
867            crate::display_error(&new_err.error, shell);
868            if err_state.count == 0 && !self.active.is_empty() {
869                self.progress.indicate_error();
870                let _ = shell.warn("build failed, waiting for other jobs to finish...");
871            }
872            err_state.count += 1;
873        } else {
874            tracing::warn!("{:?}", new_err.error);
875        }
876    }
877
878    // This also records CPU usage and marks concurrency; we roughly want to do
879    // this as often as we spin on the events receiver (at least every 500ms or
880    // so).
881    fn tick_progress(&mut self) {
882        // Record some timing information if `--timings` is enabled, and
883        // this'll end up being a noop if we're not recording this
884        // information.
885        self.timings.mark_concurrency(
886            self.active.len(),
887            self.pending_queue.len(),
888            self.queue.len(),
889        );
890        self.timings.record_cpu();
891
892        let active_names = self
893            .active
894            .values()
895            .map(|u| self.name_for_progress(u))
896            .collect::<Vec<_>>();
897        let _ = self.progress.tick_now(
898            self.finished,
899            self.total_units,
900            &format!(": {}", active_names.join(", ")),
901        );
902    }
903
904    fn name_for_progress(&self, unit: &Unit) -> String {
905        let pkg_name = unit.pkg.name();
906        let target_name = unit.target.name();
907        match unit.mode {
908            CompileMode::Doc { .. } => format!("{}(doc)", pkg_name),
909            CompileMode::RunCustomBuild => format!("{}(build)", pkg_name),
910            CompileMode::Test | CompileMode::Check { test: true } => match unit.target.kind() {
911                TargetKind::Lib(_) => format!("{}(test)", target_name),
912                TargetKind::CustomBuild => panic!("cannot test build script"),
913                TargetKind::Bin => format!("{}(bin test)", target_name),
914                TargetKind::Test => format!("{}(test)", target_name),
915                TargetKind::Bench => format!("{}(bench)", target_name),
916                TargetKind::ExampleBin | TargetKind::ExampleLib(_) => {
917                    format!("{}(example test)", target_name)
918                }
919            },
920            _ => match unit.target.kind() {
921                TargetKind::Lib(_) => pkg_name.to_string(),
922                TargetKind::CustomBuild => format!("{}(build.rs)", pkg_name),
923                TargetKind::Bin => format!("{}(bin)", target_name),
924                TargetKind::Test => format!("{}(test)", target_name),
925                TargetKind::Bench => format!("{}(bench)", target_name),
926                TargetKind::ExampleBin | TargetKind::ExampleLib(_) => {
927                    format!("{}(example)", target_name)
928                }
929            },
930        }
931    }
932
933    /// Executes a job.
934    ///
935    /// Fresh jobs block until finished (which should be very fast!), Dirty
936    /// jobs will spawn a thread in the background and return immediately.
937    fn run<'s>(
938        &mut self,
939        unit: &Unit,
940        job: Job,
941        build_runner: &BuildRunner<'_, '_>,
942        scope: &'s Scope<'s, '_>,
943    ) {
944        let id = JobId(self.next_id);
945        self.next_id = self.next_id.checked_add(1).unwrap();
946
947        debug!("start {}: {:?}", id, unit);
948
949        assert!(self.active.insert(id, unit.clone()).is_none());
950
951        let messages = self.messages.clone();
952        let is_fresh = job.freshness().is_fresh();
953        let rmeta_required = build_runner.rmeta_required(unit);
954
955        let doit = move |diag_dedupe| {
956            let state = JobState::new(id, messages, diag_dedupe, rmeta_required);
957            state.run_to_finish(job);
958        };
959
960        match is_fresh {
961            true => {
962                self.timings.add_fresh();
963                // Running a fresh job on the same thread is often much faster than spawning a new
964                // thread to run the job.
965                doit(Some(&self.diag_dedupe));
966            }
967            false => {
968                self.timings.add_dirty();
969                scope.spawn(move || doit(None));
970            }
971        }
972    }
973
974    fn emit_log_messages(
975        &self,
976        unit: &Unit,
977        build_runner: &mut BuildRunner<'_, '_>,
978        show_warnings: bool,
979    ) -> CargoResult<()> {
980        let outputs = build_runner.build_script_outputs.lock().unwrap();
981        let Some(metadata_vec) = build_runner.find_build_script_metadatas(unit) else {
982            return Ok(());
983        };
984        let bcx = &mut build_runner.bcx;
985        for metadata in metadata_vec {
986            if let Some(output) = outputs.get(metadata) {
987                if !output.log_messages.is_empty()
988                    && (show_warnings
989                        || output
990                            .log_messages
991                            .iter()
992                            .any(|(severity, _)| *severity == Severity::Error))
993                {
994                    let msg_with_package =
995                        |msg: &str| format!("{}@{}: {}", unit.pkg.name(), unit.pkg.version(), msg);
996
997                    for (severity, message) in output.log_messages.iter() {
998                        match severity {
999                            Severity::Error => {
1000                                bcx.gctx.shell().error(msg_with_package(message))?;
1001                            }
1002                            Severity::Warning => {
1003                                bcx.gctx.shell().warn(msg_with_package(message))?;
1004                            }
1005                        }
1006                    }
1007                }
1008            }
1009        }
1010
1011        Ok(())
1012    }
1013
1014    fn bump_warning_count(&mut self, id: JobId, lint: bool, emitted: bool, fixable: bool) {
1015        let cnts = self.warning_count.entry(id).or_default();
1016        cnts.total += 1;
1017        if lint {
1018            cnts.lints += 1;
1019        }
1020        if !emitted {
1021            cnts.duplicates += 1;
1022        // Don't add to fixable if it's already been emitted
1023        } else if fixable {
1024            // Do not add anything to the fixable warning count if
1025            // is `NotAllowed` since that indicates there was an
1026            // error while building this `Unit`
1027            if cnts.fixable_allowed() {
1028                cnts.fixable = match cnts.fixable {
1029                    FixableWarnings::NotAllowed => FixableWarnings::NotAllowed,
1030                    FixableWarnings::Zero => FixableWarnings::Positive(1),
1031                    FixableWarnings::Positive(fixable) => FixableWarnings::Positive(fixable + 1),
1032                };
1033            }
1034        }
1035    }
1036
1037    /// Displays a final report of the warnings emitted by a particular job.
1038    fn report_warning_count(
1039        &mut self,
1040        runner: &mut BuildRunner<'_, '_>,
1041        id: JobId,
1042        rustc_workspace_wrapper: &Option<PathBuf>,
1043    ) {
1044        let gctx = runner.bcx.gctx;
1045        let count = match self.warning_count.get(&id) {
1046            // An error could add an entry for a `Unit`
1047            // with 0 warnings but having fixable
1048            // warnings be disallowed
1049            Some(count) if count.total > 0 => count,
1050            None | Some(_) => return,
1051        };
1052        runner.compilation.lint_warning_count += count.lints;
1053        let unit = &self.active[&id];
1054        let mut message = descriptive_pkg_name(&unit.pkg.name(), &unit.target, &unit.mode);
1055        message.push_str(" generated ");
1056        match count.total {
1057            1 => message.push_str("1 warning"),
1058            n => {
1059                let _ = write!(message, "{} warnings", n);
1060            }
1061        };
1062        match count.duplicates {
1063            0 => {}
1064            1 => message.push_str(" (1 duplicate)"),
1065            n => {
1066                let _ = write!(message, " ({} duplicates)", n);
1067            }
1068        }
1069        // Only show the `cargo fix` message if its a local `Unit`
1070        if unit.is_local() {
1071            // Do not show this if there are any errors or no fixable warnings
1072            if let FixableWarnings::Positive(fixable) = count.fixable {
1073                // `cargo fix` doesn't have an option for custom builds
1074                if !unit.target.is_custom_build() {
1075                    // To make sure the correct command is shown for `clippy` we
1076                    // check if `RUSTC_WORKSPACE_WRAPPER` is set and pointing towards
1077                    // `clippy-driver`.
1078                    let clippy = std::ffi::OsStr::new("clippy-driver");
1079                    let command = match rustc_workspace_wrapper.as_ref().and_then(|x| x.file_stem())
1080                    {
1081                        Some(wrapper) if wrapper == clippy => "cargo clippy --fix",
1082                        _ => "cargo fix",
1083                    };
1084                    let mut args =
1085                        format!("{} -p {}", unit.target.description_named(), unit.pkg.name());
1086                    if unit.mode.is_rustc_test()
1087                        && !(unit.target.is_test() || unit.target.is_bench())
1088                    {
1089                        args.push_str(" --tests");
1090                    }
1091                    let mut suggestions = format!("{} suggestion", fixable);
1092                    if fixable > 1 {
1093                        suggestions.push_str("s")
1094                    }
1095                    let _ = write!(
1096                        message,
1097                        " (run `{command} --{args}` to apply {suggestions})"
1098                    );
1099                }
1100            }
1101        }
1102        // Errors are ignored here because it is tricky to handle them
1103        // correctly, and they aren't important.
1104        let _ = gctx.shell().warn(message);
1105    }
1106
1107    fn finish(
1108        &mut self,
1109        id: JobId,
1110        unit: &Unit,
1111        artifact: Artifact,
1112        build_runner: &mut BuildRunner<'_, '_>,
1113    ) -> CargoResult<()> {
1114        if unit.mode.is_run_custom_build() {
1115            self.emit_log_messages(
1116                unit,
1117                build_runner,
1118                unit.show_warnings(build_runner.bcx.gctx),
1119            )?;
1120        }
1121        let unlocked = self.queue.finish(unit, &artifact);
1122        match artifact {
1123            Artifact::All => self.timings.unit_finished(build_runner, id, unlocked),
1124            Artifact::Metadata => self.timings.unit_rmeta_finished(id, unlocked),
1125        }
1126        Ok(())
1127    }
1128
1129    // This isn't super trivial because we don't want to print loads and
1130    // loads of information to the console, but we also want to produce a
1131    // faithful representation of what's happening. This is somewhat nuanced
1132    // as a package can start compiling *very* early on because of custom
1133    // build commands and such.
1134    //
1135    // In general, we try to print "Compiling" for the first nontrivial task
1136    // run for a package, regardless of when that is. We then don't print
1137    // out any more information for a package after we've printed it once.
1138    fn note_working_on(
1139        &mut self,
1140        gctx: &GlobalContext,
1141        ws_root: &Path,
1142        unit: &Unit,
1143        fresh: &Freshness,
1144    ) -> CargoResult<()> {
1145        if (self.compiled.contains(&unit.pkg.package_id())
1146            && !unit.mode.is_doc()
1147            && !unit.mode.is_doc_scrape())
1148            || (self.documented.contains(&unit.pkg.package_id()) && unit.mode.is_doc())
1149            || (self.scraped.contains(&unit.pkg.package_id()) && unit.mode.is_doc_scrape())
1150        {
1151            return Ok(());
1152        }
1153
1154        match fresh {
1155            // Any dirty stage which runs at least one command gets printed as
1156            // being a compiled package.
1157            Dirty(dirty_reason) => {
1158                if !dirty_reason.is_fresh_build() {
1159                    gctx.shell()
1160                        .verbose(|shell| dirty_reason.present_to(shell, unit, ws_root))?;
1161                }
1162
1163                if unit.mode.is_doc() {
1164                    self.documented.insert(unit.pkg.package_id());
1165                    gctx.shell().status("Documenting", &unit.pkg)?;
1166                } else if unit.mode.is_doc_test() {
1167                    // Skip doc test.
1168                } else if unit.mode.is_doc_scrape() {
1169                    self.scraped.insert(unit.pkg.package_id());
1170                    gctx.shell().status("Scraping", &unit.pkg)?;
1171                } else {
1172                    self.compiled.insert(unit.pkg.package_id());
1173                    if unit.mode.is_check() {
1174                        gctx.shell().status("Checking", &unit.pkg)?;
1175                    } else {
1176                        gctx.shell().status("Compiling", &unit.pkg)?;
1177                    }
1178                }
1179            }
1180            Fresh => {
1181                // If doc test are last, only print "Fresh" if nothing has been printed.
1182                if self.counts[&unit.pkg.package_id()] == 0
1183                    && !(unit.mode.is_doc_test() && self.compiled.contains(&unit.pkg.package_id()))
1184                {
1185                    self.compiled.insert(unit.pkg.package_id());
1186                    gctx.shell().verbose(|c| c.status("Fresh", &unit.pkg))?;
1187                }
1188            }
1189        }
1190        Ok(())
1191    }
1192
1193    fn back_compat_notice(
1194        &self,
1195        build_runner: &BuildRunner<'_, '_>,
1196        unit: &Unit,
1197    ) -> CargoResult<()> {
1198        if unit.pkg.name() != "diesel"
1199            || unit.pkg.version() >= &Version::new(1, 4, 8)
1200            || build_runner.bcx.ws.resolve_behavior() == ResolveBehavior::V1
1201            || !unit.pkg.package_id().source_id().is_registry()
1202            || !unit.features.is_empty()
1203        {
1204            return Ok(());
1205        }
1206        if !build_runner
1207            .bcx
1208            .unit_graph
1209            .keys()
1210            .any(|unit| unit.pkg.name() == "diesel" && !unit.features.is_empty())
1211        {
1212            return Ok(());
1213        }
1214        build_runner.bcx.gctx.shell().note(
1215            "\
1216This error may be due to an interaction between diesel and Cargo's new
1217feature resolver. Try updating to diesel 1.4.8 to fix this error.
1218",
1219        )?;
1220        Ok(())
1221    }
1222}
1223
1224impl ErrorsDuringDrain {
1225    fn to_error(&self) -> Option<anyhow::Error> {
1226        match self.count {
1227            0 => None,
1228            1 => Some(format_err!("1 job failed")),
1229            n => Some(format_err!("{} jobs failed", n)),
1230        }
1231    }
1232}