1use core::ops::ControlFlow;
7use std::borrow::Cow;
8use std::path::PathBuf;
9
10use hir::Expr;
11use rustc_ast::ast::Mutability;
12use rustc_data_structures::fx::{FxIndexMap, FxIndexSet};
13use rustc_data_structures::sorted_map::SortedMap;
14use rustc_data_structures::unord::UnordSet;
15use rustc_errors::codes::*;
16use rustc_errors::{Applicability, Diag, MultiSpan, StashKey, pluralize, struct_span_code_err};
17use rustc_hir::attrs::AttributeKind;
18use rustc_hir::def::{CtorKind, DefKind, Res};
19use rustc_hir::def_id::DefId;
20use rustc_hir::intravisit::{self, Visitor};
21use rustc_hir::lang_items::LangItem;
22use rustc_hir::{self as hir, ExprKind, HirId, Node, PathSegment, QPath, find_attr};
23use rustc_infer::infer::{BoundRegionConversionTime, RegionVariableOrigin};
24use rustc_middle::bug;
25use rustc_middle::ty::fast_reject::{DeepRejectCtxt, TreatParams, simplify_type};
26use rustc_middle::ty::print::{
27 PrintTraitRefExt as _, with_crate_prefix, with_forced_trimmed_paths,
28 with_no_visible_paths_if_doc_hidden,
29};
30use rustc_middle::ty::{self, GenericArgKind, IsSuggestable, Ty, TyCtxt, TypeVisitableExt};
31use rustc_span::def_id::DefIdSet;
32use rustc_span::{
33 DUMMY_SP, ErrorGuaranteed, ExpnKind, FileName, Ident, MacroKind, Span, Symbol, edit_distance,
34 kw, sym,
35};
36use rustc_trait_selection::error_reporting::traits::DefIdOrName;
37use rustc_trait_selection::error_reporting::traits::on_unimplemented::OnUnimplementedNote;
38use rustc_trait_selection::infer::InferCtxtExt;
39use rustc_trait_selection::traits::query::evaluate_obligation::InferCtxtExt as _;
40use rustc_trait_selection::traits::{
41 FulfillmentError, Obligation, ObligationCause, ObligationCauseCode, supertraits,
42};
43use tracing::{debug, info, instrument};
44
45use super::probe::{AutorefOrPtrAdjustment, IsSuggestion, Mode, ProbeScope};
46use super::{CandidateSource, MethodError, NoMatchData};
47use crate::errors::{self, CandidateTraitNote, NoAssociatedItem};
48use crate::{Expectation, FnCtxt};
49
50impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
51 fn is_slice_ty(&self, ty: Ty<'tcx>, span: Span) -> bool {
52 self.autoderef(span, ty)
53 .silence_errors()
54 .any(|(ty, _)| matches!(ty.kind(), ty::Slice(..) | ty::Array(..)))
55 }
56
57 fn impl_into_iterator_should_be_iterator(
58 &self,
59 ty: Ty<'tcx>,
60 span: Span,
61 unsatisfied_predicates: &Vec<(
62 ty::Predicate<'tcx>,
63 Option<ty::Predicate<'tcx>>,
64 Option<ObligationCause<'tcx>>,
65 )>,
66 ) -> bool {
67 fn predicate_bounds_generic_param<'tcx>(
68 predicate: ty::Predicate<'_>,
69 generics: &'tcx ty::Generics,
70 generic_param: &ty::GenericParamDef,
71 tcx: TyCtxt<'tcx>,
72 ) -> bool {
73 if let ty::PredicateKind::Clause(ty::ClauseKind::Trait(trait_pred)) =
74 predicate.kind().as_ref().skip_binder()
75 {
76 let ty::TraitPredicate { trait_ref: ty::TraitRef { args, .. }, .. } = trait_pred;
77 if args.is_empty() {
78 return false;
79 }
80 let Some(arg_ty) = args[0].as_type() else {
81 return false;
82 };
83 let ty::Param(param) = *arg_ty.kind() else {
84 return false;
85 };
86 generic_param.index == generics.type_param(param, tcx).index
88 } else {
89 false
90 }
91 }
92
93 let is_iterator_predicate = |predicate: ty::Predicate<'tcx>| -> bool {
94 if let ty::PredicateKind::Clause(ty::ClauseKind::Trait(trait_pred)) =
95 predicate.kind().as_ref().skip_binder()
96 {
97 self.tcx.is_diagnostic_item(sym::Iterator, trait_pred.trait_ref.def_id)
98 && trait_pred.trait_ref.self_ty() == ty
100 } else {
101 false
102 }
103 };
104
105 let Some(into_iterator_trait) = self.tcx.get_diagnostic_item(sym::IntoIterator) else {
107 return false;
108 };
109 let trait_ref = ty::TraitRef::new(self.tcx, into_iterator_trait, [ty]);
110 let obligation = Obligation::new(self.tcx, self.misc(span), self.param_env, trait_ref);
111 if !self.predicate_must_hold_modulo_regions(&obligation) {
112 return false;
113 }
114
115 match *ty.peel_refs().kind() {
116 ty::Param(param) => {
117 let generics = self.tcx.generics_of(self.body_id);
118 let generic_param = generics.type_param(param, self.tcx);
119 for unsatisfied in unsatisfied_predicates.iter() {
120 if predicate_bounds_generic_param(
123 unsatisfied.0,
124 generics,
125 generic_param,
126 self.tcx,
127 ) && is_iterator_predicate(unsatisfied.0)
128 {
129 return true;
130 }
131 }
132 }
133 ty::Slice(..) | ty::Adt(..) | ty::Alias(ty::Opaque, _) => {
134 for unsatisfied in unsatisfied_predicates.iter() {
135 if is_iterator_predicate(unsatisfied.0) {
136 return true;
137 }
138 }
139 }
140 _ => return false,
141 }
142 false
143 }
144
145 #[instrument(level = "debug", skip(self))]
146 pub(crate) fn report_method_error(
147 &self,
148 call_id: HirId,
149 rcvr_ty: Ty<'tcx>,
150 error: MethodError<'tcx>,
151 expected: Expectation<'tcx>,
152 trait_missing_method: bool,
153 ) -> ErrorGuaranteed {
154 for &import_id in
157 self.tcx.in_scope_traits(call_id).into_iter().flatten().flat_map(|c| &c.import_ids)
158 {
159 self.typeck_results.borrow_mut().used_trait_imports.insert(import_id);
160 }
161
162 let (span, expr_span, source, item_name, args) = match self.tcx.hir_node(call_id) {
163 hir::Node::Expr(&hir::Expr {
164 kind: hir::ExprKind::MethodCall(segment, rcvr, args, _),
165 span,
166 ..
167 }) => {
168 (segment.ident.span, span, SelfSource::MethodCall(rcvr), segment.ident, Some(args))
169 }
170 hir::Node::Expr(&hir::Expr {
171 kind: hir::ExprKind::Path(QPath::TypeRelative(rcvr, segment)),
172 span,
173 ..
174 })
175 | hir::Node::PatExpr(&hir::PatExpr {
176 kind: hir::PatExprKind::Path(QPath::TypeRelative(rcvr, segment)),
177 span,
178 ..
179 })
180 | hir::Node::Pat(&hir::Pat {
181 kind:
182 hir::PatKind::Struct(QPath::TypeRelative(rcvr, segment), ..)
183 | hir::PatKind::TupleStruct(QPath::TypeRelative(rcvr, segment), ..),
184 span,
185 ..
186 }) => {
187 let args = match self.tcx.parent_hir_node(call_id) {
188 hir::Node::Expr(&hir::Expr {
189 kind: hir::ExprKind::Call(callee, args), ..
190 }) if callee.hir_id == call_id => Some(args),
191 _ => None,
192 };
193 (segment.ident.span, span, SelfSource::QPath(rcvr), segment.ident, args)
194 }
195 node => unreachable!("{node:?}"),
196 };
197
198 let within_macro_span = span.within_macro(expr_span, self.tcx.sess.source_map());
201
202 if let Err(guar) = rcvr_ty.error_reported() {
204 return guar;
205 }
206
207 match error {
208 MethodError::NoMatch(mut no_match_data) => self.report_no_match_method_error(
209 span,
210 rcvr_ty,
211 item_name,
212 call_id,
213 source,
214 args,
215 expr_span,
216 &mut no_match_data,
217 expected,
218 trait_missing_method,
219 within_macro_span,
220 ),
221
222 MethodError::Ambiguity(mut sources) => {
223 let mut err = struct_span_code_err!(
224 self.dcx(),
225 item_name.span,
226 E0034,
227 "multiple applicable items in scope"
228 );
229 err.span_label(item_name.span, format!("multiple `{item_name}` found"));
230 if let Some(within_macro_span) = within_macro_span {
231 err.span_label(within_macro_span, "due to this macro variable");
232 }
233
234 self.note_candidates_on_method_error(
235 rcvr_ty,
236 item_name,
237 source,
238 args,
239 span,
240 &mut err,
241 &mut sources,
242 Some(expr_span),
243 );
244 err.emit()
245 }
246
247 MethodError::PrivateMatch(kind, def_id, out_of_scope_traits) => {
248 let kind = self.tcx.def_kind_descr(kind, def_id);
249 let mut err = struct_span_code_err!(
250 self.dcx(),
251 item_name.span,
252 E0624,
253 "{} `{}` is private",
254 kind,
255 item_name
256 );
257 err.span_label(item_name.span, format!("private {kind}"));
258 let sp =
259 self.tcx.hir_span_if_local(def_id).unwrap_or_else(|| self.tcx.def_span(def_id));
260 err.span_label(sp, format!("private {kind} defined here"));
261 if let Some(within_macro_span) = within_macro_span {
262 err.span_label(within_macro_span, "due to this macro variable");
263 }
264 self.suggest_valid_traits(&mut err, item_name, out_of_scope_traits, true);
265 self.suggest_unwrapping_inner_self(&mut err, source, rcvr_ty, item_name);
266 err.emit()
267 }
268
269 MethodError::IllegalSizedBound { candidates, needs_mut, bound_span, self_expr } => {
270 let msg = if needs_mut {
271 with_forced_trimmed_paths!(format!(
272 "the `{item_name}` method cannot be invoked on `{rcvr_ty}`"
273 ))
274 } else {
275 format!("the `{item_name}` method cannot be invoked on a trait object")
276 };
277 let mut err = self.dcx().struct_span_err(span, msg);
278 if !needs_mut {
279 err.span_label(bound_span, "this has a `Sized` requirement");
280 }
281 if let Some(within_macro_span) = within_macro_span {
282 err.span_label(within_macro_span, "due to this macro variable");
283 }
284 if !candidates.is_empty() {
285 let help = format!(
286 "{an}other candidate{s} {were} found in the following trait{s}",
287 an = if candidates.len() == 1 { "an" } else { "" },
288 s = pluralize!(candidates.len()),
289 were = pluralize!("was", candidates.len()),
290 );
291 self.suggest_use_candidates(
292 candidates,
293 |accessible_sugg, inaccessible_sugg, span| {
294 let suggest_for_access =
295 |err: &mut Diag<'_>, mut msg: String, sugg: Vec<_>| {
296 msg += &format!(
297 ", perhaps add a `use` for {one_of_them}:",
298 one_of_them =
299 if sugg.len() == 1 { "it" } else { "one_of_them" },
300 );
301 err.span_suggestions(
302 span,
303 msg,
304 sugg,
305 Applicability::MaybeIncorrect,
306 );
307 };
308 let suggest_for_privacy =
309 |err: &mut Diag<'_>, mut msg: String, suggs: Vec<String>| {
310 if let [sugg] = suggs.as_slice() {
311 err.help(format!("\
312 trait `{}` provides `{item_name}` is implemented but not reachable",
313 sugg.trim(),
314 ));
315 } else {
316 msg += &format!(" but {} not reachable", pluralize!("is", suggs.len()));
317 err.span_suggestions(
318 span,
319 msg,
320 suggs,
321 Applicability::MaybeIncorrect,
322 );
323 }
324 };
325 if accessible_sugg.is_empty() {
326 suggest_for_privacy(&mut err, help, inaccessible_sugg);
328 } else if inaccessible_sugg.is_empty() {
329 suggest_for_access(&mut err, help, accessible_sugg);
330 } else {
331 suggest_for_access(&mut err, help.clone(), accessible_sugg);
332 suggest_for_privacy(&mut err, help, inaccessible_sugg);
333 }
334 },
335 );
336 }
337 if let ty::Ref(region, t_type, mutability) = rcvr_ty.kind() {
338 if needs_mut {
339 let trait_type =
340 Ty::new_ref(self.tcx, *region, *t_type, mutability.invert());
341 let msg = format!("you need `{trait_type}` instead of `{rcvr_ty}`");
342 let mut kind = &self_expr.kind;
343 while let hir::ExprKind::AddrOf(_, _, expr)
344 | hir::ExprKind::Unary(hir::UnOp::Deref, expr) = kind
345 {
346 kind = &expr.kind;
347 }
348 if let hir::ExprKind::Path(hir::QPath::Resolved(None, path)) = kind
349 && let hir::def::Res::Local(hir_id) = path.res
350 && let hir::Node::Pat(b) = self.tcx.hir_node(hir_id)
351 && let hir::Node::Param(p) = self.tcx.parent_hir_node(b.hir_id)
352 && let Some(decl) = self.tcx.parent_hir_node(p.hir_id).fn_decl()
353 && let Some(ty) = decl.inputs.iter().find(|ty| ty.span == p.ty_span)
354 && let hir::TyKind::Ref(_, mut_ty) = &ty.kind
355 && let hir::Mutability::Not = mut_ty.mutbl
356 {
357 err.span_suggestion_verbose(
358 mut_ty.ty.span.shrink_to_lo(),
359 msg,
360 "mut ",
361 Applicability::MachineApplicable,
362 );
363 } else {
364 err.help(msg);
365 }
366 }
367 }
368 err.emit()
369 }
370
371 MethodError::ErrorReported(guar) => guar,
372
373 MethodError::BadReturnType => bug!("no return type expectations but got BadReturnType"),
374 }
375 }
376
377 fn suggest_missing_writer(
378 &self,
379 rcvr_ty: Ty<'tcx>,
380 rcvr_expr: &hir::Expr<'tcx>,
381 mut long_ty_path: Option<PathBuf>,
382 ) -> Diag<'_> {
383 let mut err = struct_span_code_err!(
384 self.dcx(),
385 rcvr_expr.span,
386 E0599,
387 "cannot write into `{}`",
388 self.tcx.short_string(rcvr_ty, &mut long_ty_path),
389 );
390 *err.long_ty_path() = long_ty_path;
391 err.span_note(
392 rcvr_expr.span,
393 "must implement `io::Write`, `fmt::Write`, or have a `write_fmt` method",
394 );
395 if let ExprKind::Lit(_) = rcvr_expr.kind {
396 err.span_help(
397 rcvr_expr.span.shrink_to_lo(),
398 "a writer is needed before this format string",
399 );
400 };
401 err
402 }
403
404 fn suggest_use_shadowed_binding_with_method(
405 &self,
406 self_source: SelfSource<'tcx>,
407 method_name: Ident,
408 ty: Ty<'tcx>,
409 err: &mut Diag<'_>,
410 ) {
411 #[derive(Debug)]
412 struct LetStmt {
413 ty_hir_id_opt: Option<hir::HirId>,
414 binding_id: hir::HirId,
415 span: Span,
416 init_hir_id: hir::HirId,
417 }
418
419 struct LetVisitor<'a, 'tcx> {
429 binding_name: Symbol,
431 binding_id: hir::HirId,
432 fcx: &'a FnCtxt<'a, 'tcx>,
434 call_expr: &'tcx Expr<'tcx>,
435 method_name: Ident,
436 sugg_let: Option<LetStmt>,
438 }
439
440 impl<'a, 'tcx> LetVisitor<'a, 'tcx> {
441 fn is_sub_scope(&self, sub_id: hir::ItemLocalId, super_id: hir::ItemLocalId) -> bool {
443 let scope_tree = self.fcx.tcx.region_scope_tree(self.fcx.body_id);
444 if let Some(sub_var_scope) = scope_tree.var_scope(sub_id)
445 && let Some(super_var_scope) = scope_tree.var_scope(super_id)
446 && scope_tree.is_subscope_of(sub_var_scope, super_var_scope)
447 {
448 return true;
449 }
450 false
451 }
452
453 fn check_and_add_sugg_binding(&mut self, binding: LetStmt) -> bool {
456 if !self.is_sub_scope(self.binding_id.local_id, binding.binding_id.local_id) {
457 return false;
458 }
459
460 if let Some(ty_hir_id) = binding.ty_hir_id_opt
462 && let Some(tyck_ty) = self.fcx.node_ty_opt(ty_hir_id)
463 {
464 if self
465 .fcx
466 .lookup_probe_for_diagnostic(
467 self.method_name,
468 tyck_ty,
469 self.call_expr,
470 ProbeScope::TraitsInScope,
471 None,
472 )
473 .is_ok()
474 {
475 self.sugg_let = Some(binding);
476 return true;
477 } else {
478 return false;
479 }
480 }
481
482 if let Some(self_ty) = self.fcx.node_ty_opt(binding.init_hir_id)
487 && self
488 .fcx
489 .lookup_probe_for_diagnostic(
490 self.method_name,
491 self_ty,
492 self.call_expr,
493 ProbeScope::TraitsInScope,
494 None,
495 )
496 .is_ok()
497 {
498 self.sugg_let = Some(binding);
499 return true;
500 }
501 return false;
502 }
503 }
504
505 impl<'v> Visitor<'v> for LetVisitor<'_, '_> {
506 type Result = ControlFlow<()>;
507 fn visit_stmt(&mut self, ex: &'v hir::Stmt<'v>) -> Self::Result {
508 if let hir::StmtKind::Let(&hir::LetStmt { pat, ty, init, .. }) = ex.kind
509 && let hir::PatKind::Binding(_, binding_id, binding_name, ..) = pat.kind
510 && let Some(init) = init
511 && binding_name.name == self.binding_name
512 && binding_id != self.binding_id
513 {
514 if self.check_and_add_sugg_binding(LetStmt {
515 ty_hir_id_opt: ty.map(|ty| ty.hir_id),
516 binding_id,
517 span: pat.span,
518 init_hir_id: init.hir_id,
519 }) {
520 return ControlFlow::Break(());
521 }
522 ControlFlow::Continue(())
523 } else {
524 hir::intravisit::walk_stmt(self, ex)
525 }
526 }
527
528 fn visit_pat(&mut self, p: &'v hir::Pat<'v>) -> Self::Result {
532 match p.kind {
533 hir::PatKind::Binding(_, binding_id, binding_name, _) => {
534 if binding_name.name == self.binding_name && binding_id == self.binding_id {
535 return ControlFlow::Break(());
536 }
537 }
538 _ => {
539 let _ = intravisit::walk_pat(self, p);
540 }
541 }
542 ControlFlow::Continue(())
543 }
544 }
545
546 if let SelfSource::MethodCall(rcvr) = self_source
547 && let hir::ExprKind::Path(QPath::Resolved(_, path)) = rcvr.kind
548 && let hir::def::Res::Local(recv_id) = path.res
549 && let Some(segment) = path.segments.first()
550 {
551 let body = self.tcx.hir_body_owned_by(self.body_id);
552
553 if let Node::Expr(call_expr) = self.tcx.parent_hir_node(rcvr.hir_id) {
554 let mut let_visitor = LetVisitor {
555 fcx: self,
556 call_expr,
557 binding_name: segment.ident.name,
558 binding_id: recv_id,
559 method_name,
560 sugg_let: None,
561 };
562 let _ = let_visitor.visit_body(&body);
563 if let Some(sugg_let) = let_visitor.sugg_let
564 && let Some(self_ty) = self.node_ty_opt(sugg_let.init_hir_id)
565 {
566 let _sm = self.infcx.tcx.sess.source_map();
567 let rcvr_name = segment.ident.name;
568 let mut span = MultiSpan::from_span(sugg_let.span);
569 span.push_span_label(sugg_let.span,
570 format!("`{rcvr_name}` of type `{self_ty}` that has method `{method_name}` defined earlier here"));
571
572 let ty = self.tcx.short_string(ty, err.long_ty_path());
573 span.push_span_label(
574 self.tcx.hir_span(recv_id),
575 format!("earlier `{rcvr_name}` shadowed here with type `{ty}`"),
576 );
577 err.span_note(
578 span,
579 format!(
580 "there's an earlier shadowed binding `{rcvr_name}` of type `{self_ty}` \
581 that has method `{method_name}` available"
582 ),
583 );
584 }
585 }
586 }
587 }
588
589 fn report_no_match_method_error(
590 &self,
591 mut span: Span,
592 rcvr_ty: Ty<'tcx>,
593 item_ident: Ident,
594 expr_id: hir::HirId,
595 source: SelfSource<'tcx>,
596 args: Option<&'tcx [hir::Expr<'tcx>]>,
597 sugg_span: Span,
598 no_match_data: &mut NoMatchData<'tcx>,
599 expected: Expectation<'tcx>,
600 trait_missing_method: bool,
601 within_macro_span: Option<Span>,
602 ) -> ErrorGuaranteed {
603 let mode = no_match_data.mode;
604 let tcx = self.tcx;
605 let rcvr_ty = self.resolve_vars_if_possible(rcvr_ty);
606 let mut ty_file = None;
607 let is_method = mode == Mode::MethodCall;
608 let unsatisfied_predicates = &no_match_data.unsatisfied_predicates;
609 let similar_candidate = no_match_data.similar_candidate;
610 let item_kind = if is_method {
611 "method"
612 } else if rcvr_ty.is_enum() {
613 "variant or associated item"
614 } else {
615 match (item_ident.as_str().chars().next(), rcvr_ty.is_fresh_ty()) {
616 (Some(name), false) if name.is_lowercase() => "function or associated item",
617 (Some(_), false) => "associated item",
618 (Some(_), true) | (None, false) => "variant or associated item",
619 (None, true) => "variant",
620 }
621 };
622
623 if let Err(guar) =
626 self.report_failed_method_call_on_range_end(tcx, rcvr_ty, source, span, item_ident)
627 {
628 return guar;
629 }
630 if let Err(guar) = self.report_failed_method_call_on_numerical_infer_var(
631 tcx,
632 rcvr_ty,
633 source,
634 span,
635 item_kind,
636 item_ident,
637 &mut ty_file,
638 ) {
639 return guar;
640 }
641 span = item_ident.span;
642
643 let is_write = sugg_span.ctxt().outer_expn_data().macro_def_id.is_some_and(|def_id| {
644 tcx.is_diagnostic_item(sym::write_macro, def_id)
645 || tcx.is_diagnostic_item(sym::writeln_macro, def_id)
646 }) && item_ident.name == sym::write_fmt;
647 let mut err = if is_write && let SelfSource::MethodCall(rcvr_expr) = source {
648 self.suggest_missing_writer(rcvr_ty, rcvr_expr, ty_file)
649 } else {
650 let mut ty = rcvr_ty;
653 if let ty::Adt(def, generics) = rcvr_ty.kind() {
654 if generics.len() > 0 {
655 let mut autoderef = self.autoderef(span, rcvr_ty).silence_errors();
656 let candidate_found = autoderef.any(|(ty, _)| {
657 if let ty::Adt(adt_def, _) = ty.kind() {
658 self.tcx
659 .inherent_impls(adt_def.did())
660 .into_iter()
661 .any(|def_id| self.associated_value(*def_id, item_ident).is_some())
662 } else {
663 false
664 }
665 });
666 let has_deref = autoderef.step_count() > 0;
667 if !candidate_found && !has_deref && unsatisfied_predicates.is_empty() {
668 ty = self.tcx.at(span).type_of(def.did()).instantiate_identity();
669 }
670 }
671 }
672
673 let mut err = self.dcx().create_err(NoAssociatedItem {
674 span,
675 item_kind,
676 item_ident,
677 ty_prefix: if trait_missing_method {
678 Cow::from("trait")
680 } else {
681 rcvr_ty.prefix_string(self.tcx)
682 },
683 ty,
684 trait_missing_method,
685 });
686
687 if is_method {
688 self.suggest_use_shadowed_binding_with_method(
689 source, item_ident, rcvr_ty, &mut err,
690 );
691 }
692
693 if let SelfSource::QPath(ty) = source
695 && let hir::TyKind::Path(hir::QPath::Resolved(_, path)) = ty.kind
696 && let Res::SelfTyAlias { alias_to: impl_def_id, .. } = path.res
697 && let DefKind::Impl { .. } = self.tcx.def_kind(impl_def_id)
698 && let Some(candidate) = tcx.associated_items(impl_def_id).find_by_ident_and_kind(
699 self.tcx,
700 item_ident,
701 ty::AssocTag::Type,
702 impl_def_id,
703 )
704 && let Some(adt_def) = tcx.type_of(candidate.def_id).skip_binder().ty_adt_def()
705 && adt_def.is_struct()
706 && adt_def.non_enum_variant().ctor_kind() == Some(CtorKind::Fn)
707 {
708 let def_path = tcx.def_path_str(adt_def.did());
709 err.span_suggestion(
710 sugg_span,
711 format!("to construct a value of type `{}`, use the explicit path", def_path),
712 def_path,
713 Applicability::MachineApplicable,
714 );
715 }
716
717 err
718 };
719
720 if tcx.sess.source_map().is_multiline(sugg_span) {
721 err.span_label(sugg_span.with_hi(span.lo()), "");
722 }
723 if let Some(within_macro_span) = within_macro_span {
724 err.span_label(within_macro_span, "due to this macro variable");
725 }
726
727 if rcvr_ty.references_error() {
728 err.downgrade_to_delayed_bug();
729 }
730
731 if matches!(source, SelfSource::QPath(_)) && args.is_some() {
732 self.find_builder_fn(&mut err, rcvr_ty, expr_id);
733 }
734
735 if tcx.ty_is_opaque_future(rcvr_ty) && item_ident.name == sym::poll {
736 let ty_str = self.tcx.short_string(rcvr_ty, err.long_ty_path());
737 err.help(format!(
738 "method `poll` found on `Pin<&mut {ty_str}>`, \
739 see documentation for `std::pin::Pin`"
740 ));
741 err.help("self type must be pinned to call `Future::poll`, \
742 see https://rust-lang.github.io/async-book/04_pinning/01_chapter.html#pinning-in-practice"
743 );
744 }
745
746 if let Mode::MethodCall = mode
747 && let SelfSource::MethodCall(cal) = source
748 {
749 self.suggest_await_before_method(
750 &mut err,
751 item_ident,
752 rcvr_ty,
753 cal,
754 span,
755 expected.only_has_type(self),
756 );
757 }
758 if let Some(span) =
759 tcx.resolutions(()).confused_type_with_std_module.get(&span.with_parent(None))
760 {
761 err.span_suggestion(
762 span.shrink_to_lo(),
763 "you are looking for the module in `std`, not the primitive type",
764 "std::",
765 Applicability::MachineApplicable,
766 );
767 }
768
769 if let SelfSource::MethodCall(rcvr_expr) = source
771 && let ty::RawPtr(ty, ptr_mutbl) = *rcvr_ty.kind()
772 && let Ok(pick) = self.lookup_probe_for_diagnostic(
773 item_ident,
774 Ty::new_ref(tcx, ty::Region::new_error_misc(tcx), ty, ptr_mutbl),
775 self.tcx.hir_expect_expr(self.tcx.parent_hir_id(rcvr_expr.hir_id)),
776 ProbeScope::TraitsInScope,
777 None,
778 )
779 && let ty::Ref(_, _, sugg_mutbl) = *pick.self_ty.kind()
780 && (sugg_mutbl.is_not() || ptr_mutbl.is_mut())
781 {
782 let (method, method_anchor) = match sugg_mutbl {
783 Mutability::Not => {
784 let method_anchor = match ptr_mutbl {
785 Mutability::Not => "as_ref",
786 Mutability::Mut => "as_ref-1",
787 };
788 ("as_ref", method_anchor)
789 }
790 Mutability::Mut => ("as_mut", "as_mut"),
791 };
792 err.span_note(
793 tcx.def_span(pick.item.def_id),
794 format!("the method `{item_ident}` exists on the type `{ty}`", ty = pick.self_ty),
795 );
796 let mut_str = ptr_mutbl.ptr_str();
797 err.note(format!(
798 "you might want to use the unsafe method `<*{mut_str} T>::{method}` to get \
799 an optional reference to the value behind the pointer"
800 ));
801 err.note(format!(
802 "read the documentation for `<*{mut_str} T>::{method}` and ensure you satisfy its \
803 safety preconditions before calling it to avoid undefined behavior: \
804 https://doc.rust-lang.org/std/primitive.pointer.html#method.{method_anchor}"
805 ));
806 }
807
808 let mut ty_span = match rcvr_ty.kind() {
809 ty::Param(param_type) => {
810 Some(param_type.span_from_generics(self.tcx, self.body_id.to_def_id()))
811 }
812 ty::Adt(def, _) if def.did().is_local() => Some(tcx.def_span(def.did())),
813 _ => None,
814 };
815
816 if let SelfSource::MethodCall(rcvr_expr) = source {
817 self.suggest_fn_call(&mut err, rcvr_expr, rcvr_ty, |output_ty| {
818 let call_expr = self.tcx.hir_expect_expr(self.tcx.parent_hir_id(rcvr_expr.hir_id));
819 let probe = self.lookup_probe_for_diagnostic(
820 item_ident,
821 output_ty,
822 call_expr,
823 ProbeScope::AllTraits,
824 expected.only_has_type(self),
825 );
826 probe.is_ok()
827 });
828 self.note_internal_mutation_in_method(
829 &mut err,
830 rcvr_expr,
831 expected.to_option(self),
832 rcvr_ty,
833 );
834 }
835
836 let mut custom_span_label = false;
837
838 let static_candidates = &mut no_match_data.static_candidates;
839
840 static_candidates.dedup();
844
845 if !static_candidates.is_empty() {
846 err.note(
847 "found the following associated functions; to be used as methods, \
848 functions must have a `self` parameter",
849 );
850 err.span_label(span, "this is an associated function, not a method");
851 custom_span_label = true;
852 }
853 if static_candidates.len() == 1 {
854 self.suggest_associated_call_syntax(
855 &mut err,
856 static_candidates,
857 rcvr_ty,
858 source,
859 item_ident,
860 args,
861 sugg_span,
862 );
863 self.note_candidates_on_method_error(
864 rcvr_ty,
865 item_ident,
866 source,
867 args,
868 span,
869 &mut err,
870 static_candidates,
871 None,
872 );
873 } else if static_candidates.len() > 1 {
874 self.note_candidates_on_method_error(
875 rcvr_ty,
876 item_ident,
877 source,
878 args,
879 span,
880 &mut err,
881 static_candidates,
882 Some(sugg_span),
883 );
884 }
885
886 let mut bound_spans: SortedMap<Span, Vec<String>> = Default::default();
887 let mut restrict_type_params = false;
888 let mut suggested_derive = false;
889 let mut unsatisfied_bounds = false;
890 if item_ident.name == sym::count && self.is_slice_ty(rcvr_ty, span) {
891 let msg = "consider using `len` instead";
892 if let SelfSource::MethodCall(_expr) = source {
893 err.span_suggestion_short(span, msg, "len", Applicability::MachineApplicable);
894 } else {
895 err.span_label(span, msg);
896 }
897 if let Some(iterator_trait) = self.tcx.get_diagnostic_item(sym::Iterator) {
898 let iterator_trait = self.tcx.def_path_str(iterator_trait);
899 err.note(format!(
900 "`count` is defined on `{iterator_trait}`, which `{rcvr_ty}` does not implement"
901 ));
902 }
903 } else if self.impl_into_iterator_should_be_iterator(rcvr_ty, span, unsatisfied_predicates)
904 {
905 err.span_label(span, format!("`{rcvr_ty}` is not an iterator"));
906 if !span.in_external_macro(self.tcx.sess.source_map()) {
907 err.multipart_suggestion_verbose(
908 "call `.into_iter()` first",
909 vec![(span.shrink_to_lo(), format!("into_iter()."))],
910 Applicability::MaybeIncorrect,
911 );
912 }
913 return err.emit();
914 } else if !unsatisfied_predicates.is_empty() && matches!(rcvr_ty.kind(), ty::Param(_)) {
915 } else if !unsatisfied_predicates.is_empty() {
926 let mut type_params = FxIndexMap::default();
927
928 let mut unimplemented_traits = FxIndexMap::default();
931 let mut unimplemented_traits_only = true;
932 for (predicate, _parent_pred, cause) in unsatisfied_predicates {
933 if let (ty::PredicateKind::Clause(ty::ClauseKind::Trait(p)), Some(cause)) =
934 (predicate.kind().skip_binder(), cause.as_ref())
935 {
936 if p.trait_ref.self_ty() != rcvr_ty {
937 continue;
941 }
942 unimplemented_traits.entry(p.trait_ref.def_id).or_insert((
943 predicate.kind().rebind(p),
944 Obligation {
945 cause: cause.clone(),
946 param_env: self.param_env,
947 predicate: *predicate,
948 recursion_depth: 0,
949 },
950 ));
951 }
952 }
953
954 for (predicate, _parent_pred, _cause) in unsatisfied_predicates {
959 match predicate.kind().skip_binder() {
960 ty::PredicateKind::Clause(ty::ClauseKind::Trait(p))
961 if unimplemented_traits.contains_key(&p.trait_ref.def_id) => {}
962 _ => {
963 unimplemented_traits_only = false;
964 break;
965 }
966 }
967 }
968
969 let mut collect_type_param_suggestions =
970 |self_ty: Ty<'tcx>, parent_pred: ty::Predicate<'tcx>, obligation: &str| {
971 if let (ty::Param(_), ty::PredicateKind::Clause(ty::ClauseKind::Trait(p))) =
973 (self_ty.kind(), parent_pred.kind().skip_binder())
974 {
975 let node = match p.trait_ref.self_ty().kind() {
976 ty::Param(_) => {
977 Some(self.tcx.hir_node_by_def_id(self.body_id))
980 }
981 ty::Adt(def, _) => def
982 .did()
983 .as_local()
984 .map(|def_id| self.tcx.hir_node_by_def_id(def_id)),
985 _ => None,
986 };
987 if let Some(hir::Node::Item(hir::Item { kind, .. })) = node
988 && let Some(g) = kind.generics()
989 {
990 let key = (
991 g.tail_span_for_predicate_suggestion(),
992 g.add_where_or_trailing_comma(),
993 );
994 type_params
995 .entry(key)
996 .or_insert_with(UnordSet::default)
997 .insert(obligation.to_owned());
998 return true;
999 }
1000 }
1001 false
1002 };
1003 let mut bound_span_label = |self_ty: Ty<'_>, obligation: &str, quiet: &str| {
1004 let msg = format!("`{}`", if obligation.len() > 50 { quiet } else { obligation });
1005 match self_ty.kind() {
1006 ty::Adt(def, _) => {
1008 bound_spans.get_mut_or_insert_default(tcx.def_span(def.did())).push(msg)
1009 }
1010 ty::Dynamic(preds, _) => {
1012 for pred in preds.iter() {
1013 match pred.skip_binder() {
1014 ty::ExistentialPredicate::Trait(tr) => {
1015 bound_spans
1016 .get_mut_or_insert_default(tcx.def_span(tr.def_id))
1017 .push(msg.clone());
1018 }
1019 ty::ExistentialPredicate::Projection(_)
1020 | ty::ExistentialPredicate::AutoTrait(_) => {}
1021 }
1022 }
1023 }
1024 ty::Closure(def_id, _) => {
1026 bound_spans
1027 .get_mut_or_insert_default(tcx.def_span(*def_id))
1028 .push(format!("`{quiet}`"));
1029 }
1030 _ => {}
1031 }
1032 };
1033 let mut format_pred = |pred: ty::Predicate<'tcx>| {
1034 let bound_predicate = pred.kind();
1035 match bound_predicate.skip_binder() {
1036 ty::PredicateKind::Clause(ty::ClauseKind::Projection(pred)) => {
1037 let pred = bound_predicate.rebind(pred);
1038 let projection_term = pred.skip_binder().projection_term;
1040 let quiet_projection_term = projection_term
1041 .with_replaced_self_ty(tcx, Ty::new_var(tcx, ty::TyVid::ZERO));
1042
1043 let term = pred.skip_binder().term;
1044
1045 let obligation = format!("{projection_term} = {term}");
1046 let quiet = with_forced_trimmed_paths!(format!(
1047 "{} = {}",
1048 quiet_projection_term, term
1049 ));
1050
1051 bound_span_label(projection_term.self_ty(), &obligation, &quiet);
1052 Some((obligation, projection_term.self_ty()))
1053 }
1054 ty::PredicateKind::Clause(ty::ClauseKind::Trait(poly_trait_ref)) => {
1055 let p = poly_trait_ref.trait_ref;
1056 let self_ty = p.self_ty();
1057 let path = p.print_only_trait_path();
1058 let obligation = format!("{self_ty}: {path}");
1059 let quiet = with_forced_trimmed_paths!(format!("_: {}", path));
1060 bound_span_label(self_ty, &obligation, &quiet);
1061 Some((obligation, self_ty))
1062 }
1063 _ => None,
1064 }
1065 };
1066
1067 let mut skip_list: UnordSet<_> = Default::default();
1069 let mut spanned_predicates = FxIndexMap::default();
1070 for (p, parent_p, cause) in unsatisfied_predicates {
1071 let (item_def_id, cause_span) = match cause.as_ref().map(|cause| cause.code()) {
1074 Some(ObligationCauseCode::ImplDerived(data)) => {
1075 (data.impl_or_alias_def_id, data.span)
1076 }
1077 Some(
1078 ObligationCauseCode::WhereClauseInExpr(def_id, span, _, _)
1079 | ObligationCauseCode::WhereClause(def_id, span),
1080 ) if !span.is_dummy() => (*def_id, *span),
1081 _ => continue,
1082 };
1083
1084 if !matches!(
1086 p.kind().skip_binder(),
1087 ty::PredicateKind::Clause(
1088 ty::ClauseKind::Projection(..) | ty::ClauseKind::Trait(..)
1089 )
1090 ) {
1091 continue;
1092 }
1093
1094 match self.tcx.hir_get_if_local(item_def_id) {
1095 Some(Node::Item(hir::Item {
1098 kind: hir::ItemKind::Impl(hir::Impl { of_trait, self_ty, .. }),
1099 ..
1100 })) if matches!(
1101 self_ty.span.ctxt().outer_expn_data().kind,
1102 ExpnKind::Macro(MacroKind::Derive, _)
1103 ) || matches!(
1104 of_trait.map(|t| t.trait_ref.path.span.ctxt().outer_expn_data().kind),
1105 Some(ExpnKind::Macro(MacroKind::Derive, _))
1106 ) =>
1107 {
1108 let span = self_ty.span.ctxt().outer_expn_data().call_site;
1109 let entry = spanned_predicates.entry(span);
1110 let entry = entry.or_insert_with(|| {
1111 (FxIndexSet::default(), FxIndexSet::default(), Vec::new())
1112 });
1113 entry.0.insert(span);
1114 entry.1.insert((
1115 span,
1116 "unsatisfied trait bound introduced in this `derive` macro",
1117 ));
1118 entry.2.push(p);
1119 skip_list.insert(p);
1120 }
1121
1122 Some(Node::Item(hir::Item {
1124 kind: hir::ItemKind::Impl(hir::Impl { of_trait, self_ty, generics, .. }),
1125 span: item_span,
1126 ..
1127 })) => {
1128 let sized_pred =
1129 unsatisfied_predicates.iter().any(|(pred, _, _)| {
1130 match pred.kind().skip_binder() {
1131 ty::PredicateKind::Clause(ty::ClauseKind::Trait(pred)) => {
1132 self.tcx.is_lang_item(pred.def_id(), LangItem::Sized)
1133 && pred.polarity == ty::PredicatePolarity::Positive
1134 }
1135 _ => false,
1136 }
1137 });
1138 for param in generics.params {
1139 if param.span == cause_span && sized_pred {
1140 let (sp, sugg) = match param.colon_span {
1141 Some(sp) => (sp.shrink_to_hi(), " ?Sized +"),
1142 None => (param.span.shrink_to_hi(), ": ?Sized"),
1143 };
1144 err.span_suggestion_verbose(
1145 sp,
1146 "consider relaxing the type parameter's implicit `Sized` bound",
1147 sugg,
1148 Applicability::MachineApplicable,
1149 );
1150 }
1151 }
1152 if let Some(pred) = parent_p {
1153 let _ = format_pred(*pred);
1155 }
1156 skip_list.insert(p);
1157 let entry = spanned_predicates.entry(self_ty.span);
1158 let entry = entry.or_insert_with(|| {
1159 (FxIndexSet::default(), FxIndexSet::default(), Vec::new())
1160 });
1161 entry.2.push(p);
1162 if cause_span != *item_span {
1163 entry.0.insert(cause_span);
1164 entry.1.insert((cause_span, "unsatisfied trait bound introduced here"));
1165 } else {
1166 if let Some(of_trait) = of_trait {
1167 entry.0.insert(of_trait.trait_ref.path.span);
1168 }
1169 entry.0.insert(self_ty.span);
1170 };
1171 if let Some(of_trait) = of_trait {
1172 entry.1.insert((of_trait.trait_ref.path.span, ""));
1173 }
1174 entry.1.insert((self_ty.span, ""));
1175 }
1176 Some(Node::Item(hir::Item {
1177 kind: hir::ItemKind::Trait(_, rustc_ast::ast::IsAuto::Yes, ..),
1178 span: item_span,
1179 ..
1180 })) => {
1181 self.dcx().span_delayed_bug(
1182 *item_span,
1183 "auto trait is invoked with no method error, but no error reported?",
1184 );
1185 }
1186 Some(
1187 Node::Item(hir::Item {
1188 kind:
1189 hir::ItemKind::Trait(_, _, _, ident, ..)
1190 | hir::ItemKind::TraitAlias(ident, ..),
1191 ..
1192 })
1193 | Node::TraitItem(hir::TraitItem { ident, .. })
1195 | Node::ImplItem(hir::ImplItem { ident, .. })
1196 ) => {
1197 skip_list.insert(p);
1198 let entry = spanned_predicates.entry(ident.span);
1199 let entry = entry.or_insert_with(|| {
1200 (FxIndexSet::default(), FxIndexSet::default(), Vec::new())
1201 });
1202 entry.0.insert(cause_span);
1203 entry.1.insert((ident.span, ""));
1204 entry.1.insert((cause_span, "unsatisfied trait bound introduced here"));
1205 entry.2.push(p);
1206 }
1207 _ => {
1208 }
1213 }
1214 }
1215 let mut spanned_predicates: Vec<_> = spanned_predicates.into_iter().collect();
1216 spanned_predicates.sort_by_key(|(span, _)| *span);
1217 for (_, (primary_spans, span_labels, predicates)) in spanned_predicates {
1218 let mut preds: Vec<_> = predicates
1219 .iter()
1220 .filter_map(|pred| format_pred(**pred))
1221 .map(|(p, _)| format!("`{p}`"))
1222 .collect();
1223 preds.sort();
1224 preds.dedup();
1225 let msg = if let [pred] = &preds[..] {
1226 format!("trait bound {pred} was not satisfied")
1227 } else {
1228 format!("the following trait bounds were not satisfied:\n{}", preds.join("\n"),)
1229 };
1230 let mut span: MultiSpan = primary_spans.into_iter().collect::<Vec<_>>().into();
1231 for (sp, label) in span_labels {
1232 span.push_span_label(sp, label);
1233 }
1234 err.span_note(span, msg);
1235 unsatisfied_bounds = true;
1236 }
1237
1238 let mut suggested_bounds = UnordSet::default();
1239 let mut bound_list = unsatisfied_predicates
1241 .iter()
1242 .filter_map(|(pred, parent_pred, _cause)| {
1243 let mut suggested = false;
1244 format_pred(*pred).map(|(p, self_ty)| {
1245 if let Some(parent) = parent_pred
1246 && suggested_bounds.contains(parent)
1247 {
1248 } else if !suggested_bounds.contains(pred)
1250 && collect_type_param_suggestions(self_ty, *pred, &p)
1251 {
1252 suggested = true;
1253 suggested_bounds.insert(pred);
1254 }
1255 (
1256 match parent_pred {
1257 None => format!("`{p}`"),
1258 Some(parent_pred) => match format_pred(*parent_pred) {
1259 None => format!("`{p}`"),
1260 Some((parent_p, _)) => {
1261 if !suggested
1262 && !suggested_bounds.contains(pred)
1263 && !suggested_bounds.contains(parent_pred)
1264 && collect_type_param_suggestions(
1265 self_ty,
1266 *parent_pred,
1267 &p,
1268 )
1269 {
1270 suggested_bounds.insert(pred);
1271 }
1272 format!("`{p}`\nwhich is required by `{parent_p}`")
1273 }
1274 },
1275 },
1276 *pred,
1277 )
1278 })
1279 })
1280 .filter(|(_, pred)| !skip_list.contains(&pred))
1281 .map(|(t, _)| t)
1282 .enumerate()
1283 .collect::<Vec<(usize, String)>>();
1284
1285 if !matches!(rcvr_ty.peel_refs().kind(), ty::Param(_)) {
1286 for ((span, add_where_or_comma), obligations) in type_params.into_iter() {
1287 restrict_type_params = true;
1288 let obligations = obligations.into_sorted_stable_ord();
1290 err.span_suggestion_verbose(
1291 span,
1292 format!(
1293 "consider restricting the type parameter{s} to satisfy the trait \
1294 bound{s}",
1295 s = pluralize!(obligations.len())
1296 ),
1297 format!("{} {}", add_where_or_comma, obligations.join(", ")),
1298 Applicability::MaybeIncorrect,
1299 );
1300 }
1301 }
1302
1303 bound_list.sort_by(|(_, a), (_, b)| a.cmp(b)); bound_list.dedup_by(|(_, a), (_, b)| a == b); bound_list.sort_by_key(|(pos, _)| *pos); if !bound_list.is_empty() || !skip_list.is_empty() {
1308 let bound_list =
1309 bound_list.into_iter().map(|(_, path)| path).collect::<Vec<_>>().join("\n");
1310 let actual_prefix = rcvr_ty.prefix_string(self.tcx);
1311 info!("unimplemented_traits.len() == {}", unimplemented_traits.len());
1312 let (primary_message, label, notes) = if unimplemented_traits.len() == 1
1313 && unimplemented_traits_only
1314 {
1315 unimplemented_traits
1316 .into_iter()
1317 .next()
1318 .map(|(_, (trait_ref, obligation))| {
1319 if trait_ref.self_ty().references_error() || rcvr_ty.references_error()
1320 {
1321 return (None, None, Vec::new());
1323 }
1324 let OnUnimplementedNote { message, label, notes, .. } = self
1325 .err_ctxt()
1326 .on_unimplemented_note(trait_ref, &obligation, err.long_ty_path());
1327 (message, label, notes)
1328 })
1329 .unwrap()
1330 } else {
1331 (None, None, Vec::new())
1332 };
1333 let primary_message = primary_message.unwrap_or_else(|| {
1334 let ty_str = self.tcx.short_string(rcvr_ty, err.long_ty_path());
1335 format!(
1336 "the {item_kind} `{item_ident}` exists for {actual_prefix} `{ty_str}`, \
1337 but its trait bounds were not satisfied"
1338 )
1339 });
1340 err.primary_message(primary_message);
1341 if let Some(label) = label {
1342 custom_span_label = true;
1343 err.span_label(span, label);
1344 }
1345 if !bound_list.is_empty() {
1346 err.note(format!(
1347 "the following trait bounds were not satisfied:\n{bound_list}"
1348 ));
1349 }
1350 for note in notes {
1351 err.note(note);
1352 }
1353
1354 suggested_derive = self.suggest_derive(&mut err, unsatisfied_predicates);
1355
1356 unsatisfied_bounds = true;
1357 }
1358 } else if let ty::Adt(def, targs) = rcvr_ty.kind()
1359 && let SelfSource::MethodCall(rcvr_expr) = source
1360 {
1361 if targs.len() == 1 {
1365 let mut item_segment = hir::PathSegment::invalid();
1366 item_segment.ident = item_ident;
1367 for t in [Ty::new_mut_ref, Ty::new_imm_ref, |_, _, t| t] {
1368 let new_args =
1369 tcx.mk_args_from_iter(targs.iter().map(|arg| match arg.as_type() {
1370 Some(ty) => ty::GenericArg::from(t(
1371 tcx,
1372 tcx.lifetimes.re_erased,
1373 ty.peel_refs(),
1374 )),
1375 _ => arg,
1376 }));
1377 let rcvr_ty = Ty::new_adt(tcx, *def, new_args);
1378 if let Ok(method) = self.lookup_method_for_diagnostic(
1379 rcvr_ty,
1380 &item_segment,
1381 span,
1382 tcx.parent_hir_node(rcvr_expr.hir_id).expect_expr(),
1383 rcvr_expr,
1384 ) {
1385 err.span_note(
1386 tcx.def_span(method.def_id),
1387 format!("{item_kind} is available for `{rcvr_ty}`"),
1388 );
1389 }
1390 }
1391 }
1392 }
1393
1394 let mut find_candidate_for_method = false;
1395
1396 let mut label_span_not_found = |err: &mut Diag<'_>| {
1397 let ty_str = self.tcx.short_string(rcvr_ty, err.long_ty_path());
1398 if unsatisfied_predicates.is_empty() {
1399 err.span_label(span, format!("{item_kind} not found in `{ty_str}`"));
1400 let is_string_or_ref_str = match rcvr_ty.kind() {
1401 ty::Ref(_, ty, _) => {
1402 ty.is_str()
1403 || matches!(
1404 ty.kind(),
1405 ty::Adt(adt, _) if self.tcx.is_lang_item(adt.did(), LangItem::String)
1406 )
1407 }
1408 ty::Adt(adt, _) => self.tcx.is_lang_item(adt.did(), LangItem::String),
1409 _ => false,
1410 };
1411 if is_string_or_ref_str && item_ident.name == sym::iter {
1412 err.span_suggestion_verbose(
1413 item_ident.span,
1414 "because of the in-memory representation of `&str`, to obtain \
1415 an `Iterator` over each of its codepoint use method `chars`",
1416 "chars",
1417 Applicability::MachineApplicable,
1418 );
1419 }
1420 if let ty::Adt(adt, _) = rcvr_ty.kind() {
1421 let mut inherent_impls_candidate = self
1422 .tcx
1423 .inherent_impls(adt.did())
1424 .into_iter()
1425 .copied()
1426 .filter(|def_id| {
1427 if let Some(assoc) = self.associated_value(*def_id, item_ident) {
1428 match (mode, assoc.is_method(), source) {
1431 (Mode::MethodCall, true, SelfSource::MethodCall(_)) => {
1432 self.tcx.at(span).type_of(*def_id).instantiate_identity()
1437 != rcvr_ty
1438 }
1439 (Mode::Path, false, _) => true,
1440 _ => false,
1441 }
1442 } else {
1443 false
1444 }
1445 })
1446 .collect::<Vec<_>>();
1447 if !inherent_impls_candidate.is_empty() {
1448 inherent_impls_candidate.sort_by_key(|id| self.tcx.def_path_str(id));
1449 inherent_impls_candidate.dedup();
1450
1451 let limit = if inherent_impls_candidate.len() == 5 { 5 } else { 4 };
1453 let type_candidates = inherent_impls_candidate
1454 .iter()
1455 .take(limit)
1456 .map(|impl_item| {
1457 format!(
1458 "- `{}`",
1459 self.tcx.at(span).type_of(*impl_item).instantiate_identity()
1460 )
1461 })
1462 .collect::<Vec<_>>()
1463 .join("\n");
1464 let additional_types = if inherent_impls_candidate.len() > limit {
1465 format!("\nand {} more types", inherent_impls_candidate.len() - limit)
1466 } else {
1467 "".to_string()
1468 };
1469 err.note(format!(
1470 "the {item_kind} was found for\n{type_candidates}{additional_types}"
1471 ));
1472 find_candidate_for_method = mode == Mode::MethodCall;
1473 }
1474 }
1475 } else {
1476 let ty_str =
1477 if ty_str.len() > 50 { String::new() } else { format!("on `{ty_str}` ") };
1478 err.span_label(
1479 span,
1480 format!("{item_kind} cannot be called {ty_str}due to unsatisfied trait bounds"),
1481 );
1482 }
1483 };
1484
1485 if let SelfSource::MethodCall(expr) = source {
1488 if !self.suggest_calling_field_as_fn(span, rcvr_ty, expr, item_ident, &mut err)
1489 && similar_candidate.is_none()
1490 && !custom_span_label
1491 {
1492 label_span_not_found(&mut err);
1493 }
1494 } else if !custom_span_label {
1495 label_span_not_found(&mut err);
1496 }
1497
1498 let confusable_suggested = self.confusable_method_name(
1499 &mut err,
1500 rcvr_ty,
1501 item_ident,
1502 args.map(|args| {
1503 args.iter()
1504 .map(|expr| {
1505 self.node_ty_opt(expr.hir_id).unwrap_or_else(|| self.next_ty_var(expr.span))
1506 })
1507 .collect()
1508 }),
1509 );
1510
1511 if unsatisfied_predicates.is_empty() {
1514 self.suggest_calling_method_on_field(
1515 &mut err,
1516 source,
1517 span,
1518 rcvr_ty,
1519 item_ident,
1520 expected.only_has_type(self),
1521 );
1522 }
1523
1524 self.suggest_unwrapping_inner_self(&mut err, source, rcvr_ty, item_ident);
1525
1526 for (span, mut bounds) in bound_spans {
1527 if !tcx.sess.source_map().is_span_accessible(span) {
1528 continue;
1529 }
1530 bounds.sort();
1531 bounds.dedup();
1532 let pre = if Some(span) == ty_span {
1533 ty_span.take();
1534 format!(
1535 "{item_kind} `{item_ident}` not found for this {} because it ",
1536 rcvr_ty.prefix_string(self.tcx)
1537 )
1538 } else {
1539 String::new()
1540 };
1541 let msg = match &bounds[..] {
1542 [bound] => format!("{pre}doesn't satisfy {bound}"),
1543 bounds if bounds.len() > 4 => format!("doesn't satisfy {} bounds", bounds.len()),
1544 [bounds @ .., last] => {
1545 format!("{pre}doesn't satisfy {} or {last}", bounds.join(", "))
1546 }
1547 [] => unreachable!(),
1548 };
1549 err.span_label(span, msg);
1550 }
1551 if let Some(span) = ty_span {
1552 err.span_label(
1553 span,
1554 format!(
1555 "{item_kind} `{item_ident}` not found for this {}",
1556 rcvr_ty.prefix_string(self.tcx)
1557 ),
1558 );
1559 }
1560
1561 if rcvr_ty.is_numeric() && rcvr_ty.is_fresh() || restrict_type_params || suggested_derive {
1562 } else {
1563 self.suggest_traits_to_import(
1564 &mut err,
1565 span,
1566 rcvr_ty,
1567 item_ident,
1568 args.map(|args| args.len() + 1),
1569 source,
1570 no_match_data.out_of_scope_traits.clone(),
1571 static_candidates,
1572 unsatisfied_bounds,
1573 expected.only_has_type(self),
1574 trait_missing_method,
1575 );
1576 }
1577
1578 if unsatisfied_predicates.is_empty() && rcvr_ty.is_enum() {
1581 let adt_def = rcvr_ty.ty_adt_def().expect("enum is not an ADT");
1582 if let Some(var_name) = edit_distance::find_best_match_for_name(
1583 &adt_def.variants().iter().map(|s| s.name).collect::<Vec<_>>(),
1584 item_ident.name,
1585 None,
1586 ) && let Some(variant) = adt_def.variants().iter().find(|s| s.name == var_name)
1587 {
1588 let mut suggestion = vec![(span, var_name.to_string())];
1589 if let SelfSource::QPath(ty) = source
1590 && let hir::Node::Expr(ref path_expr) = self.tcx.parent_hir_node(ty.hir_id)
1591 && let hir::ExprKind::Path(_) = path_expr.kind
1592 && let hir::Node::Stmt(&hir::Stmt { kind: hir::StmtKind::Semi(parent), .. })
1593 | hir::Node::Expr(parent) = self.tcx.parent_hir_node(path_expr.hir_id)
1594 {
1595 let replacement_span =
1596 if let hir::ExprKind::Call(..) | hir::ExprKind::Struct(..) = parent.kind {
1597 span.with_hi(parent.span.hi())
1599 } else {
1600 span
1601 };
1602 match (variant.ctor, parent.kind) {
1603 (None, hir::ExprKind::Struct(..)) => {
1604 suggestion = vec![(span, var_name.to_string())];
1607 }
1608 (None, _) => {
1609 suggestion = vec![(
1611 replacement_span,
1612 if variant.fields.is_empty() {
1613 format!("{var_name} {{}}")
1614 } else {
1615 format!(
1616 "{var_name} {{ {} }}",
1617 variant
1618 .fields
1619 .iter()
1620 .map(|f| format!("{}: /* value */", f.name))
1621 .collect::<Vec<_>>()
1622 .join(", ")
1623 )
1624 },
1625 )];
1626 }
1627 (Some((hir::def::CtorKind::Const, _)), _) => {
1628 suggestion = vec![(replacement_span, var_name.to_string())];
1630 }
1631 (
1632 Some((hir::def::CtorKind::Fn, def_id)),
1633 hir::ExprKind::Call(rcvr, args),
1634 ) => {
1635 let fn_sig = self.tcx.fn_sig(def_id).instantiate_identity();
1636 let inputs = fn_sig.inputs().skip_binder();
1637 match (inputs, args) {
1640 (inputs, []) => {
1641 suggestion.push((
1643 rcvr.span.shrink_to_hi().with_hi(parent.span.hi()),
1644 format!(
1645 "({})",
1646 inputs
1647 .iter()
1648 .map(|i| format!("/* {i} */"))
1649 .collect::<Vec<String>>()
1650 .join(", ")
1651 ),
1652 ));
1653 }
1654 (_, [arg]) if inputs.len() != args.len() => {
1655 suggestion.push((
1657 arg.span,
1658 inputs
1659 .iter()
1660 .map(|i| format!("/* {i} */"))
1661 .collect::<Vec<String>>()
1662 .join(", "),
1663 ));
1664 }
1665 (_, [arg_start, .., arg_end]) if inputs.len() != args.len() => {
1666 suggestion.push((
1668 arg_start.span.to(arg_end.span),
1669 inputs
1670 .iter()
1671 .map(|i| format!("/* {i} */"))
1672 .collect::<Vec<String>>()
1673 .join(", "),
1674 ));
1675 }
1676 _ => {}
1678 }
1679 }
1680 (Some((hir::def::CtorKind::Fn, def_id)), _) => {
1681 let fn_sig = self.tcx.fn_sig(def_id).instantiate_identity();
1682 let inputs = fn_sig.inputs().skip_binder();
1683 suggestion = vec![(
1684 replacement_span,
1685 format!(
1686 "{var_name}({})",
1687 inputs
1688 .iter()
1689 .map(|i| format!("/* {i} */"))
1690 .collect::<Vec<String>>()
1691 .join(", ")
1692 ),
1693 )];
1694 }
1695 }
1696 }
1697 err.multipart_suggestion_verbose(
1698 "there is a variant with a similar name",
1699 suggestion,
1700 Applicability::HasPlaceholders,
1701 );
1702 }
1703 }
1704
1705 if let Some(similar_candidate) = similar_candidate {
1706 if unsatisfied_predicates.is_empty()
1709 && Some(similar_candidate.name()) != confusable_suggested
1711 && !span.from_expansion()
1713 {
1714 self.find_likely_intended_associated_item(
1715 &mut err,
1716 similar_candidate,
1717 span,
1718 args,
1719 mode,
1720 );
1721 }
1722 }
1723
1724 if !find_candidate_for_method {
1725 self.lookup_segments_chain_for_no_match_method(
1726 &mut err,
1727 item_ident,
1728 item_kind,
1729 source,
1730 no_match_data,
1731 );
1732 }
1733
1734 self.note_derefed_ty_has_method(&mut err, source, rcvr_ty, item_ident, expected);
1735 err.emit()
1736 }
1737
1738 fn lookup_segments_chain_for_no_match_method(
1740 &self,
1741 err: &mut Diag<'_>,
1742 item_name: Ident,
1743 item_kind: &str,
1744 source: SelfSource<'tcx>,
1745 no_match_data: &NoMatchData<'tcx>,
1746 ) {
1747 if no_match_data.unsatisfied_predicates.is_empty()
1748 && let Mode::MethodCall = no_match_data.mode
1749 && let SelfSource::MethodCall(mut source_expr) = source
1750 {
1751 let mut stack_methods = vec![];
1752 while let hir::ExprKind::MethodCall(_path_segment, rcvr_expr, _args, method_span) =
1753 source_expr.kind
1754 {
1755 if let Some(prev_match) = stack_methods.pop() {
1757 err.span_label(
1758 method_span,
1759 format!("{item_kind} `{item_name}` is available on `{prev_match}`"),
1760 );
1761 }
1762 let rcvr_ty = self.resolve_vars_if_possible(
1763 self.typeck_results
1764 .borrow()
1765 .expr_ty_adjusted_opt(rcvr_expr)
1766 .unwrap_or(Ty::new_misc_error(self.tcx)),
1767 );
1768
1769 let Ok(candidates) = self.probe_for_name_many(
1770 Mode::MethodCall,
1771 item_name,
1772 None,
1773 IsSuggestion(true),
1774 rcvr_ty,
1775 source_expr.hir_id,
1776 ProbeScope::TraitsInScope,
1777 ) else {
1778 return;
1779 };
1780
1781 for _matched_method in candidates {
1785 stack_methods.push(rcvr_ty);
1787 }
1788 source_expr = rcvr_expr;
1789 }
1790 if let Some(prev_match) = stack_methods.pop() {
1792 err.span_label(
1793 source_expr.span,
1794 format!("{item_kind} `{item_name}` is available on `{prev_match}`"),
1795 );
1796 }
1797 }
1798 }
1799
1800 fn find_likely_intended_associated_item(
1801 &self,
1802 err: &mut Diag<'_>,
1803 similar_candidate: ty::AssocItem,
1804 span: Span,
1805 args: Option<&'tcx [hir::Expr<'tcx>]>,
1806 mode: Mode,
1807 ) {
1808 let tcx = self.tcx;
1809 let def_kind = similar_candidate.as_def_kind();
1810 let an = self.tcx.def_kind_descr_article(def_kind, similar_candidate.def_id);
1811 let similar_candidate_name = similar_candidate.name();
1812 let msg = format!(
1813 "there is {an} {} `{}` with a similar name",
1814 self.tcx.def_kind_descr(def_kind, similar_candidate.def_id),
1815 similar_candidate_name,
1816 );
1817 if def_kind == DefKind::AssocFn {
1822 let ty_args = self.infcx.fresh_args_for_item(span, similar_candidate.def_id);
1823 let fn_sig = tcx.fn_sig(similar_candidate.def_id).instantiate(tcx, ty_args);
1824 let fn_sig = self.instantiate_binder_with_fresh_vars(
1825 span,
1826 BoundRegionConversionTime::FnCall,
1827 fn_sig,
1828 );
1829 if similar_candidate.is_method() {
1830 if let Some(args) = args
1831 && fn_sig.inputs()[1..].len() == args.len()
1832 {
1833 err.span_suggestion_verbose(
1836 span,
1837 msg,
1838 similar_candidate_name,
1839 Applicability::MaybeIncorrect,
1840 );
1841 } else {
1842 err.span_help(
1845 tcx.def_span(similar_candidate.def_id),
1846 format!(
1847 "{msg}{}",
1848 if let None = args { "" } else { ", but with different arguments" },
1849 ),
1850 );
1851 }
1852 } else if let Some(args) = args
1853 && fn_sig.inputs().len() == args.len()
1854 {
1855 err.span_suggestion_verbose(
1858 span,
1859 msg,
1860 similar_candidate_name,
1861 Applicability::MaybeIncorrect,
1862 );
1863 } else {
1864 err.span_help(tcx.def_span(similar_candidate.def_id), msg);
1865 }
1866 } else if let Mode::Path = mode
1867 && args.unwrap_or(&[]).is_empty()
1868 {
1869 err.span_suggestion_verbose(
1871 span,
1872 msg,
1873 similar_candidate_name,
1874 Applicability::MaybeIncorrect,
1875 );
1876 } else {
1877 err.span_help(tcx.def_span(similar_candidate.def_id), msg);
1880 }
1881 }
1882
1883 pub(crate) fn confusable_method_name(
1884 &self,
1885 err: &mut Diag<'_>,
1886 rcvr_ty: Ty<'tcx>,
1887 item_name: Ident,
1888 call_args: Option<Vec<Ty<'tcx>>>,
1889 ) -> Option<Symbol> {
1890 if let ty::Adt(adt, adt_args) = rcvr_ty.kind() {
1891 for inherent_impl_did in self.tcx.inherent_impls(adt.did()).into_iter() {
1892 for inherent_method in
1893 self.tcx.associated_items(inherent_impl_did).in_definition_order()
1894 {
1895 if let Some(candidates) = find_attr!(self.tcx.get_all_attrs(inherent_method.def_id), AttributeKind::Confusables{symbols, ..} => symbols)
1896 && candidates.contains(&item_name.name)
1897 && inherent_method.is_fn()
1898 {
1899 let args =
1900 ty::GenericArgs::identity_for_item(self.tcx, inherent_method.def_id)
1901 .rebase_onto(
1902 self.tcx,
1903 inherent_method.container_id(self.tcx),
1904 adt_args,
1905 );
1906 let fn_sig =
1907 self.tcx.fn_sig(inherent_method.def_id).instantiate(self.tcx, args);
1908 let fn_sig = self.instantiate_binder_with_fresh_vars(
1909 item_name.span,
1910 BoundRegionConversionTime::FnCall,
1911 fn_sig,
1912 );
1913 let name = inherent_method.name();
1914 if let Some(ref args) = call_args
1915 && fn_sig.inputs()[1..]
1916 .iter()
1917 .zip(args.into_iter())
1918 .all(|(expected, found)| self.may_coerce(*expected, *found))
1919 && fn_sig.inputs()[1..].len() == args.len()
1920 {
1921 err.span_suggestion_verbose(
1922 item_name.span,
1923 format!("you might have meant to use `{}`", name),
1924 name,
1925 Applicability::MaybeIncorrect,
1926 );
1927 return Some(name);
1928 } else if let None = call_args {
1929 err.span_note(
1930 self.tcx.def_span(inherent_method.def_id),
1931 format!("you might have meant to use method `{}`", name),
1932 );
1933 return Some(name);
1934 }
1935 }
1936 }
1937 }
1938 }
1939 None
1940 }
1941 fn note_candidates_on_method_error(
1942 &self,
1943 rcvr_ty: Ty<'tcx>,
1944 item_name: Ident,
1945 self_source: SelfSource<'tcx>,
1946 args: Option<&'tcx [hir::Expr<'tcx>]>,
1947 span: Span,
1948 err: &mut Diag<'_>,
1949 sources: &mut Vec<CandidateSource>,
1950 sugg_span: Option<Span>,
1951 ) {
1952 sources.sort_by_key(|source| match source {
1953 CandidateSource::Trait(id) => (0, self.tcx.def_path_str(id)),
1954 CandidateSource::Impl(id) => (1, self.tcx.def_path_str(id)),
1955 });
1956 sources.dedup();
1957 let limit = if sources.len() == 5 { 5 } else { 4 };
1959
1960 let mut suggs = vec![];
1961 for (idx, source) in sources.iter().take(limit).enumerate() {
1962 match *source {
1963 CandidateSource::Impl(impl_did) => {
1964 let Some(item) = self.associated_value(impl_did, item_name).or_else(|| {
1967 let impl_trait_ref = self.tcx.impl_trait_ref(impl_did)?;
1968 self.associated_value(impl_trait_ref.skip_binder().def_id, item_name)
1969 }) else {
1970 continue;
1971 };
1972
1973 let note_span = if item.def_id.is_local() {
1974 Some(self.tcx.def_span(item.def_id))
1975 } else if impl_did.is_local() {
1976 Some(self.tcx.def_span(impl_did))
1977 } else {
1978 None
1979 };
1980
1981 let impl_ty = self.tcx.at(span).type_of(impl_did).instantiate_identity();
1982
1983 let insertion = match self.tcx.impl_trait_ref(impl_did) {
1984 None => String::new(),
1985 Some(trait_ref) => {
1986 format!(
1987 " of the trait `{}`",
1988 self.tcx.def_path_str(trait_ref.skip_binder().def_id)
1989 )
1990 }
1991 };
1992
1993 let (note_str, idx) = if sources.len() > 1 {
1994 (
1995 format!(
1996 "candidate #{} is defined in an impl{} for the type `{}`",
1997 idx + 1,
1998 insertion,
1999 impl_ty,
2000 ),
2001 Some(idx + 1),
2002 )
2003 } else {
2004 (
2005 format!(
2006 "the candidate is defined in an impl{insertion} for the type `{impl_ty}`",
2007 ),
2008 None,
2009 )
2010 };
2011 if let Some(note_span) = note_span {
2012 err.span_note(note_span, note_str);
2014 } else {
2015 err.note(note_str);
2016 }
2017 if let Some(sugg_span) = sugg_span
2018 && let Some(trait_ref) = self.tcx.impl_trait_ref(impl_did)
2019 && let Some(sugg) = print_disambiguation_help(
2020 self.tcx,
2021 err,
2022 self_source,
2023 args,
2024 trait_ref
2025 .instantiate(
2026 self.tcx,
2027 self.fresh_args_for_item(sugg_span, impl_did),
2028 )
2029 .with_replaced_self_ty(self.tcx, rcvr_ty),
2030 idx,
2031 sugg_span,
2032 item,
2033 )
2034 {
2035 suggs.push(sugg);
2036 }
2037 }
2038 CandidateSource::Trait(trait_did) => {
2039 let Some(item) = self.associated_value(trait_did, item_name) else { continue };
2040 let item_span = self.tcx.def_span(item.def_id);
2041 let idx = if sources.len() > 1 {
2042 let msg = format!(
2043 "candidate #{} is defined in the trait `{}`",
2044 idx + 1,
2045 self.tcx.def_path_str(trait_did)
2046 );
2047 err.span_note(item_span, msg);
2048 Some(idx + 1)
2049 } else {
2050 let msg = format!(
2051 "the candidate is defined in the trait `{}`",
2052 self.tcx.def_path_str(trait_did)
2053 );
2054 err.span_note(item_span, msg);
2055 None
2056 };
2057 if let Some(sugg_span) = sugg_span
2058 && let Some(sugg) = print_disambiguation_help(
2059 self.tcx,
2060 err,
2061 self_source,
2062 args,
2063 ty::TraitRef::new_from_args(
2064 self.tcx,
2065 trait_did,
2066 self.fresh_args_for_item(sugg_span, trait_did),
2067 )
2068 .with_replaced_self_ty(self.tcx, rcvr_ty),
2069 idx,
2070 sugg_span,
2071 item,
2072 )
2073 {
2074 suggs.push(sugg);
2075 }
2076 }
2077 }
2078 }
2079 if !suggs.is_empty()
2080 && let Some(span) = sugg_span
2081 {
2082 suggs.sort();
2083 err.span_suggestions(
2084 span.with_hi(item_name.span.lo()),
2085 "use fully-qualified syntax to disambiguate",
2086 suggs,
2087 Applicability::MachineApplicable,
2088 );
2089 }
2090 if sources.len() > limit {
2091 err.note(format!("and {} others", sources.len() - limit));
2092 }
2093 }
2094
2095 fn find_builder_fn(&self, err: &mut Diag<'_>, rcvr_ty: Ty<'tcx>, expr_id: hir::HirId) {
2098 let ty::Adt(adt_def, _) = rcvr_ty.kind() else {
2099 return;
2100 };
2101 let mut items = self
2102 .tcx
2103 .inherent_impls(adt_def.did())
2104 .iter()
2105 .flat_map(|i| self.tcx.associated_items(i).in_definition_order())
2106 .filter(|item| {
2109 matches!(item.kind, ty::AssocKind::Fn { has_self: false, .. })
2110 && self
2111 .probe_for_name(
2112 Mode::Path,
2113 item.ident(self.tcx),
2114 None,
2115 IsSuggestion(true),
2116 rcvr_ty,
2117 expr_id,
2118 ProbeScope::TraitsInScope,
2119 )
2120 .is_ok()
2121 })
2122 .filter_map(|item| {
2123 let ret_ty = self
2125 .tcx
2126 .fn_sig(item.def_id)
2127 .instantiate(self.tcx, self.fresh_args_for_item(DUMMY_SP, item.def_id))
2128 .output();
2129 let ret_ty = self.tcx.instantiate_bound_regions_with_erased(ret_ty);
2130 let ty::Adt(def, args) = ret_ty.kind() else {
2131 return None;
2132 };
2133 if self.can_eq(self.param_env, ret_ty, rcvr_ty) {
2135 return Some((item.def_id, ret_ty));
2136 }
2137 if ![self.tcx.lang_items().option_type(), self.tcx.get_diagnostic_item(sym::Result)]
2139 .contains(&Some(def.did()))
2140 {
2141 return None;
2142 }
2143 let arg = args.get(0)?.expect_ty();
2144 if self.can_eq(self.param_env, rcvr_ty, arg) {
2145 Some((item.def_id, ret_ty))
2146 } else {
2147 None
2148 }
2149 })
2150 .collect::<Vec<_>>();
2151 let post = if items.len() > 5 {
2152 let items_len = items.len();
2153 items.truncate(4);
2154 format!("\nand {} others", items_len - 4)
2155 } else {
2156 String::new()
2157 };
2158 match &items[..] {
2159 [] => {}
2160 [(def_id, ret_ty)] => {
2161 err.span_note(
2162 self.tcx.def_span(def_id),
2163 format!(
2164 "if you're trying to build a new `{rcvr_ty}`, consider using `{}` which \
2165 returns `{ret_ty}`",
2166 self.tcx.def_path_str(def_id),
2167 ),
2168 );
2169 }
2170 _ => {
2171 let span: MultiSpan = items
2172 .iter()
2173 .map(|(def_id, _)| self.tcx.def_span(def_id))
2174 .collect::<Vec<Span>>()
2175 .into();
2176 err.span_note(
2177 span,
2178 format!(
2179 "if you're trying to build a new `{rcvr_ty}` consider using one of the \
2180 following associated functions:\n{}{post}",
2181 items
2182 .iter()
2183 .map(|(def_id, _ret_ty)| self.tcx.def_path_str(def_id))
2184 .collect::<Vec<String>>()
2185 .join("\n")
2186 ),
2187 );
2188 }
2189 }
2190 }
2191
2192 fn suggest_associated_call_syntax(
2195 &self,
2196 err: &mut Diag<'_>,
2197 static_candidates: &[CandidateSource],
2198 rcvr_ty: Ty<'tcx>,
2199 source: SelfSource<'tcx>,
2200 item_name: Ident,
2201 args: Option<&'tcx [hir::Expr<'tcx>]>,
2202 sugg_span: Span,
2203 ) {
2204 let mut has_unsuggestable_args = false;
2205 let ty_str = if let Some(CandidateSource::Impl(impl_did)) = static_candidates.get(0) {
2206 let impl_ty = self.tcx.type_of(*impl_did).instantiate_identity();
2210 let target_ty = self
2211 .autoderef(sugg_span, rcvr_ty)
2212 .silence_errors()
2213 .find(|(rcvr_ty, _)| {
2214 DeepRejectCtxt::relate_rigid_infer(self.tcx).types_may_unify(*rcvr_ty, impl_ty)
2215 })
2216 .map_or(impl_ty, |(ty, _)| ty)
2217 .peel_refs();
2218 if let ty::Adt(def, args) = target_ty.kind() {
2219 let infer_args = self.tcx.mk_args_from_iter(args.into_iter().map(|arg| {
2222 if !arg.is_suggestable(self.tcx, true) {
2223 has_unsuggestable_args = true;
2224 match arg.kind() {
2225 GenericArgKind::Lifetime(_) => {
2226 self.next_region_var(RegionVariableOrigin::Misc(DUMMY_SP)).into()
2227 }
2228 GenericArgKind::Type(_) => self.next_ty_var(DUMMY_SP).into(),
2229 GenericArgKind::Const(_) => self.next_const_var(DUMMY_SP).into(),
2230 }
2231 } else {
2232 arg
2233 }
2234 }));
2235
2236 self.tcx.value_path_str_with_args(def.did(), infer_args)
2237 } else {
2238 self.ty_to_value_string(target_ty)
2239 }
2240 } else {
2241 self.ty_to_value_string(rcvr_ty.peel_refs())
2242 };
2243 if let SelfSource::MethodCall(_) = source {
2244 let first_arg = static_candidates.get(0).and_then(|candidate_source| {
2245 let (assoc_did, self_ty) = match candidate_source {
2246 CandidateSource::Impl(impl_did) => {
2247 (*impl_did, self.tcx.type_of(*impl_did).instantiate_identity())
2248 }
2249 CandidateSource::Trait(trait_did) => (*trait_did, rcvr_ty),
2250 };
2251
2252 let assoc = self.associated_value(assoc_did, item_name)?;
2253 if !assoc.is_fn() {
2254 return None;
2255 }
2256
2257 let sig = self.tcx.fn_sig(assoc.def_id).instantiate_identity();
2260 sig.inputs().skip_binder().get(0).and_then(|first| {
2261 let first_ty = first.peel_refs();
2263 if first_ty == self_ty || first_ty == self.tcx.types.self_param {
2264 Some(first.ref_mutability().map_or("", |mutbl| mutbl.ref_prefix_str()))
2265 } else {
2266 None
2267 }
2268 })
2269 });
2270
2271 let mut applicability = Applicability::MachineApplicable;
2272 let args = if let SelfSource::MethodCall(receiver) = source
2273 && let Some(args) = args
2274 {
2275 let explicit_args = if first_arg.is_some() {
2277 std::iter::once(receiver).chain(args.iter()).collect::<Vec<_>>()
2278 } else {
2279 if has_unsuggestable_args {
2281 applicability = Applicability::HasPlaceholders;
2282 }
2283 args.iter().collect()
2284 };
2285 format!(
2286 "({}{})",
2287 first_arg.unwrap_or(""),
2288 explicit_args
2289 .iter()
2290 .map(|arg| self
2291 .tcx
2292 .sess
2293 .source_map()
2294 .span_to_snippet(arg.span)
2295 .unwrap_or_else(|_| {
2296 applicability = Applicability::HasPlaceholders;
2297 "_".to_owned()
2298 }))
2299 .collect::<Vec<_>>()
2300 .join(", "),
2301 )
2302 } else {
2303 applicability = Applicability::HasPlaceholders;
2304 "(...)".to_owned()
2305 };
2306 err.span_suggestion(
2307 sugg_span,
2308 "use associated function syntax instead",
2309 format!("{ty_str}::{item_name}{args}"),
2310 applicability,
2311 );
2312 } else {
2313 err.help(format!("try with `{ty_str}::{item_name}`",));
2314 }
2315 }
2316
2317 fn suggest_calling_field_as_fn(
2320 &self,
2321 span: Span,
2322 rcvr_ty: Ty<'tcx>,
2323 expr: &hir::Expr<'_>,
2324 item_name: Ident,
2325 err: &mut Diag<'_>,
2326 ) -> bool {
2327 let tcx = self.tcx;
2328 let field_receiver =
2329 self.autoderef(span, rcvr_ty).silence_errors().find_map(|(ty, _)| match ty.kind() {
2330 ty::Adt(def, args) if !def.is_enum() => {
2331 let variant = &def.non_enum_variant();
2332 tcx.find_field_index(item_name, variant).map(|index| {
2333 let field = &variant.fields[index];
2334 let field_ty = field.ty(tcx, args);
2335 (field, field_ty)
2336 })
2337 }
2338 _ => None,
2339 });
2340 if let Some((field, field_ty)) = field_receiver {
2341 let scope = tcx.parent_module_from_def_id(self.body_id);
2342 let is_accessible = field.vis.is_accessible_from(scope, tcx);
2343
2344 if is_accessible {
2345 if let Some((what, _, _)) = self.extract_callable_info(field_ty) {
2346 let what = match what {
2347 DefIdOrName::DefId(def_id) => self.tcx.def_descr(def_id),
2348 DefIdOrName::Name(what) => what,
2349 };
2350 let expr_span = expr.span.to(item_name.span);
2351 err.multipart_suggestion(
2352 format!(
2353 "to call the {what} stored in `{item_name}`, \
2354 surround the field access with parentheses",
2355 ),
2356 vec![
2357 (expr_span.shrink_to_lo(), '('.to_string()),
2358 (expr_span.shrink_to_hi(), ')'.to_string()),
2359 ],
2360 Applicability::MachineApplicable,
2361 );
2362 } else {
2363 let call_expr = tcx.hir_expect_expr(tcx.parent_hir_id(expr.hir_id));
2364
2365 if let Some(span) = call_expr.span.trim_start(item_name.span) {
2366 err.span_suggestion(
2367 span,
2368 "remove the arguments",
2369 "",
2370 Applicability::MaybeIncorrect,
2371 );
2372 }
2373 }
2374 }
2375
2376 let field_kind = if is_accessible { "field" } else { "private field" };
2377 err.span_label(item_name.span, format!("{field_kind}, not a method"));
2378 return true;
2379 }
2380 false
2381 }
2382
2383 fn report_failed_method_call_on_range_end(
2386 &self,
2387 tcx: TyCtxt<'tcx>,
2388 actual: Ty<'tcx>,
2389 source: SelfSource<'tcx>,
2390 span: Span,
2391 item_name: Ident,
2392 ) -> Result<(), ErrorGuaranteed> {
2393 if let SelfSource::MethodCall(expr) = source {
2394 for (_, parent) in tcx.hir_parent_iter(expr.hir_id).take(5) {
2395 if let Node::Expr(parent_expr) = parent {
2396 let lang_item = match parent_expr.kind {
2397 ExprKind::Struct(qpath, _, _) => match *qpath {
2398 QPath::LangItem(LangItem::Range, ..) => Some(LangItem::Range),
2399 QPath::LangItem(LangItem::RangeCopy, ..) => Some(LangItem::RangeCopy),
2400 QPath::LangItem(LangItem::RangeInclusiveCopy, ..) => {
2401 Some(LangItem::RangeInclusiveCopy)
2402 }
2403 QPath::LangItem(LangItem::RangeTo, ..) => Some(LangItem::RangeTo),
2404 QPath::LangItem(LangItem::RangeToInclusive, ..) => {
2405 Some(LangItem::RangeToInclusive)
2406 }
2407 _ => None,
2408 },
2409 ExprKind::Call(func, _) => match func.kind {
2410 ExprKind::Path(QPath::LangItem(LangItem::RangeInclusiveNew, ..)) => {
2412 Some(LangItem::RangeInclusiveStruct)
2413 }
2414 _ => None,
2415 },
2416 _ => None,
2417 };
2418
2419 if lang_item.is_none() {
2420 continue;
2421 }
2422
2423 let span_included = match parent_expr.kind {
2424 hir::ExprKind::Struct(_, eps, _) => {
2425 eps.last().is_some_and(|ep| ep.span.contains(span))
2426 }
2427 hir::ExprKind::Call(func, ..) => func.span.contains(span),
2429 _ => false,
2430 };
2431
2432 if !span_included {
2433 continue;
2434 }
2435
2436 let Some(range_def_id) =
2437 lang_item.and_then(|lang_item| self.tcx.lang_items().get(lang_item))
2438 else {
2439 continue;
2440 };
2441 let range_ty =
2442 self.tcx.type_of(range_def_id).instantiate(self.tcx, &[actual.into()]);
2443
2444 let pick = self.lookup_probe_for_diagnostic(
2445 item_name,
2446 range_ty,
2447 expr,
2448 ProbeScope::AllTraits,
2449 None,
2450 );
2451 if pick.is_ok() {
2452 let range_span = parent_expr.span.with_hi(expr.span.hi());
2453 return Err(self.dcx().emit_err(errors::MissingParenthesesInRange {
2454 span,
2455 ty: actual,
2456 method_name: item_name.as_str().to_string(),
2457 add_missing_parentheses: Some(errors::AddMissingParenthesesInRange {
2458 func_name: item_name.name.as_str().to_string(),
2459 left: range_span.shrink_to_lo(),
2460 right: range_span.shrink_to_hi(),
2461 }),
2462 }));
2463 }
2464 }
2465 }
2466 }
2467 Ok(())
2468 }
2469
2470 fn report_failed_method_call_on_numerical_infer_var(
2471 &self,
2472 tcx: TyCtxt<'tcx>,
2473 actual: Ty<'tcx>,
2474 source: SelfSource<'_>,
2475 span: Span,
2476 item_kind: &str,
2477 item_name: Ident,
2478 long_ty_path: &mut Option<PathBuf>,
2479 ) -> Result<(), ErrorGuaranteed> {
2480 let found_candidate = all_traits(self.tcx)
2481 .into_iter()
2482 .any(|info| self.associated_value(info.def_id, item_name).is_some());
2483 let found_assoc = |ty: Ty<'tcx>| {
2484 simplify_type(tcx, ty, TreatParams::InstantiateWithInfer)
2485 .and_then(|simp| {
2486 tcx.incoherent_impls(simp)
2487 .iter()
2488 .find_map(|&id| self.associated_value(id, item_name))
2489 })
2490 .is_some()
2491 };
2492 let found_candidate = found_candidate
2493 || found_assoc(tcx.types.i8)
2494 || found_assoc(tcx.types.i16)
2495 || found_assoc(tcx.types.i32)
2496 || found_assoc(tcx.types.i64)
2497 || found_assoc(tcx.types.i128)
2498 || found_assoc(tcx.types.u8)
2499 || found_assoc(tcx.types.u16)
2500 || found_assoc(tcx.types.u32)
2501 || found_assoc(tcx.types.u64)
2502 || found_assoc(tcx.types.u128)
2503 || found_assoc(tcx.types.f32)
2504 || found_assoc(tcx.types.f64);
2505 if found_candidate
2506 && actual.is_numeric()
2507 && !actual.has_concrete_skeleton()
2508 && let SelfSource::MethodCall(expr) = source
2509 {
2510 let ty_str = self.tcx.short_string(actual, long_ty_path);
2511 let mut err = struct_span_code_err!(
2512 self.dcx(),
2513 span,
2514 E0689,
2515 "can't call {item_kind} `{item_name}` on ambiguous numeric type `{ty_str}`"
2516 );
2517 *err.long_ty_path() = long_ty_path.take();
2518 let concrete_type = if actual.is_integral() { "i32" } else { "f32" };
2519 match expr.kind {
2520 ExprKind::Lit(lit) => {
2521 let snippet = tcx
2523 .sess
2524 .source_map()
2525 .span_to_snippet(lit.span)
2526 .unwrap_or_else(|_| "<numeric literal>".to_owned());
2527
2528 let snippet = snippet.strip_suffix('.').unwrap_or(&snippet);
2531 err.span_suggestion(
2532 lit.span,
2533 format!(
2534 "you must specify a concrete type for this numeric value, \
2535 like `{concrete_type}`"
2536 ),
2537 format!("{snippet}_{concrete_type}"),
2538 Applicability::MaybeIncorrect,
2539 );
2540 }
2541 ExprKind::Path(QPath::Resolved(_, path)) => {
2542 if let hir::def::Res::Local(hir_id) = path.res {
2544 let span = tcx.hir_span(hir_id);
2545 let filename = tcx.sess.source_map().span_to_filename(span);
2546
2547 let parent_node = self.tcx.parent_hir_node(hir_id);
2548 let msg = format!(
2549 "you must specify a type for this binding, like `{concrete_type}`",
2550 );
2551
2552 match (filename, parent_node) {
2553 (
2554 FileName::Real(_),
2555 Node::LetStmt(hir::LetStmt {
2556 source: hir::LocalSource::Normal,
2557 ty,
2558 ..
2559 }),
2560 ) => {
2561 let type_span = ty
2562 .map(|ty| ty.span.with_lo(span.hi()))
2563 .unwrap_or(span.shrink_to_hi());
2564 err.span_suggestion(
2565 type_span,
2568 msg,
2569 format!(": {concrete_type}"),
2570 Applicability::MaybeIncorrect,
2571 );
2572 }
2573 _ => {
2574 err.span_label(span, msg);
2575 }
2576 }
2577 }
2578 }
2579 _ => {}
2580 }
2581 return Err(err.emit());
2582 }
2583 Ok(())
2584 }
2585
2586 pub(crate) fn suggest_assoc_method_call(&self, segs: &[PathSegment<'_>]) {
2590 debug!("suggest_assoc_method_call segs: {:?}", segs);
2591 let [seg1, seg2] = segs else {
2592 return;
2593 };
2594 self.dcx().try_steal_modify_and_emit_err(
2595 seg1.ident.span,
2596 StashKey::CallAssocMethod,
2597 |err| {
2598 let body = self.tcx.hir_body_owned_by(self.body_id);
2599 struct LetVisitor {
2600 ident_name: Symbol,
2601 }
2602
2603 impl<'v> Visitor<'v> for LetVisitor {
2605 type Result = ControlFlow<Option<&'v hir::Expr<'v>>>;
2606 fn visit_stmt(&mut self, ex: &'v hir::Stmt<'v>) -> Self::Result {
2607 if let hir::StmtKind::Let(&hir::LetStmt { pat, init, .. }) = ex.kind
2608 && let hir::PatKind::Binding(_, _, ident, ..) = pat.kind
2609 && ident.name == self.ident_name
2610 {
2611 ControlFlow::Break(init)
2612 } else {
2613 hir::intravisit::walk_stmt(self, ex)
2614 }
2615 }
2616 }
2617
2618 if let Node::Expr(call_expr) = self.tcx.parent_hir_node(seg1.hir_id)
2619 && let ControlFlow::Break(Some(expr)) =
2620 (LetVisitor { ident_name: seg1.ident.name }).visit_body(body)
2621 && let Some(self_ty) = self.node_ty_opt(expr.hir_id)
2622 {
2623 let probe = self.lookup_probe_for_diagnostic(
2624 seg2.ident,
2625 self_ty,
2626 call_expr,
2627 ProbeScope::TraitsInScope,
2628 None,
2629 );
2630 if probe.is_ok() {
2631 let sm = self.infcx.tcx.sess.source_map();
2632 err.span_suggestion_verbose(
2633 sm.span_extend_while(seg1.ident.span.shrink_to_hi(), |c| c == ':')
2634 .unwrap(),
2635 "you may have meant to call an instance method",
2636 ".",
2637 Applicability::MaybeIncorrect,
2638 );
2639 }
2640 }
2641 },
2642 );
2643 }
2644
2645 fn suggest_calling_method_on_field(
2647 &self,
2648 err: &mut Diag<'_>,
2649 source: SelfSource<'tcx>,
2650 span: Span,
2651 actual: Ty<'tcx>,
2652 item_name: Ident,
2653 return_type: Option<Ty<'tcx>>,
2654 ) {
2655 if let SelfSource::MethodCall(expr) = source {
2656 let mod_id = self.tcx.parent_module(expr.hir_id).to_def_id();
2657 for fields in self.get_field_candidates_considering_privacy_for_diag(
2658 span,
2659 actual,
2660 mod_id,
2661 expr.hir_id,
2662 ) {
2663 let call_expr = self.tcx.hir_expect_expr(self.tcx.parent_hir_id(expr.hir_id));
2664
2665 let lang_items = self.tcx.lang_items();
2666 let never_mention_traits = [
2667 lang_items.clone_trait(),
2668 lang_items.deref_trait(),
2669 lang_items.deref_mut_trait(),
2670 self.tcx.get_diagnostic_item(sym::AsRef),
2671 self.tcx.get_diagnostic_item(sym::AsMut),
2672 self.tcx.get_diagnostic_item(sym::Borrow),
2673 self.tcx.get_diagnostic_item(sym::BorrowMut),
2674 ];
2675 let mut candidate_fields: Vec<_> = fields
2676 .into_iter()
2677 .filter_map(|candidate_field| {
2678 self.check_for_nested_field_satisfying_condition_for_diag(
2679 span,
2680 &|_, field_ty| {
2681 self.lookup_probe_for_diagnostic(
2682 item_name,
2683 field_ty,
2684 call_expr,
2685 ProbeScope::TraitsInScope,
2686 return_type,
2687 )
2688 .is_ok_and(|pick| {
2689 !never_mention_traits
2690 .iter()
2691 .flatten()
2692 .any(|def_id| self.tcx.parent(pick.item.def_id) == *def_id)
2693 })
2694 },
2695 candidate_field,
2696 vec![],
2697 mod_id,
2698 expr.hir_id,
2699 )
2700 })
2701 .map(|field_path| {
2702 field_path
2703 .iter()
2704 .map(|id| id.to_string())
2705 .collect::<Vec<String>>()
2706 .join(".")
2707 })
2708 .collect();
2709 candidate_fields.sort();
2710
2711 let len = candidate_fields.len();
2712 if len > 0 {
2713 err.span_suggestions(
2714 item_name.span.shrink_to_lo(),
2715 format!(
2716 "{} of the expressions' fields {} a method of the same name",
2717 if len > 1 { "some" } else { "one" },
2718 if len > 1 { "have" } else { "has" },
2719 ),
2720 candidate_fields.iter().map(|path| format!("{path}.")),
2721 Applicability::MaybeIncorrect,
2722 );
2723 }
2724 }
2725 }
2726 }
2727
2728 fn suggest_unwrapping_inner_self(
2729 &self,
2730 err: &mut Diag<'_>,
2731 source: SelfSource<'tcx>,
2732 actual: Ty<'tcx>,
2733 item_name: Ident,
2734 ) {
2735 let tcx = self.tcx;
2736 let SelfSource::MethodCall(expr) = source else {
2737 return;
2738 };
2739 let call_expr = tcx.hir_expect_expr(tcx.parent_hir_id(expr.hir_id));
2740
2741 let ty::Adt(kind, args) = actual.kind() else {
2742 return;
2743 };
2744 match kind.adt_kind() {
2745 ty::AdtKind::Enum => {
2746 let matching_variants: Vec<_> = kind
2747 .variants()
2748 .iter()
2749 .flat_map(|variant| {
2750 let [field] = &variant.fields.raw[..] else {
2751 return None;
2752 };
2753 let field_ty = field.ty(tcx, args);
2754
2755 if self.resolve_vars_if_possible(field_ty).is_ty_var() {
2757 return None;
2758 }
2759
2760 self.lookup_probe_for_diagnostic(
2761 item_name,
2762 field_ty,
2763 call_expr,
2764 ProbeScope::TraitsInScope,
2765 None,
2766 )
2767 .ok()
2768 .map(|pick| (variant, field, pick))
2769 })
2770 .collect();
2771
2772 let ret_ty_matches = |diagnostic_item| {
2773 if let Some(ret_ty) = self
2774 .ret_coercion
2775 .as_ref()
2776 .map(|c| self.resolve_vars_if_possible(c.borrow().expected_ty()))
2777 && let ty::Adt(kind, _) = ret_ty.kind()
2778 && tcx.get_diagnostic_item(diagnostic_item) == Some(kind.did())
2779 {
2780 true
2781 } else {
2782 false
2783 }
2784 };
2785
2786 match &matching_variants[..] {
2787 [(_, field, pick)] => {
2788 let self_ty = field.ty(tcx, args);
2789 err.span_note(
2790 tcx.def_span(pick.item.def_id),
2791 format!("the method `{item_name}` exists on the type `{self_ty}`"),
2792 );
2793 let (article, kind, variant, question) =
2794 if tcx.is_diagnostic_item(sym::Result, kind.did()) {
2795 ("a", "Result", "Err", ret_ty_matches(sym::Result))
2796 } else if tcx.is_diagnostic_item(sym::Option, kind.did()) {
2797 ("an", "Option", "None", ret_ty_matches(sym::Option))
2798 } else {
2799 return;
2800 };
2801 if question {
2802 err.span_suggestion_verbose(
2803 expr.span.shrink_to_hi(),
2804 format!(
2805 "use the `?` operator to extract the `{self_ty}` value, propagating \
2806 {article} `{kind}::{variant}` value to the caller"
2807 ),
2808 "?",
2809 Applicability::MachineApplicable,
2810 );
2811 } else {
2812 err.span_suggestion_verbose(
2813 expr.span.shrink_to_hi(),
2814 format!(
2815 "consider using `{kind}::expect` to unwrap the `{self_ty}` value, \
2816 panicking if the value is {article} `{kind}::{variant}`"
2817 ),
2818 ".expect(\"REASON\")",
2819 Applicability::HasPlaceholders,
2820 );
2821 }
2822 }
2823 _ => {}
2825 }
2826 }
2827 ty::AdtKind::Struct | ty::AdtKind::Union => {
2830 let [first] = ***args else {
2831 return;
2832 };
2833 let ty::GenericArgKind::Type(ty) = first.kind() else {
2834 return;
2835 };
2836 let Ok(pick) = self.lookup_probe_for_diagnostic(
2837 item_name,
2838 ty,
2839 call_expr,
2840 ProbeScope::TraitsInScope,
2841 None,
2842 ) else {
2843 return;
2844 };
2845
2846 let name = self.ty_to_value_string(actual);
2847 let inner_id = kind.did();
2848 let mutable = if let Some(AutorefOrPtrAdjustment::Autoref { mutbl, .. }) =
2849 pick.autoref_or_ptr_adjustment
2850 {
2851 Some(mutbl)
2852 } else {
2853 None
2854 };
2855
2856 if tcx.is_diagnostic_item(sym::LocalKey, inner_id) {
2857 err.help("use `with` or `try_with` to access thread local storage");
2858 } else if tcx.is_lang_item(kind.did(), LangItem::MaybeUninit) {
2859 err.help(format!(
2860 "if this `{name}` has been initialized, \
2861 use one of the `assume_init` methods to access the inner value"
2862 ));
2863 } else if tcx.is_diagnostic_item(sym::RefCell, inner_id) {
2864 let (suggestion, borrow_kind, panic_if) = match mutable {
2865 Some(Mutability::Not) => (".borrow()", "borrow", "a mutable borrow exists"),
2866 Some(Mutability::Mut) => {
2867 (".borrow_mut()", "mutably borrow", "any borrows exist")
2868 }
2869 None => return,
2870 };
2871 err.span_suggestion_verbose(
2872 expr.span.shrink_to_hi(),
2873 format!(
2874 "use `{suggestion}` to {borrow_kind} the `{ty}`, \
2875 panicking if {panic_if}"
2876 ),
2877 suggestion,
2878 Applicability::MaybeIncorrect,
2879 );
2880 } else if tcx.is_diagnostic_item(sym::Mutex, inner_id) {
2881 err.span_suggestion_verbose(
2882 expr.span.shrink_to_hi(),
2883 format!(
2884 "use `.lock().unwrap()` to borrow the `{ty}`, \
2885 blocking the current thread until it can be acquired"
2886 ),
2887 ".lock().unwrap()",
2888 Applicability::MaybeIncorrect,
2889 );
2890 } else if tcx.is_diagnostic_item(sym::RwLock, inner_id) {
2891 let (suggestion, borrow_kind) = match mutable {
2892 Some(Mutability::Not) => (".read().unwrap()", "borrow"),
2893 Some(Mutability::Mut) => (".write().unwrap()", "mutably borrow"),
2894 None => return,
2895 };
2896 err.span_suggestion_verbose(
2897 expr.span.shrink_to_hi(),
2898 format!(
2899 "use `{suggestion}` to {borrow_kind} the `{ty}`, \
2900 blocking the current thread until it can be acquired"
2901 ),
2902 suggestion,
2903 Applicability::MaybeIncorrect,
2904 );
2905 } else {
2906 return;
2907 };
2908
2909 err.span_note(
2910 tcx.def_span(pick.item.def_id),
2911 format!("the method `{item_name}` exists on the type `{ty}`"),
2912 );
2913 }
2914 }
2915 }
2916
2917 pub(crate) fn note_unmet_impls_on_type(
2918 &self,
2919 err: &mut Diag<'_>,
2920 errors: &[FulfillmentError<'tcx>],
2921 suggest_derive: bool,
2922 ) {
2923 let preds: Vec<_> = errors
2924 .iter()
2925 .filter_map(|e| match e.obligation.predicate.kind().skip_binder() {
2926 ty::PredicateKind::Clause(ty::ClauseKind::Trait(pred)) => {
2927 match pred.self_ty().kind() {
2928 ty::Adt(_, _) => Some(pred),
2929 _ => None,
2930 }
2931 }
2932 _ => None,
2933 })
2934 .collect();
2935
2936 let (mut local_preds, mut foreign_preds): (Vec<_>, Vec<_>) =
2938 preds.iter().partition(|&pred| {
2939 if let ty::Adt(def, _) = pred.self_ty().kind() {
2940 def.did().is_local()
2941 } else {
2942 false
2943 }
2944 });
2945
2946 local_preds.sort_by_key(|pred: &&ty::TraitPredicate<'_>| pred.trait_ref.to_string());
2947 let local_def_ids = local_preds
2948 .iter()
2949 .filter_map(|pred| match pred.self_ty().kind() {
2950 ty::Adt(def, _) => Some(def.did()),
2951 _ => None,
2952 })
2953 .collect::<FxIndexSet<_>>();
2954 let mut local_spans: MultiSpan = local_def_ids
2955 .iter()
2956 .filter_map(|def_id| {
2957 let span = self.tcx.def_span(*def_id);
2958 if span.is_dummy() { None } else { Some(span) }
2959 })
2960 .collect::<Vec<_>>()
2961 .into();
2962 for pred in &local_preds {
2963 if let ty::Adt(def, _) = pred.self_ty().kind() {
2964 local_spans.push_span_label(
2965 self.tcx.def_span(def.did()),
2966 format!("must implement `{}`", pred.trait_ref.print_trait_sugared()),
2967 );
2968 }
2969 }
2970 if local_spans.primary_span().is_some() {
2971 let msg = if let [local_pred] = local_preds.as_slice() {
2972 format!(
2973 "an implementation of `{}` might be missing for `{}`",
2974 local_pred.trait_ref.print_trait_sugared(),
2975 local_pred.self_ty()
2976 )
2977 } else {
2978 format!(
2979 "the following type{} would have to `impl` {} required trait{} for this \
2980 operation to be valid",
2981 pluralize!(local_def_ids.len()),
2982 if local_def_ids.len() == 1 { "its" } else { "their" },
2983 pluralize!(local_preds.len()),
2984 )
2985 };
2986 err.span_note(local_spans, msg);
2987 }
2988
2989 foreign_preds.sort_by_key(|pred: &&ty::TraitPredicate<'_>| pred.trait_ref.to_string());
2990 let foreign_def_ids = foreign_preds
2991 .iter()
2992 .filter_map(|pred| match pred.self_ty().kind() {
2993 ty::Adt(def, _) => Some(def.did()),
2994 _ => None,
2995 })
2996 .collect::<FxIndexSet<_>>();
2997 let mut foreign_spans: MultiSpan = foreign_def_ids
2998 .iter()
2999 .filter_map(|def_id| {
3000 let span = self.tcx.def_span(*def_id);
3001 if span.is_dummy() { None } else { Some(span) }
3002 })
3003 .collect::<Vec<_>>()
3004 .into();
3005 for pred in &foreign_preds {
3006 if let ty::Adt(def, _) = pred.self_ty().kind() {
3007 foreign_spans.push_span_label(
3008 self.tcx.def_span(def.did()),
3009 format!("not implement `{}`", pred.trait_ref.print_trait_sugared()),
3010 );
3011 }
3012 }
3013 if foreign_spans.primary_span().is_some() {
3014 let msg = if let [foreign_pred] = foreign_preds.as_slice() {
3015 format!(
3016 "the foreign item type `{}` doesn't implement `{}`",
3017 foreign_pred.self_ty(),
3018 foreign_pred.trait_ref.print_trait_sugared()
3019 )
3020 } else {
3021 format!(
3022 "the foreign item type{} {} implement required trait{} for this \
3023 operation to be valid",
3024 pluralize!(foreign_def_ids.len()),
3025 if foreign_def_ids.len() > 1 { "don't" } else { "doesn't" },
3026 pluralize!(foreign_preds.len()),
3027 )
3028 };
3029 err.span_note(foreign_spans, msg);
3030 }
3031
3032 let preds: Vec<_> = errors
3033 .iter()
3034 .map(|e| (e.obligation.predicate, None, Some(e.obligation.cause.clone())))
3035 .collect();
3036 if suggest_derive {
3037 self.suggest_derive(err, &preds);
3038 } else {
3039 let _ = self.note_predicate_source_and_get_derives(err, &preds);
3041 }
3042 }
3043
3044 fn note_predicate_source_and_get_derives(
3045 &self,
3046 err: &mut Diag<'_>,
3047 unsatisfied_predicates: &[(
3048 ty::Predicate<'tcx>,
3049 Option<ty::Predicate<'tcx>>,
3050 Option<ObligationCause<'tcx>>,
3051 )],
3052 ) -> Vec<(String, Span, Symbol)> {
3053 let mut derives = Vec::<(String, Span, Symbol)>::new();
3054 let mut traits = Vec::new();
3055 for (pred, _, _) in unsatisfied_predicates {
3056 let Some(ty::PredicateKind::Clause(ty::ClauseKind::Trait(trait_pred))) =
3057 pred.kind().no_bound_vars()
3058 else {
3059 continue;
3060 };
3061 let adt = match trait_pred.self_ty().ty_adt_def() {
3062 Some(adt) if adt.did().is_local() => adt,
3063 _ => continue,
3064 };
3065 if let Some(diagnostic_name) = self.tcx.get_diagnostic_name(trait_pred.def_id()) {
3066 let can_derive = match diagnostic_name {
3067 sym::Default => !adt.is_enum(),
3068 sym::Eq
3069 | sym::PartialEq
3070 | sym::Ord
3071 | sym::PartialOrd
3072 | sym::Clone
3073 | sym::Copy
3074 | sym::Hash
3075 | sym::Debug => true,
3076 _ => false,
3077 };
3078 if can_derive {
3079 let self_name = trait_pred.self_ty().to_string();
3080 let self_span = self.tcx.def_span(adt.did());
3081 for super_trait in
3082 supertraits(self.tcx, ty::Binder::dummy(trait_pred.trait_ref))
3083 {
3084 if let Some(parent_diagnostic_name) =
3085 self.tcx.get_diagnostic_name(super_trait.def_id())
3086 {
3087 derives.push((self_name.clone(), self_span, parent_diagnostic_name));
3088 }
3089 }
3090 derives.push((self_name, self_span, diagnostic_name));
3091 } else {
3092 traits.push(trait_pred.def_id());
3093 }
3094 } else {
3095 traits.push(trait_pred.def_id());
3096 }
3097 }
3098 traits.sort_by_key(|id| self.tcx.def_path_str(id));
3099 traits.dedup();
3100
3101 let len = traits.len();
3102 if len > 0 {
3103 let span =
3104 MultiSpan::from_spans(traits.iter().map(|&did| self.tcx.def_span(did)).collect());
3105 let mut names = format!("`{}`", self.tcx.def_path_str(traits[0]));
3106 for (i, &did) in traits.iter().enumerate().skip(1) {
3107 if len > 2 {
3108 names.push_str(", ");
3109 }
3110 if i == len - 1 {
3111 names.push_str(" and ");
3112 }
3113 names.push('`');
3114 names.push_str(&self.tcx.def_path_str(did));
3115 names.push('`');
3116 }
3117 err.span_note(
3118 span,
3119 format!("the trait{} {} must be implemented", pluralize!(len), names),
3120 );
3121 }
3122
3123 derives
3124 }
3125
3126 pub(crate) fn suggest_derive(
3127 &self,
3128 err: &mut Diag<'_>,
3129 unsatisfied_predicates: &[(
3130 ty::Predicate<'tcx>,
3131 Option<ty::Predicate<'tcx>>,
3132 Option<ObligationCause<'tcx>>,
3133 )],
3134 ) -> bool {
3135 let mut derives = self.note_predicate_source_and_get_derives(err, unsatisfied_predicates);
3136 derives.sort();
3137 derives.dedup();
3138
3139 let mut derives_grouped = Vec::<(String, Span, String)>::new();
3140 for (self_name, self_span, trait_name) in derives.into_iter() {
3141 if let Some((last_self_name, _, last_trait_names)) = derives_grouped.last_mut() {
3142 if last_self_name == &self_name {
3143 last_trait_names.push_str(format!(", {trait_name}").as_str());
3144 continue;
3145 }
3146 }
3147 derives_grouped.push((self_name, self_span, trait_name.to_string()));
3148 }
3149
3150 for (self_name, self_span, traits) in &derives_grouped {
3151 err.span_suggestion_verbose(
3152 self_span.shrink_to_lo(),
3153 format!("consider annotating `{self_name}` with `#[derive({traits})]`"),
3154 format!("#[derive({traits})]\n"),
3155 Applicability::MaybeIncorrect,
3156 );
3157 }
3158 !derives_grouped.is_empty()
3159 }
3160
3161 fn note_derefed_ty_has_method(
3162 &self,
3163 err: &mut Diag<'_>,
3164 self_source: SelfSource<'tcx>,
3165 rcvr_ty: Ty<'tcx>,
3166 item_name: Ident,
3167 expected: Expectation<'tcx>,
3168 ) {
3169 let SelfSource::QPath(ty) = self_source else {
3170 return;
3171 };
3172 for (deref_ty, _) in self.autoderef(DUMMY_SP, rcvr_ty).silence_errors().skip(1) {
3173 if let Ok(pick) = self.probe_for_name(
3174 Mode::Path,
3175 item_name,
3176 expected.only_has_type(self),
3177 IsSuggestion(true),
3178 deref_ty,
3179 ty.hir_id,
3180 ProbeScope::TraitsInScope,
3181 ) {
3182 if deref_ty.is_suggestable(self.tcx, true)
3183 && pick.item.is_method()
3187 && let Some(self_ty) =
3188 self.tcx.fn_sig(pick.item.def_id).instantiate_identity().inputs().skip_binder().get(0)
3189 && self_ty.is_ref()
3190 {
3191 let suggested_path = match deref_ty.kind() {
3192 ty::Bool
3193 | ty::Char
3194 | ty::Int(_)
3195 | ty::Uint(_)
3196 | ty::Float(_)
3197 | ty::Adt(_, _)
3198 | ty::Str
3199 | ty::Alias(ty::Projection | ty::Inherent, _)
3200 | ty::Param(_) => format!("{deref_ty}"),
3201 _ if self
3207 .tcx
3208 .sess
3209 .source_map()
3210 .span_wrapped_by_angle_or_parentheses(ty.span) =>
3211 {
3212 format!("{deref_ty}")
3213 }
3214 _ => format!("<{deref_ty}>"),
3215 };
3216 err.span_suggestion_verbose(
3217 ty.span,
3218 format!("the function `{item_name}` is implemented on `{deref_ty}`"),
3219 suggested_path,
3220 Applicability::MaybeIncorrect,
3221 );
3222 } else {
3223 err.span_note(
3224 ty.span,
3225 format!("the function `{item_name}` is implemented on `{deref_ty}`"),
3226 );
3227 }
3228 return;
3229 }
3230 }
3231 }
3232
3233 fn ty_to_value_string(&self, ty: Ty<'tcx>) -> String {
3235 match ty.kind() {
3236 ty::Adt(def, args) => self.tcx.def_path_str_with_args(def.did(), args),
3237 _ => self.ty_to_string(ty),
3238 }
3239 }
3240
3241 fn suggest_await_before_method(
3242 &self,
3243 err: &mut Diag<'_>,
3244 item_name: Ident,
3245 ty: Ty<'tcx>,
3246 call: &hir::Expr<'_>,
3247 span: Span,
3248 return_type: Option<Ty<'tcx>>,
3249 ) {
3250 let output_ty = match self.err_ctxt().get_impl_future_output_ty(ty) {
3251 Some(output_ty) => self.resolve_vars_if_possible(output_ty),
3252 _ => return,
3253 };
3254 let method_exists =
3255 self.method_exists_for_diagnostic(item_name, output_ty, call.hir_id, return_type);
3256 debug!("suggest_await_before_method: is_method_exist={}", method_exists);
3257 if method_exists {
3258 err.span_suggestion_verbose(
3259 span.shrink_to_lo(),
3260 "consider `await`ing on the `Future` and calling the method on its `Output`",
3261 "await.",
3262 Applicability::MaybeIncorrect,
3263 );
3264 }
3265 }
3266
3267 fn suggest_use_candidates<F>(&self, candidates: Vec<DefId>, handle_candidates: F)
3268 where
3269 F: FnOnce(Vec<String>, Vec<String>, Span),
3270 {
3271 let parent_map = self.tcx.visible_parent_map(());
3272
3273 let scope = self.tcx.parent_module_from_def_id(self.body_id);
3274 let (accessible_candidates, inaccessible_candidates): (Vec<_>, Vec<_>) =
3275 candidates.into_iter().partition(|id| {
3276 let vis = self.tcx.visibility(*id);
3277 vis.is_accessible_from(scope, self.tcx)
3278 });
3279
3280 let sugg = |candidates: Vec<_>, visible| {
3281 let (candidates, globs): (Vec<_>, Vec<_>) =
3284 candidates.into_iter().partition(|trait_did| {
3285 if let Some(parent_did) = parent_map.get(trait_did) {
3286 if *parent_did != self.tcx.parent(*trait_did)
3288 && self
3289 .tcx
3290 .module_children(*parent_did)
3291 .iter()
3292 .filter(|child| child.res.opt_def_id() == Some(*trait_did))
3293 .all(|child| child.ident.name == kw::Underscore)
3294 {
3295 return false;
3296 }
3297 }
3298
3299 true
3300 });
3301
3302 let prefix = if visible { "use " } else { "" };
3303 let postfix = if visible { ";" } else { "" };
3304 let path_strings = candidates.iter().map(|trait_did| {
3305 format!(
3306 "{prefix}{}{postfix}\n",
3307 with_no_visible_paths_if_doc_hidden!(with_crate_prefix!(
3308 self.tcx.def_path_str(*trait_did)
3309 )),
3310 )
3311 });
3312
3313 let glob_path_strings = globs.iter().map(|trait_did| {
3314 let parent_did = parent_map.get(trait_did).unwrap();
3315 format!(
3316 "{prefix}{}::*{postfix} // trait {}\n",
3317 with_no_visible_paths_if_doc_hidden!(with_crate_prefix!(
3318 self.tcx.def_path_str(*parent_did)
3319 )),
3320 self.tcx.item_name(*trait_did),
3321 )
3322 });
3323 let mut sugg: Vec<_> = path_strings.chain(glob_path_strings).collect();
3324 sugg.sort();
3325 sugg
3326 };
3327
3328 let accessible_sugg = sugg(accessible_candidates, true);
3329 let inaccessible_sugg = sugg(inaccessible_candidates, false);
3330
3331 let (module, _, _) = self.tcx.hir_get_module(scope);
3332 let span = module.spans.inject_use_span;
3333 handle_candidates(accessible_sugg, inaccessible_sugg, span);
3334 }
3335
3336 fn suggest_valid_traits(
3337 &self,
3338 err: &mut Diag<'_>,
3339 item_name: Ident,
3340 mut valid_out_of_scope_traits: Vec<DefId>,
3341 explain: bool,
3342 ) -> bool {
3343 valid_out_of_scope_traits.retain(|id| self.tcx.is_user_visible_dep(id.krate));
3344 if !valid_out_of_scope_traits.is_empty() {
3345 let mut candidates = valid_out_of_scope_traits;
3346 candidates.sort_by_key(|id| self.tcx.def_path_str(id));
3347 candidates.dedup();
3348
3349 let edition_fix = candidates
3351 .iter()
3352 .find(|did| self.tcx.is_diagnostic_item(sym::TryInto, **did))
3353 .copied();
3354
3355 if explain {
3356 err.help("items from traits can only be used if the trait is in scope");
3357 }
3358
3359 let msg = format!(
3360 "{this_trait_is} implemented but not in scope",
3361 this_trait_is = if candidates.len() == 1 {
3362 format!(
3363 "trait `{}` which provides `{item_name}` is",
3364 self.tcx.item_name(candidates[0]),
3365 )
3366 } else {
3367 format!("the following traits which provide `{item_name}` are")
3368 }
3369 );
3370
3371 self.suggest_use_candidates(candidates, |accessible_sugg, inaccessible_sugg, span| {
3372 let suggest_for_access = |err: &mut Diag<'_>, mut msg: String, suggs: Vec<_>| {
3373 msg += &format!(
3374 "; perhaps you want to import {one_of}",
3375 one_of = if suggs.len() == 1 { "it" } else { "one of them" },
3376 );
3377 err.span_suggestions(span, msg, suggs, Applicability::MaybeIncorrect);
3378 };
3379 let suggest_for_privacy = |err: &mut Diag<'_>, suggs: Vec<String>| {
3380 let msg = format!(
3381 "{this_trait_is} implemented but not reachable",
3382 this_trait_is = if let [sugg] = suggs.as_slice() {
3383 format!("trait `{}` which provides `{item_name}` is", sugg.trim())
3384 } else {
3385 format!("the following traits which provide `{item_name}` are")
3386 }
3387 );
3388 if suggs.len() == 1 {
3389 err.help(msg);
3390 } else {
3391 err.span_suggestions(span, msg, suggs, Applicability::MaybeIncorrect);
3392 }
3393 };
3394 if accessible_sugg.is_empty() {
3395 suggest_for_privacy(err, inaccessible_sugg);
3397 } else if inaccessible_sugg.is_empty() {
3398 suggest_for_access(err, msg, accessible_sugg);
3399 } else {
3400 suggest_for_access(err, msg, accessible_sugg);
3401 suggest_for_privacy(err, inaccessible_sugg);
3402 }
3403 });
3404
3405 if let Some(did) = edition_fix {
3406 err.note(format!(
3407 "'{}' is included in the prelude starting in Edition 2021",
3408 with_crate_prefix!(self.tcx.def_path_str(did))
3409 ));
3410 }
3411
3412 true
3413 } else {
3414 false
3415 }
3416 }
3417
3418 fn suggest_traits_to_import(
3419 &self,
3420 err: &mut Diag<'_>,
3421 span: Span,
3422 rcvr_ty: Ty<'tcx>,
3423 item_name: Ident,
3424 inputs_len: Option<usize>,
3425 source: SelfSource<'tcx>,
3426 valid_out_of_scope_traits: Vec<DefId>,
3427 static_candidates: &[CandidateSource],
3428 unsatisfied_bounds: bool,
3429 return_type: Option<Ty<'tcx>>,
3430 trait_missing_method: bool,
3431 ) {
3432 let mut alt_rcvr_sugg = false;
3433 let mut trait_in_other_version_found = false;
3434 if let (SelfSource::MethodCall(rcvr), false) = (source, unsatisfied_bounds) {
3435 debug!(
3436 "suggest_traits_to_import: span={:?}, item_name={:?}, rcvr_ty={:?}, rcvr={:?}",
3437 span, item_name, rcvr_ty, rcvr
3438 );
3439 let skippable = [
3440 self.tcx.lang_items().clone_trait(),
3441 self.tcx.lang_items().deref_trait(),
3442 self.tcx.lang_items().deref_mut_trait(),
3443 self.tcx.lang_items().drop_trait(),
3444 self.tcx.get_diagnostic_item(sym::AsRef),
3445 ];
3446 for (rcvr_ty, post, pin_call) in &[
3450 (rcvr_ty, "", None),
3451 (
3452 Ty::new_mut_ref(self.tcx, self.tcx.lifetimes.re_erased, rcvr_ty),
3453 "&mut ",
3454 Some("as_mut"),
3455 ),
3456 (
3457 Ty::new_imm_ref(self.tcx, self.tcx.lifetimes.re_erased, rcvr_ty),
3458 "&",
3459 Some("as_ref"),
3460 ),
3461 ] {
3462 match self.lookup_probe_for_diagnostic(
3463 item_name,
3464 *rcvr_ty,
3465 rcvr,
3466 ProbeScope::AllTraits,
3467 return_type,
3468 ) {
3469 Ok(pick) => {
3470 let did = Some(pick.item.container_id(self.tcx));
3475 if skippable.contains(&did) {
3476 continue;
3477 }
3478 trait_in_other_version_found = self
3479 .detect_and_explain_multiple_crate_versions_of_trait_item(
3480 err,
3481 pick.item.def_id,
3482 rcvr.hir_id,
3483 Some(*rcvr_ty),
3484 );
3485 if pick.autoderefs == 0 && !trait_in_other_version_found {
3486 err.span_label(
3487 pick.item.ident(self.tcx).span,
3488 format!("the method is available for `{rcvr_ty}` here"),
3489 );
3490 }
3491 break;
3492 }
3493 Err(MethodError::Ambiguity(_)) => {
3494 break;
3499 }
3500 Err(_) => (),
3501 }
3502
3503 let Some(unpin_trait) = self.tcx.lang_items().unpin_trait() else {
3504 return;
3505 };
3506 let pred = ty::TraitRef::new(self.tcx, unpin_trait, [*rcvr_ty]);
3507 let unpin = self.predicate_must_hold_considering_regions(&Obligation::new(
3508 self.tcx,
3509 self.misc(rcvr.span),
3510 self.param_env,
3511 pred,
3512 ));
3513 for (rcvr_ty, pre) in &[
3514 (Ty::new_lang_item(self.tcx, *rcvr_ty, LangItem::OwnedBox), "Box::new"),
3515 (Ty::new_lang_item(self.tcx, *rcvr_ty, LangItem::Pin), "Pin::new"),
3516 (Ty::new_diagnostic_item(self.tcx, *rcvr_ty, sym::Arc), "Arc::new"),
3517 (Ty::new_diagnostic_item(self.tcx, *rcvr_ty, sym::Rc), "Rc::new"),
3518 ] {
3519 if let Some(new_rcvr_t) = *rcvr_ty
3520 && let Ok(pick) = self.lookup_probe_for_diagnostic(
3521 item_name,
3522 new_rcvr_t,
3523 rcvr,
3524 ProbeScope::AllTraits,
3525 return_type,
3526 )
3527 {
3528 debug!("try_alt_rcvr: pick candidate {:?}", pick);
3529 let did = pick.item.trait_container(self.tcx);
3530 let skip = skippable.contains(&did)
3536 || (("Pin::new" == *pre)
3537 && ((sym::as_ref == item_name.name) || !unpin))
3538 || inputs_len.is_some_and(|inputs_len| {
3539 pick.item.is_fn()
3540 && self
3541 .tcx
3542 .fn_sig(pick.item.def_id)
3543 .skip_binder()
3544 .skip_binder()
3545 .inputs()
3546 .len()
3547 != inputs_len
3548 });
3549 if pick.autoderefs == 0 && !skip {
3553 err.span_label(
3554 pick.item.ident(self.tcx).span,
3555 format!("the method is available for `{new_rcvr_t}` here"),
3556 );
3557 err.multipart_suggestion(
3558 "consider wrapping the receiver expression with the \
3559 appropriate type",
3560 vec![
3561 (rcvr.span.shrink_to_lo(), format!("{pre}({post}")),
3562 (rcvr.span.shrink_to_hi(), ")".to_string()),
3563 ],
3564 Applicability::MaybeIncorrect,
3565 );
3566 alt_rcvr_sugg = true;
3568 }
3569 }
3570 }
3571 if let Some(new_rcvr_t) = Ty::new_lang_item(self.tcx, *rcvr_ty, LangItem::Pin)
3574 && !alt_rcvr_sugg
3576 && !unpin
3578 && let Some(pin_call) = pin_call
3580 && let Ok(pick) = self.lookup_probe_for_diagnostic(
3582 item_name,
3583 new_rcvr_t,
3584 rcvr,
3585 ProbeScope::AllTraits,
3586 return_type,
3587 )
3588 && !skippable.contains(&Some(pick.item.container_id(self.tcx)))
3591 && pick.item.impl_container(self.tcx).is_none_or(|did| {
3593 match self.tcx.type_of(did).skip_binder().kind() {
3594 ty::Adt(def, _) => Some(def.did()) != self.tcx.lang_items().pin_type(),
3595 _ => true,
3596 }
3597 })
3598 && pick.autoderefs == 0
3600 && inputs_len.is_some_and(|inputs_len| pick.item.is_fn() && self.tcx.fn_sig(pick.item.def_id).skip_binder().skip_binder().inputs().len() == inputs_len)
3603 {
3604 let indent = self
3605 .tcx
3606 .sess
3607 .source_map()
3608 .indentation_before(rcvr.span)
3609 .unwrap_or_else(|| " ".to_string());
3610 let mut expr = rcvr;
3611 while let Node::Expr(call_expr) = self.tcx.parent_hir_node(expr.hir_id)
3612 && let hir::ExprKind::MethodCall(hir::PathSegment { .. }, ..) =
3613 call_expr.kind
3614 {
3615 expr = call_expr;
3616 }
3617 match self.tcx.parent_hir_node(expr.hir_id) {
3618 Node::LetStmt(stmt)
3619 if let Some(init) = stmt.init
3620 && let Ok(code) =
3621 self.tcx.sess.source_map().span_to_snippet(rcvr.span) =>
3622 {
3623 err.multipart_suggestion(
3626 "consider pinning the expression",
3627 vec![
3628 (
3629 stmt.span.shrink_to_lo(),
3630 format!(
3631 "let mut pinned = std::pin::pin!({code});\n{indent}"
3632 ),
3633 ),
3634 (
3635 init.span.until(rcvr.span.shrink_to_hi()),
3636 format!("pinned.{pin_call}()"),
3637 ),
3638 ],
3639 Applicability::MaybeIncorrect,
3640 );
3641 }
3642 Node::Block(_) | Node::Stmt(_) => {
3643 err.multipart_suggestion(
3646 "consider pinning the expression",
3647 vec![
3648 (
3649 rcvr.span.shrink_to_lo(),
3650 "let mut pinned = std::pin::pin!(".to_string(),
3651 ),
3652 (
3653 rcvr.span.shrink_to_hi(),
3654 format!(");\n{indent}pinned.{pin_call}()"),
3655 ),
3656 ],
3657 Applicability::MaybeIncorrect,
3658 );
3659 }
3660 _ => {
3661 err.span_help(
3664 rcvr.span,
3665 "consider pinning the expression with `std::pin::pin!()` and \
3666 assigning that to a new binding",
3667 );
3668 }
3669 }
3670 alt_rcvr_sugg = true;
3672 }
3673 }
3674 }
3675
3676 if let SelfSource::QPath(ty) = source
3677 && !valid_out_of_scope_traits.is_empty()
3678 && let hir::TyKind::Path(path) = ty.kind
3679 && let hir::QPath::Resolved(..) = path
3680 && let Some(assoc) = self
3681 .tcx
3682 .associated_items(valid_out_of_scope_traits[0])
3683 .filter_by_name_unhygienic(item_name.name)
3684 .next()
3685 {
3686 let rcvr_ty = self.node_ty_opt(ty.hir_id);
3691 trait_in_other_version_found = self
3692 .detect_and_explain_multiple_crate_versions_of_trait_item(
3693 err,
3694 assoc.def_id,
3695 ty.hir_id,
3696 rcvr_ty,
3697 );
3698 }
3699 if !trait_in_other_version_found
3700 && self.suggest_valid_traits(err, item_name, valid_out_of_scope_traits, true)
3701 {
3702 return;
3703 }
3704
3705 let type_is_local = self.type_derefs_to_local(span, rcvr_ty, source);
3706
3707 let mut arbitrary_rcvr = vec![];
3708 let mut candidates = all_traits(self.tcx)
3712 .into_iter()
3713 .filter(|info| match self.tcx.lookup_stability(info.def_id) {
3716 Some(attr) => attr.level.is_stable(),
3717 None => true,
3718 })
3719 .filter(|info| {
3720 static_candidates.iter().all(|sc| match *sc {
3723 CandidateSource::Trait(def_id) => def_id != info.def_id,
3724 CandidateSource::Impl(def_id) => {
3725 self.tcx.trait_id_of_impl(def_id) != Some(info.def_id)
3726 }
3727 })
3728 })
3729 .filter(|info| {
3730 (type_is_local || info.def_id.is_local())
3737 && !self.tcx.trait_is_auto(info.def_id)
3738 && self
3739 .associated_value(info.def_id, item_name)
3740 .filter(|item| {
3741 if item.is_fn() {
3742 let id = item
3743 .def_id
3744 .as_local()
3745 .map(|def_id| self.tcx.hir_node_by_def_id(def_id));
3746 if let Some(hir::Node::TraitItem(hir::TraitItem {
3747 kind: hir::TraitItemKind::Fn(fn_sig, method),
3748 ..
3749 })) = id
3750 {
3751 let self_first_arg = match method {
3752 hir::TraitFn::Required([ident, ..]) => {
3753 matches!(ident, Some(Ident { name: kw::SelfLower, .. }))
3754 }
3755 hir::TraitFn::Provided(body_id) => {
3756 self.tcx.hir_body(*body_id).params.first().is_some_and(
3757 |param| {
3758 matches!(
3759 param.pat.kind,
3760 hir::PatKind::Binding(_, _, ident, _)
3761 if ident.name == kw::SelfLower
3762 )
3763 },
3764 )
3765 }
3766 _ => false,
3767 };
3768
3769 if !fn_sig.decl.implicit_self.has_implicit_self()
3770 && self_first_arg
3771 {
3772 if let Some(ty) = fn_sig.decl.inputs.get(0) {
3773 arbitrary_rcvr.push(ty.span);
3774 }
3775 return false;
3776 }
3777 }
3778 }
3779 item.visibility(self.tcx).is_public() || info.def_id.is_local()
3781 })
3782 .is_some()
3783 })
3784 .collect::<Vec<_>>();
3785 for span in &arbitrary_rcvr {
3786 err.span_label(
3787 *span,
3788 "the method might not be found because of this arbitrary self type",
3789 );
3790 }
3791 if alt_rcvr_sugg {
3792 return;
3793 }
3794
3795 if !candidates.is_empty() {
3796 candidates
3798 .sort_by_key(|&info| (!info.def_id.is_local(), self.tcx.def_path_str(info.def_id)));
3799 candidates.dedup();
3800
3801 let param_type = match *rcvr_ty.kind() {
3802 ty::Param(param) => Some(param),
3803 ty::Ref(_, ty, _) => match *ty.kind() {
3804 ty::Param(param) => Some(param),
3805 _ => None,
3806 },
3807 _ => None,
3808 };
3809 if !trait_missing_method {
3810 err.help(if param_type.is_some() {
3811 "items from traits can only be used if the type parameter is bounded by the trait"
3812 } else {
3813 "items from traits can only be used if the trait is implemented and in scope"
3814 });
3815 }
3816
3817 let candidates_len = candidates.len();
3818 let message = |action| {
3819 format!(
3820 "the following {traits_define} an item `{name}`, perhaps you need to {action} \
3821 {one_of_them}:",
3822 traits_define =
3823 if candidates_len == 1 { "trait defines" } else { "traits define" },
3824 action = action,
3825 one_of_them = if candidates_len == 1 { "it" } else { "one of them" },
3826 name = item_name,
3827 )
3828 };
3829 if let Some(param) = param_type {
3831 let generics = self.tcx.generics_of(self.body_id.to_def_id());
3832 let type_param = generics.type_param(param, self.tcx);
3833 let tcx = self.tcx;
3834 if let Some(def_id) = type_param.def_id.as_local() {
3835 let id = tcx.local_def_id_to_hir_id(def_id);
3836 match tcx.hir_node(id) {
3840 Node::GenericParam(param) => {
3841 enum Introducer {
3842 Plus,
3843 Colon,
3844 Nothing,
3845 }
3846 let hir_generics = tcx.hir_get_generics(id.owner.def_id).unwrap();
3847 let trait_def_ids: DefIdSet = hir_generics
3848 .bounds_for_param(def_id)
3849 .flat_map(|bp| bp.bounds.iter())
3850 .filter_map(|bound| bound.trait_ref()?.trait_def_id())
3851 .collect();
3852 if candidates.iter().any(|t| trait_def_ids.contains(&t.def_id)) {
3853 return;
3854 }
3855 let msg = message(format!(
3856 "restrict type parameter `{}` with",
3857 param.name.ident(),
3858 ));
3859 let bounds_span = hir_generics.bounds_span_for_suggestions(def_id);
3860 let mut applicability = Applicability::MaybeIncorrect;
3861 let candidate_strs: Vec<_> = candidates
3864 .iter()
3865 .map(|cand| {
3866 let cand_path = tcx.def_path_str(cand.def_id);
3867 let cand_params = &tcx.generics_of(cand.def_id).own_params;
3868 let cand_args: String = cand_params
3869 .iter()
3870 .skip(1)
3871 .filter_map(|param| match param.kind {
3872 ty::GenericParamDefKind::Type {
3873 has_default: true,
3874 ..
3875 }
3876 | ty::GenericParamDefKind::Const {
3877 has_default: true,
3878 ..
3879 } => None,
3880 _ => Some(param.name.as_str()),
3881 })
3882 .intersperse(", ")
3883 .collect();
3884 if cand_args.is_empty() {
3885 cand_path
3886 } else {
3887 applicability = Applicability::HasPlaceholders;
3888 format!("{cand_path}</* {cand_args} */>")
3889 }
3890 })
3891 .collect();
3892
3893 if rcvr_ty.is_ref()
3894 && param.is_impl_trait()
3895 && let Some((bounds_span, _)) = bounds_span
3896 {
3897 err.multipart_suggestions(
3898 msg,
3899 candidate_strs.iter().map(|cand| {
3900 vec![
3901 (param.span.shrink_to_lo(), "(".to_string()),
3902 (bounds_span, format!(" + {cand})")),
3903 ]
3904 }),
3905 applicability,
3906 );
3907 return;
3908 }
3909
3910 let (sp, introducer, open_paren_sp) =
3911 if let Some((span, open_paren_sp)) = bounds_span {
3912 (span, Introducer::Plus, open_paren_sp)
3913 } else if let Some(colon_span) = param.colon_span {
3914 (colon_span.shrink_to_hi(), Introducer::Nothing, None)
3915 } else if param.is_impl_trait() {
3916 (param.span.shrink_to_hi(), Introducer::Plus, None)
3917 } else {
3918 (param.span.shrink_to_hi(), Introducer::Colon, None)
3919 };
3920
3921 let all_suggs = candidate_strs.iter().map(|cand| {
3922 let suggestion = format!(
3923 "{} {cand}",
3924 match introducer {
3925 Introducer::Plus => " +",
3926 Introducer::Colon => ":",
3927 Introducer::Nothing => "",
3928 },
3929 );
3930
3931 let mut suggs = vec![];
3932
3933 if let Some(open_paren_sp) = open_paren_sp {
3934 suggs.push((open_paren_sp, "(".to_string()));
3935 suggs.push((sp, format!("){suggestion}")));
3936 } else {
3937 suggs.push((sp, suggestion));
3938 }
3939
3940 suggs
3941 });
3942
3943 err.multipart_suggestions(msg, all_suggs, applicability);
3944
3945 return;
3946 }
3947 Node::Item(hir::Item {
3948 kind: hir::ItemKind::Trait(_, _, _, ident, _, bounds, _),
3949 ..
3950 }) => {
3951 let (sp, sep, article) = if bounds.is_empty() {
3952 (ident.span.shrink_to_hi(), ":", "a")
3953 } else {
3954 (bounds.last().unwrap().span().shrink_to_hi(), " +", "another")
3955 };
3956 err.span_suggestions(
3957 sp,
3958 message(format!("add {article} supertrait for")),
3959 candidates
3960 .iter()
3961 .map(|t| format!("{} {}", sep, tcx.def_path_str(t.def_id),)),
3962 Applicability::MaybeIncorrect,
3963 );
3964 return;
3965 }
3966 _ => {}
3967 }
3968 }
3969 }
3970
3971 let (potential_candidates, explicitly_negative) = if param_type.is_some() {
3972 (candidates, Vec::new())
3975 } else if let Some(simp_rcvr_ty) =
3976 simplify_type(self.tcx, rcvr_ty, TreatParams::AsRigid)
3977 {
3978 let mut potential_candidates = Vec::new();
3979 let mut explicitly_negative = Vec::new();
3980 for candidate in candidates {
3981 if self
3983 .tcx
3984 .all_impls(candidate.def_id)
3985 .map(|imp_did| {
3986 self.tcx.impl_trait_header(imp_did).expect(
3987 "inherent impls can't be candidates, only trait impls can be",
3988 )
3989 })
3990 .filter(|header| header.polarity != ty::ImplPolarity::Positive)
3991 .any(|header| {
3992 let imp = header.trait_ref.instantiate_identity();
3993 let imp_simp =
3994 simplify_type(self.tcx, imp.self_ty(), TreatParams::AsRigid);
3995 imp_simp.is_some_and(|s| s == simp_rcvr_ty)
3996 })
3997 {
3998 explicitly_negative.push(candidate);
3999 } else {
4000 potential_candidates.push(candidate);
4001 }
4002 }
4003 (potential_candidates, explicitly_negative)
4004 } else {
4005 (candidates, Vec::new())
4007 };
4008
4009 let impls_trait = |def_id: DefId| {
4010 let args = ty::GenericArgs::for_item(self.tcx, def_id, |param, _| {
4011 if param.index == 0 {
4012 rcvr_ty.into()
4013 } else {
4014 self.infcx.var_for_def(span, param)
4015 }
4016 });
4017 self.infcx
4018 .type_implements_trait(def_id, args, self.param_env)
4019 .must_apply_modulo_regions()
4020 && param_type.is_none()
4021 };
4022 match &potential_candidates[..] {
4023 [] => {}
4024 [trait_info] if trait_info.def_id.is_local() => {
4025 if impls_trait(trait_info.def_id) {
4026 self.suggest_valid_traits(err, item_name, vec![trait_info.def_id], false);
4027 } else {
4028 err.subdiagnostic(CandidateTraitNote {
4029 span: self.tcx.def_span(trait_info.def_id),
4030 trait_name: self.tcx.def_path_str(trait_info.def_id),
4031 item_name,
4032 action_or_ty: if trait_missing_method {
4033 "NONE".to_string()
4034 } else {
4035 param_type.map_or_else(
4036 || "implement".to_string(), |p| p.to_string(),
4038 )
4039 },
4040 });
4041 }
4042 }
4043 trait_infos => {
4044 let mut msg = message(param_type.map_or_else(
4045 || "implement".to_string(), |param| format!("restrict type parameter `{param}` with"),
4047 ));
4048 for (i, trait_info) in trait_infos.iter().enumerate() {
4049 if impls_trait(trait_info.def_id) {
4050 self.suggest_valid_traits(
4051 err,
4052 item_name,
4053 vec![trait_info.def_id],
4054 false,
4055 );
4056 }
4057 msg.push_str(&format!(
4058 "\ncandidate #{}: `{}`",
4059 i + 1,
4060 self.tcx.def_path_str(trait_info.def_id),
4061 ));
4062 }
4063 err.note(msg);
4064 }
4065 }
4066 match &explicitly_negative[..] {
4067 [] => {}
4068 [trait_info] => {
4069 let msg = format!(
4070 "the trait `{}` defines an item `{}`, but is explicitly unimplemented",
4071 self.tcx.def_path_str(trait_info.def_id),
4072 item_name
4073 );
4074 err.note(msg);
4075 }
4076 trait_infos => {
4077 let mut msg = format!(
4078 "the following traits define an item `{item_name}`, but are explicitly unimplemented:"
4079 );
4080 for trait_info in trait_infos {
4081 msg.push_str(&format!("\n{}", self.tcx.def_path_str(trait_info.def_id)));
4082 }
4083 err.note(msg);
4084 }
4085 }
4086 }
4087 }
4088
4089 fn detect_and_explain_multiple_crate_versions_of_trait_item(
4090 &self,
4091 err: &mut Diag<'_>,
4092 item_def_id: DefId,
4093 hir_id: hir::HirId,
4094 rcvr_ty: Option<Ty<'_>>,
4095 ) -> bool {
4096 let hir_id = self.tcx.parent_hir_id(hir_id);
4097 let Some(traits) = self.tcx.in_scope_traits(hir_id) else { return false };
4098 if traits.is_empty() {
4099 return false;
4100 }
4101 let trait_def_id = self.tcx.parent(item_def_id);
4102 if !self.tcx.is_trait(trait_def_id) {
4103 return false;
4104 }
4105 let krate = self.tcx.crate_name(trait_def_id.krate);
4106 let name = self.tcx.item_name(trait_def_id);
4107 let candidates: Vec<_> = traits
4108 .iter()
4109 .filter(|c| {
4110 c.def_id.krate != trait_def_id.krate
4111 && self.tcx.crate_name(c.def_id.krate) == krate
4112 && self.tcx.item_name(c.def_id) == name
4113 })
4114 .map(|c| (c.def_id, c.import_ids.get(0).cloned()))
4115 .collect();
4116 if candidates.is_empty() {
4117 return false;
4118 }
4119 let item_span = self.tcx.def_span(item_def_id);
4120 let msg = format!(
4121 "there are multiple different versions of crate `{krate}` in the dependency graph",
4122 );
4123 let trait_span = self.tcx.def_span(trait_def_id);
4124 let mut multi_span: MultiSpan = trait_span.into();
4125 multi_span.push_span_label(trait_span, "this is the trait that is needed".to_string());
4126 let descr = self.tcx.associated_item(item_def_id).descr();
4127 let rcvr_ty =
4128 rcvr_ty.map(|t| format!("`{t}`")).unwrap_or_else(|| "the receiver".to_string());
4129 multi_span
4130 .push_span_label(item_span, format!("the {descr} is available for {rcvr_ty} here"));
4131 for (def_id, import_def_id) in candidates {
4132 if let Some(import_def_id) = import_def_id {
4133 multi_span.push_span_label(
4134 self.tcx.def_span(import_def_id),
4135 format!(
4136 "`{name}` imported here doesn't correspond to the right version of crate \
4137 `{krate}`",
4138 ),
4139 );
4140 }
4141 multi_span.push_span_label(
4142 self.tcx.def_span(def_id),
4143 "this is the trait that was imported".to_string(),
4144 );
4145 }
4146 err.span_note(multi_span, msg);
4147 true
4148 }
4149
4150 pub(crate) fn suggest_else_fn_with_closure(
4153 &self,
4154 err: &mut Diag<'_>,
4155 expr: &hir::Expr<'_>,
4156 found: Ty<'tcx>,
4157 expected: Ty<'tcx>,
4158 ) -> bool {
4159 let Some((_def_id_or_name, output, _inputs)) = self.extract_callable_info(found) else {
4160 return false;
4161 };
4162
4163 if !self.may_coerce(output, expected) {
4164 return false;
4165 }
4166
4167 if let Node::Expr(call_expr) = self.tcx.parent_hir_node(expr.hir_id)
4168 && let hir::ExprKind::MethodCall(
4169 hir::PathSegment { ident: method_name, .. },
4170 self_expr,
4171 args,
4172 ..,
4173 ) = call_expr.kind
4174 && let Some(self_ty) = self.typeck_results.borrow().expr_ty_opt(self_expr)
4175 {
4176 let new_name = Ident {
4177 name: Symbol::intern(&format!("{}_else", method_name.as_str())),
4178 span: method_name.span,
4179 };
4180 let probe = self.lookup_probe_for_diagnostic(
4181 new_name,
4182 self_ty,
4183 self_expr,
4184 ProbeScope::TraitsInScope,
4185 Some(expected),
4186 );
4187
4188 if let Ok(pick) = probe
4190 && let fn_sig = self.tcx.fn_sig(pick.item.def_id)
4191 && let fn_args = fn_sig.skip_binder().skip_binder().inputs()
4192 && fn_args.len() == args.len() + 1
4193 {
4194 err.span_suggestion_verbose(
4195 method_name.span.shrink_to_hi(),
4196 format!("try calling `{}` instead", new_name.name.as_str()),
4197 "_else",
4198 Applicability::MaybeIncorrect,
4199 );
4200 return true;
4201 }
4202 }
4203 false
4204 }
4205
4206 fn type_derefs_to_local(
4209 &self,
4210 span: Span,
4211 rcvr_ty: Ty<'tcx>,
4212 source: SelfSource<'tcx>,
4213 ) -> bool {
4214 fn is_local(ty: Ty<'_>) -> bool {
4215 match ty.kind() {
4216 ty::Adt(def, _) => def.did().is_local(),
4217 ty::Foreign(did) => did.is_local(),
4218 ty::Dynamic(tr, ..) => tr.principal().is_some_and(|d| d.def_id().is_local()),
4219 ty::Param(_) => true,
4220
4221 _ => false,
4226 }
4227 }
4228
4229 if let SelfSource::QPath(_) = source {
4232 return is_local(rcvr_ty);
4233 }
4234
4235 self.autoderef(span, rcvr_ty).silence_errors().any(|(ty, _)| is_local(ty))
4236 }
4237}
4238
4239#[derive(Copy, Clone, Debug)]
4240enum SelfSource<'a> {
4241 QPath(&'a hir::Ty<'a>),
4242 MethodCall(&'a hir::Expr<'a> ),
4243}
4244
4245#[derive(Copy, Clone, PartialEq, Eq)]
4246pub(crate) struct TraitInfo {
4247 pub def_id: DefId,
4248}
4249
4250pub(crate) fn all_traits(tcx: TyCtxt<'_>) -> Vec<TraitInfo> {
4253 tcx.all_traits_including_private().map(|def_id| TraitInfo { def_id }).collect()
4254}
4255
4256fn print_disambiguation_help<'tcx>(
4257 tcx: TyCtxt<'tcx>,
4258 err: &mut Diag<'_>,
4259 source: SelfSource<'tcx>,
4260 args: Option<&'tcx [hir::Expr<'tcx>]>,
4261 trait_ref: ty::TraitRef<'tcx>,
4262 candidate_idx: Option<usize>,
4263 span: Span,
4264 item: ty::AssocItem,
4265) -> Option<String> {
4266 let trait_impl_type = trait_ref.self_ty().peel_refs();
4267 let trait_ref = if item.is_method() {
4268 trait_ref.print_only_trait_name().to_string()
4269 } else {
4270 format!("<{} as {}>", trait_ref.args[0], trait_ref.print_only_trait_name())
4271 };
4272 Some(
4273 if item.is_fn()
4274 && let SelfSource::MethodCall(receiver) = source
4275 && let Some(args) = args
4276 {
4277 let def_kind_descr = tcx.def_kind_descr(item.as_def_kind(), item.def_id);
4278 let item_name = item.ident(tcx);
4279 let first_input =
4280 tcx.fn_sig(item.def_id).instantiate_identity().skip_binder().inputs().get(0);
4281 let (first_arg_type, rcvr_ref) = (
4282 first_input.map(|first| first.peel_refs()),
4283 first_input
4284 .and_then(|ty| ty.ref_mutability())
4285 .map_or("", |mutbl| mutbl.ref_prefix_str()),
4286 );
4287
4288 let args = if let Some(first_arg_type) = first_arg_type
4290 && (first_arg_type == tcx.types.self_param
4291 || first_arg_type == trait_impl_type
4292 || item.is_method())
4293 {
4294 Some(receiver)
4295 } else {
4296 None
4297 }
4298 .into_iter()
4299 .chain(args)
4300 .map(|arg| {
4301 tcx.sess.source_map().span_to_snippet(arg.span).unwrap_or_else(|_| "_".to_owned())
4302 })
4303 .collect::<Vec<_>>()
4304 .join(", ");
4305
4306 let args = format!("({}{})", rcvr_ref, args);
4307 err.span_suggestion_verbose(
4308 span,
4309 format!(
4310 "disambiguate the {def_kind_descr} for {}",
4311 if let Some(candidate) = candidate_idx {
4312 format!("candidate #{candidate}")
4313 } else {
4314 "the candidate".to_string()
4315 },
4316 ),
4317 format!("{trait_ref}::{item_name}{args}"),
4318 Applicability::HasPlaceholders,
4319 );
4320 return None;
4321 } else {
4322 format!("{trait_ref}::")
4323 },
4324 )
4325}