rustc_lint/

disallowed_pass_by_ref.rs

use rustc_hir::def::Res;
use rustc_hir::{self as hir, AmbigArg, GenericArg, PathSegment, QPath, TyKind, find_attr};
use rustc_middle::ty;
use rustc_session::{declare_lint_pass, declare_tool_lint};

use crate::lints::DisallowedPassByRefDiag;
use crate::{LateContext, LateLintPass, LintContext};

declare_tool_lint! {
    /// The `disallowed_pass_by_ref` lint detects if types marked with `#[rustc_pass_by_value]` are
    /// passed by reference. Types with this marker are usually thin wrappers around references, so
    /// there is no benefit to an extra layer of indirection. (Example: `Ty` which is a reference
    /// to an `Interned<TyKind>`)
    pub rustc::DISALLOWED_PASS_BY_REF,
    Warn,
    "pass by reference of a type flagged as `#[rustc_pass_by_value]`",
    report_in_external_macro: true
}

declare_lint_pass!(DisallowedPassByRef => [DISALLOWED_PASS_BY_REF]);

impl<'tcx> LateLintPass<'tcx> for DisallowedPassByRef {
    fn check_ty(&mut self, cx: &LateContext<'_>, ty: &'tcx hir::Ty<'tcx, AmbigArg>) {
        match &ty.kind {
            TyKind::Ref(_, hir::MutTy { ty: inner_ty, mutbl: hir::Mutability::Not }) => {
                if cx.tcx.trait_impl_of_assoc(ty.hir_id.owner.to_def_id()).is_some() {
                    return;
                }
                if let Some(t) = path_for_rustc_pass_by_value(cx, inner_ty) {
                    cx.emit_span_lint(
                        DISALLOWED_PASS_BY_REF,
                        ty.span,
                        DisallowedPassByRefDiag { ty: t, suggestion: ty.span },
                    );
                }
            }
            _ => {}
        }
    }
}

fn path_for_rustc_pass_by_value(cx: &LateContext<'_>, ty: &hir::Ty<'_>) -> Option<String> {
    if let TyKind::Path(QPath::Resolved(_, path)) = &ty.kind {
        match path.res {
            Res::Def(_, def_id) if find_attr!(cx.tcx, def_id, RustcPassByValue(_)) => {
                let name = cx.tcx.item_ident(def_id);
                let path_segment = path.segments.last().unwrap();
                return Some(format!("{}{}", name, gen_args(cx, path_segment)));
            }
            Res::SelfTyAlias { alias_to: did, is_trait_impl: false, .. } => {
                if let ty::Adt(adt, args) =
                    cx.tcx.type_of(did).instantiate_identity().skip_norm_wip().kind()
                {
                    if find_attr!(cx.tcx, adt.did(), RustcPassByValue(_)) {
                        return Some(cx.tcx.def_path_str_with_args(adt.did(), args));
                    }
                }
            }
            _ => (),
        }
    }

    None
}

fn gen_args(cx: &LateContext<'_>, segment: &PathSegment<'_>) -> String {
    if let Some(args) = &segment.args {
        let params = args
            .args
            .iter()
            .map(|arg| match arg {
                GenericArg::Lifetime(lt) => lt.to_string(),
                GenericArg::Type(ty) => {
                    cx.tcx.sess.source_map().span_to_snippet(ty.span).unwrap_or_else(|_| "_".into())
                }
                GenericArg::Const(c) => {
                    cx.tcx.sess.source_map().span_to_snippet(c.span).unwrap_or_else(|_| "_".into())
                }
                GenericArg::Infer(_) => String::from("_"),
            })
            .collect::<Vec<_>>();

        if !params.is_empty() {
            return format!("<{}>", params.join(", "));
        }
    }

    String::new()
}